[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20927: [fix][txn]Remove subscription after transaction pending ack init failed.

["poorbarcode (via GitHub)" <gi...@apache.org>]

poorbarcode commented on code in PR #20927:
URL: https://github.com/apache/pulsar/pull/20927#discussion_r1283532428


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java:
##########
@@ -946,6 +946,7 @@ public void completeHandleFuture() {
 
     public void exceptionHandleFuture(Throwable t) {
         final boolean completedNow = this.pendingAckHandleCompletableFuture.completeExceptionally(t);
+        persistentSubscription.getTopic().getSubscriptions().remove(subName);

Review Comment:
   The subscription removal only can be executed when the pending ack store initialize failed(there have another place were calling `exceptionHandleFuture(t)`), right? And it only can be executed when the ZK node does not exist, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org