You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "sdedic (via GitHub)" <gi...@apache.org> on 2023/02/20 09:27:03 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #5538: Fix spurious messages printed to the console.
sdedic opened a new pull request, #5538:
URL: https://github.com/apache/netbeans/pull/5538
During testing of NB17, I've seen some messages printed to the console that should not be there.
1/ Maven creates a fallback project, if the pom.xml cannot be read into the model. This is a fairly common, either because of malformed XML, inaccessible basic build plugin (i.e. empty repository) etc. Should be logged, but not at INFO level - that is likely a leftover after debugging maven actions.
2/ After a clean startup with Ergonomics, when Java SE feature is activated, a stacktrace prints to the console from unsuccessful JShell console deserialization:
```
Class: class org.netbeans.modules.jshell.editor.ConsoleEditor
Source: MultiFileObject@7a679502[Windows2Local/Components/JShellEditor.settings]
Caused: java.lang.NoSuchMethodException: org.netbeans.modules.jshell.editor.ConsoleEditor.<init>()
at java.base/java.lang.Class.getConstructor0(Class.java:3349)
at java.base/java.lang.Class.getDeclaredConstructor(Class.java:2553)
at org.netbeans.modules.settings.convertors.XMLSettingsSupport.newInstance(XMLSettingsSupport.java:73)
at org.netbeans.modules.settings.convertors.XMLSettingsSupport$SettingsRecognizer.instanceCreate(XMLSettingsSupport.java:603)
```
The window is marked as `PERSISTENCE_NEVER` but the .settings file is there because of `@TopComponent.Registration`. Other similar windows use a default constructor with limited initialization and features - this patch addds the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5538: Fix spurious messages printed to the console.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5538:
URL: https://github.com/apache/netbeans/pull/5538#issuecomment-1436794675
tests keep failing after 4 restart, but that is caused by #5507 most likely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5538: Fix spurious messages printed to the console.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5538:
URL: https://github.com/apache/netbeans/pull/5538#issuecomment-1437197984
we should consider to put things like this into the cache (I suppose it lands in the global `.m2` folder?). Unfortunately jobs like graalvm download so much that it wouldn't fit since we only have 10gb in total. Currently only the build jobs use the cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5538: Fix spurious messages printed to the console.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5538:
URL: https://github.com/apache/netbeans/pull/5538#issuecomment-1436953694
> > tests keep failing after 4 restarts, but that is caused by #5507 most likely
>
> I doubt that 5507 is involved, as that one only changes package.json in vscode ext that cannot participate in java micronaut tests (the ones that are failing) in any way.
could be only a coincidence of course and it might be something entirely different but a few things indicate that it might be the PR above, since everything started after it was merged - restarting doesn't help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5538: Fix spurious messages printed to the console.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #5538:
URL: https://github.com/apache/netbeans/pull/5538#issuecomment-1437236188
Hm, I think it's actually good that the tests run from a pristine repository: it's hard to spot this kind of bug on a dev machine with all the artifacts and their whatever versions downloaded during development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5538: Fix spurious messages printed to the console.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #5538:
URL: https://github.com/apache/netbeans/pull/5538#issuecomment-1437123677
Marvellous ... when I run the test locally, it failed += same way on an empty gradle repository (with my usual repo content, download was not necessary). Then I run that from commandline (`gradle build`) and:
```
> Configure project :oci
[native-image-plugin] Instrumenting task with the native-image-agent: test
[native-image-plugin] Instrumenting task with the native-image-agent: testNativeImage
FAILURE: Build failed with an exception.
> Could not resolve io.micronaut:micronaut-bom:3.7.0-SNAPSHOT.
Required by:
project :oci
project :oci > project :app
> Could not resolve io.micronaut:micronaut-bom:3.7.0-SNAPSHOT.
> Unable to load Maven meta-data from https://s01.oss.sonatype.org/content/repositories/snapshots/io/micronaut/micronaut-bom/3.7.0-SNAPSHOT/maven-metadata.xml.
> Could not GET 'https://s01.oss.sonatype.org/content/repositories/snapshots/io/micronaut/micronaut-bom/3.7.0-SNAPSHOT/maven-metadata.xml'.
> Read timed out
```
I LOVE cloud solutions and repositories...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5538: Fix spurious messages printed to the console.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5538:
URL: https://github.com/apache/netbeans/pull/5538#issuecomment-1437298708
@neilcsmith-net i was more thinking about things which aren't downloaded by `DownloadBinaries.java`.
the PR you linked is actually super important since it makes sure everything lands in `.hgexternalcache` which is later cached by CI using the hashes of binaries-list as key. If part of it would be loaded from .m2 it would be unpredictable what lands in the build cache and what will be redownloaded again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5538: Fix spurious messages printed to the console.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5538:
URL: https://github.com/apache/netbeans/pull/5538#issuecomment-1437246272
> Hm, I think it's actually good that the tests run from a pristine repository: it's hard to spot this kind of bug on a dev machine with all the artifacts and their whatever versions downloaded during development.
its a question how well we pick the cache key. The build jobs hashes all binaries-list files, which works really well so far:
https://github.com/apache/netbeans/blob/master/.github/workflows/main.yml#L114
gradle cache config could look like this:
https://github.com/actions/cache/blob/main/examples.md#java---gradle
the graalvm cache key could be the graalvm git tag (but I fear the whole jdk repo is too big to put into the cache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5538: Fix spurious messages printed to the console.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5538:
URL: https://github.com/apache/netbeans/pull/5538#issuecomment-1437287803
> Hm, I think it's actually good that the tests run from a pristine repository
That makes some sense. Certainly the reason we bypass the local `.m2` folder in the build #2710 was due to corruption of the local repository on the Jenkins nodes.
I do think that having any test, or anything in the build, relying on a remote -SNAPSHOT is asking for trouble. And non-snapshot availability should be much better anyway?!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5538: Fix spurious messages printed to the console.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5538:
URL: https://github.com/apache/netbeans/pull/5538#issuecomment-1437033230
i diffed the log of the last green run on master and the first failing run on master and noticed something interesting:
the stack trace changes slightly, compare:
* https://github.com/apache/netbeans/actions/runs/4213555133/jobs/7313435246#step:6:972 with
* https://github.com/apache/netbeans/actions/runs/4222367720/jobs/7333205049#step:6:979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5538: Fix spurious messages printed to the console.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #5538:
URL: https://github.com/apache/netbeans/pull/5538#issuecomment-1436944149
> tests keep failing after 4 restarts, but that is caused by #5507 most likely
I doubt that 5507 is involved, as that one only changes package.json in vscode ext that cannot participate in java micronaut tests (the ones that are failing) in any way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #5538: Fix spurious messages printed to the console.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #5538:
URL: https://github.com/apache/netbeans/pull/5538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5538: Fix spurious messages printed to the console.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #5538:
URL: https://github.com/apache/netbeans/pull/5538#issuecomment-1436965425
From the logs I see the tests run against
```
2023-02-20T09:27:59.7510472Z * [new ref] c02d66d5a6b20bd5383f2fe949b585f14d710bf2 -> pull/5538/merge
```
so I'll try to run tests on that exact commit locally. We'll see. There *is* some burried race condition with project infrastructure that causes micronaut and/or maven project tests to fail occasionally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5538: Fix spurious messages printed to the console.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5538:
URL: https://github.com/apache/netbeans/pull/5538#issuecomment-1437141199
> I LOVE cloud solutions and repositories...
... especially when they rely on SNAPSHOTs! :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists