You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Yong Qiao Wang <ja...@gmail.com> on 2015/08/07 10:12:44 UTC
Review Request 37208: Fix the spell error in help message of slave
component.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37208/
-----------------------------------------------------------
Review request for mesos and Zhiwei Chen.
Bugs: MESOS-3228
https://issues.apache.org/jira/browse/MESOS-3228
Repository: mesos
Description
-------
Fix the spell error in help message of slave component.
Diffs
-----
src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e
Diff: https://reviews.apache.org/r/37208/diff/
Testing
-------
Thanks,
Yong Qiao Wang
Re: Review Request 37208: Fix the spell error in help message of slave
component.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37208/#review94518
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37208]
All tests passed.
- Mesos ReviewBot
On Aug. 7, 2015, 8:12 a.m., Yong Qiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37208/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2015, 8:12 a.m.)
>
>
> Review request for mesos and Zhiwei Chen.
>
>
> Bugs: MESOS-3228
> https://issues.apache.org/jira/browse/MESOS-3228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix the spell error in help message of slave component.
>
>
> Diffs
> -----
>
> src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e
>
> Diff: https://reviews.apache.org/r/37208/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yong Qiao Wang
>
>
Re: Review Request 37208: Fix the spell error in help message of slave
component.
Posted by Marco Massenzio <ma...@mesosphere.io>.
> On Aug. 8, 2015, 8:43 a.m., Marco Massenzio wrote:
> >
Can you also please update the Jira, move to Reviewable & a link to this RR.
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37208/#review94625
-----------------------------------------------------------
On Aug. 7, 2015, 8:12 a.m., Yong Qiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37208/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2015, 8:12 a.m.)
>
>
> Review request for mesos and Zhiwei Chen.
>
>
> Bugs: MESOS-3228
> https://issues.apache.org/jira/browse/MESOS-3228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix the spell error in help message of slave component.
>
>
> Diffs
> -----
>
> src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e
>
> Diff: https://reviews.apache.org/r/37208/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yong Qiao Wang
>
>
Re: Review Request 37208: Fix the spell error in help message of slave
component.
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37208/#review94625
-----------------------------------------------------------
Ship it!
- Marco Massenzio
On Aug. 7, 2015, 8:12 a.m., Yong Qiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37208/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2015, 8:12 a.m.)
>
>
> Review request for mesos and Zhiwei Chen.
>
>
> Bugs: MESOS-3228
> https://issues.apache.org/jira/browse/MESOS-3228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix the spell error in help message of slave component.
>
>
> Diffs
> -----
>
> src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e
>
> Diff: https://reviews.apache.org/r/37208/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yong Qiao Wang
>
>