You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by vi...@apache.org on 2026/09/22 06:39:30 UTC

(spark-connect-gateway) branch main updated: [SPARK-59657] Update the redis and base64 dependencies

This is an automated email from the ASF dual-hosted git repository.

viirya pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/spark-connect-gateway.git


The following commit(s) were added to refs/heads/main by this push:
     new 0148e8d  [SPARK-59657] Update the redis and base64 dependencies
0148e8d is described below

commit 0148e8d86515e6dbefa5721018e0da3ded54cf82
Author: Liang-Chi Hsieh <vi...@gmail.com>
AuthorDate: Mon Sep 21 23:39:20 2026 -0700

    [SPARK-59657] Update the redis and base64 dependencies
    
    ### What changes were proposed in this pull request?
    
    Two small dependency updates:
    
    ```
    redis   1.6.0 -> 1.7.0  (Cargo.lock only)
    base64  0.22  -> 0.23   (crates/auth dev-dependency)
    ```
    
    The lock also picks up `combine` 4.6.7 -> 4.6.8, which is redis's parser
    dependency coming along with it.
    
    This supersedes #34 and #33, both closed.
    
    ### Why are the changes needed?
    
    Routine dependency maintenance. The reason it is a hand-written PR rather than
    merging dependabot's two is worth stating, because it is not obvious from their
    diffs.
    
    Both branches were cut before SPARK-59552 landed, so each one *also* reverts
    `jsonwebtoken` from
    
    ```toml
    { version = "10", default-features = false, features = ["use_pem", "rust_crypto"] }
    ```
    
    back to `"9"`, dropping around 270 lines from `Cargo.lock` with it. That would
    silently undo the crypto provider selection — and because `jsonwebtoken = "9"`
    compiles cleanly and passes every test, **CI would not catch it**. Five of the
    current dependabot PRs share this property, so it is worth knowing about when
    triaging the rest of the batch. Applying the two updates directly avoids waiting
    for dependabot to rebase.
    
    One deliberate difference from #34: it also narrowed the manifest requirement from
    `redis = "1"` to `"1.7"`. That narrowing is unnecessary — the existing `"1"`
    requirement already admits 1.7.0 — so the root `Cargo.toml` is untouched here and
    only `Cargo.lock` moves.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No. Dependency versions only.
    
    ### How was this patch tested?
    
    The two updates carry different risk, so they were checked differently rather
    than uniformly.
    
    **`redis` is a production dependency and backs the affinity store**, so it was
    exercised against a real Redis instead of being taken as verified because it
    compiles. All nine Redis integration tests pass:
    
    ```
    scg-store-redis (5)   session_bind_resolve_forget_roundtrip
                          op_reverse_index_roundtrip
                          session_ttl_expires
                          bind_session_if_absent_is_atomic
                          two_stores_against_same_redis_share_state
    scg-ratelimit (4)     burst_admits_then_rejects
                          refill_admits_after_wait
                          tenants_are_independent
                          two_replicas_share_the_bucket
    ```
    
    These are the `#[ignore]`d tests that CI's `integration` job runs; they cover the
    atomicity and TTL behaviour the affinity store depends on, which a build cannot
    speak to.
    
    **`base64` is a dev-dependency of `crates/auth` only** — its 30 tests pass.
    
    **Full workspace:**
    
    | check | result |
    |---|---|
    | `cargo test --workspace` | 204 passed, 0 failed, 10 ignored — same as the baseline on `main` |
    | `cargo clippy --workspace --all-targets -- -D warnings` | clean |
    | `cargo fmt --all --check` | clean |
    
    I also confirmed the provider selection survived, since that is the specific thing
    the dependabot versions would have broken: `Cargo.lock` still resolves
    `jsonwebtoken` 10.4.0, and the only `scg-auth` dependency line that changed is
    `base64 0.22.1` -> `0.23.1`.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    Yes, co-authored with Claude Code.
    
    Closes #35 from viirya/dep-03-redis-base64.
    
    Authored-by: Liang-Chi Hsieh <vi...@gmail.com>
    Signed-off-by: Liang-Chi Hsieh <li...@databricks.com>
---
 Cargo.lock             | 18 +++++++++---------
 crates/auth/Cargo.toml |  2 +-
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/Cargo.lock b/Cargo.lock
index 2e98dfc..c54c027 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -497,9 +497,9 @@ checksum = "1d07550c9036bf2ae0c684c4297d503f838287c83c53686d05370d0e139ae570"
 
 [[package]]
 name = "combine"
-version = "4.6.7"
+version = "4.6.8"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "ba5a308b75df32fe02788e748662718f03fde005016435c444eea572398219fd"
+checksum = "cfc320937d09e6de266b31b9afb480f197d7a861be86be7cb2ea7e5d1bfffc5e"
 dependencies = [
  "bytes",
  "futures-core",
@@ -872,7 +872,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "39cab71617ae0d63f51a36d69f866391735b51691dbda63cf6f96d042b63efeb"
 dependencies = [
  "libc",
- "windows-sys 0.61.2",
+ "windows-sys 0.52.0",
 ]
 
 [[package]]
@@ -2590,7 +2590,7 @@ dependencies = [
  "once_cell",
  "socket2",
  "tracing",
- "windows-sys 0.61.2",
+ "windows-sys 0.52.0",
 ]
 
 [[package]]
@@ -2701,9 +2701,9 @@ dependencies = [
 
 [[package]]
 name = "redis"
-version = "1.6.0"
+version = "1.7.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "e37a4ca5c6ca42aa3e6df2fd32b987a65d32a4c2159a6f3fe0fd1df306a2658f"
+checksum = "2acbc41a996f7652b2ddd9dfd98cc4ff602cfd742ae35382f07f608405ab50ed"
 dependencies = [
  "arc-swap",
  "arcstr",
@@ -2891,7 +2891,7 @@ dependencies = [
  "errno",
  "libc",
  "linux-raw-sys",
- "windows-sys 0.61.2",
+ "windows-sys 0.52.0",
 ]
 
 [[package]]
@@ -2968,7 +2968,7 @@ name = "scg-auth"
 version = "0.1.0"
 dependencies = [
  "async-trait",
- "base64 0.22.1",
+ "base64 0.23.1",
  "jsonwebtoken",
  "parking_lot",
  "rand 0.8.7",
@@ -3569,7 +3569,7 @@ dependencies = [
  "getrandom 0.4.3",
  "once_cell",
  "rustix",
- "windows-sys 0.61.2",
+ "windows-sys 0.52.0",
 ]
 
 [[package]]
diff --git a/crates/auth/Cargo.toml b/crates/auth/Cargo.toml
index e83890f..8da6390 100644
--- a/crates/auth/Cargo.toml
+++ b/crates/auth/Cargo.toml
@@ -44,4 +44,4 @@ tokio = { workspace = true }
 wiremock = "0.6"
 rsa = "0.9"
 rand = "0.8"
-base64 = "0.22"
+base64 = "0.23"


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org