You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2017/07/09 22:38:21 UTC
svn commit: r1801397 - in /commons/proper/email/trunk/src: main/java/org/apache/commons/mail/Email.java test/java/org/apache/commons/mail/util/IDNEmailAddressConverterTest.java

Author: ggregory
Date: Sun Jul  9 22:38:20 2017
New Revision: 1801397

URL: http://svn.apache.org/viewvc?rev=1801397&view=rev
Log:
Add final modifier to local variables.

Modified:
    commons/proper/email/trunk/src/main/java/org/apache/commons/mail/Email.java
    commons/proper/email/trunk/src/test/java/org/apache/commons/mail/util/IDNEmailAddressConverterTest.java

Modified: commons/proper/email/trunk/src/main/java/org/apache/commons/mail/Email.java
URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/src/main/java/org/apache/commons/mail/Email.java?rev=1801397&r1=1801396&r2=1801397&view=diff
==============================================================================
--- commons/proper/email/trunk/src/main/java/org/apache/commons/mail/Email.java (original)
+++ commons/proper/email/trunk/src/main/java/org/apache/commons/mail/Email.java Sun Jul  9 22:38:20 2017
@@ -1274,7 +1274,7 @@ public abstract class Email
             {
                 this.bounceAddress = createInternetAddress(email, null, this.charset).getAddress();
             }
-            catch (EmailException e)
+            catch (final EmailException e)
             {
                 // Can't throw 'EmailException' to keep backward-compatibility
                 throw new IllegalArgumentException("Failed to set the bounce address : " + email, e);

Modified: commons/proper/email/trunk/src/test/java/org/apache/commons/mail/util/IDNEmailAddressConverterTest.java
URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/src/test/java/org/apache/commons/mail/util/IDNEmailAddressConverterTest.java?rev=1801397&r1=1801396&r2=1801397&view=diff
==============================================================================
--- commons/proper/email/trunk/src/test/java/org/apache/commons/mail/util/IDNEmailAddressConverterTest.java (original)
+++ commons/proper/email/trunk/src/test/java/org/apache/commons/mail/util/IDNEmailAddressConverterTest.java Sun Jul  9 22:38:20 2017
@@ -69,17 +69,17 @@ public class IDNEmailAddressConverterTes
     @Test
     public void testInternetAddressToAsciiConversion() throws Exception
     {
-        InternetAddress address = new InternetAddress(idnEmailConverter.toASCII(AUSTRIAN_IDN_EMAIL_ADDRESS));
+        final InternetAddress address = new InternetAddress(idnEmailConverter.toASCII(AUSTRIAN_IDN_EMAIL_ADDRESS));
         assertEquals(AUSTRIAN_IDN_EMAIL_ADDRESS, idnEmailConverter.toUnicode(address));
 
-        InternetAddress addressWithPersonalName = new InternetAddress(idnEmailConverter.toASCII(AUSTRIAN_IDN_EMAIL_ADDRESS), GERMAN_IDN_EMAIL_NAME);
+        final InternetAddress addressWithPersonalName = new InternetAddress(idnEmailConverter.toASCII(AUSTRIAN_IDN_EMAIL_ADDRESS), GERMAN_IDN_EMAIL_NAME);
         assertEquals(AUSTRIAN_IDN_EMAIL_ADDRESS, idnEmailConverter.toUnicode(addressWithPersonalName));
     }
 
     @Test
     public void testRoundTripConversionOfIDNEmailAddress()
     {
-        for(String email : IDN_EMAIL_ADDRESSES)
+        for(final String email : IDN_EMAIL_ADDRESSES)
         {
             assertEquals(email, idnEmailConverter.toUnicode(idnEmailConverter.toASCII(email)));
         }