[jira] [Commented] (PROTON-870) none_sasl.c should use pn_strdup

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516068#comment-14516068 ] 

ASF GitHub Bot commented on PROTON-870:
---------------------------------------

GitHub user dcristoloveanu opened a pull request:

    https://github.com/apache/qpid-proton/pull/24

    Fix none_sasl.c to use pn_strdup instead of strdup

    (PROTON-870) none_sasl.c should use pn_strdup.
    
    none_sasl.c uses strdup, but strdup is not part of C99 and subsequently does not exist on some platforms. Instead pn_strdup should be used.
    
    Thanks,
    /Dan

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dcristoloveanu/qpid-proton NoneSASL

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit 300ffc4246f0007a70b40954e29fbbe44796ad74
Author: dcristoloveanu <dc...@microsoft.com>
Date:   2015-04-28T00:44:05Z

    Fix none_sasl.c to use pn_strdup instead of strdup

----


> none_sasl.c should use pn_strdup
> --------------------------------
>
>                 Key: PROTON-870
>                 URL: https://issues.apache.org/jira/browse/PROTON-870
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.10
>            Reporter: Dan Cristoloveanu
>            Priority: Trivial
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> none_sasl.c uses strdup, but strdup is not part of C99 and subsequently does not exist on some platforms. Instead pn_strdup should be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)