[GitHub] [servicecomb-service-center] jasononion commented on a change in pull request #755: Incremental synchronization of sc: sync between sc and syncer

[GitBox <gi...@apache.org>]

jasononion commented on a change in pull request #755:
URL: https://github.com/apache/servicecomb-service-center/pull/755#discussion_r530970598



##########
File path: etc/conf/app.yaml
##########
@@ -120,3 +120,6 @@ tracing:
 
 quota:
   kind:
+
+syncer:
+  enable: false

Review comment:
       改成enabled

##########
File path: datasource/etcd/event/instance_event_handler.go
##########
@@ -144,3 +151,26 @@ func PublishInstanceEvent(evt sd.KvEvent, domainProject string, serviceKey *pb.M
 		}
 	}
 }
+
+func NotifySyncerInstanceEvent(evt sd.KvEvent, domainProject string, ms *pb.MicroService) {
+	msInstance := evt.KV.Value.(*pb.MicroServiceInstance)
+
+	serviceKey := "/cse-sr/ms/files/" + domainProject + "/" + ms.ServiceId

Review comment:
       /cse-sr/ms/files/ 用常量

##########
File path: server/server.go
##########
@@ -173,6 +176,12 @@ func (s *ServiceCenterServer) startServices() {
 	// notifications
 	s.notifyService.Start()
 
+	// notify syncer
+	syncerEnable := config.GetBool("syncer.enable", false)

Review comment:
       这里的配置项对应修改一下




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org