You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/01/06 00:45:04 UTC

Re: Review Request 41648: Used initializer list c-tor for brevity.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41648/
-----------------------------------------------------------

(Updated Jan. 5, 2016, 11:45 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Changes
-------

Rebased.


Repository: mesos


Description
-------

Used initializer list c-tor for brevity.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 

Diff: https://reviews.apache.org/r/41648/diff/


Testing
-------

`make check` on Mac OS 10.10.4


Thanks,

Alexander Rukletsov


Re: Review Request 41648: Used initializer list c-tor for brevity.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41648/#review115383
-----------------------------------------------------------

Ship it!


Ship It!

- Bernd Mathiske


On Jan. 12, 2016, 1:33 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41648/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 1:33 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used initializer list c-tor for brevity.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
> 
> Diff: https://reviews.apache.org/r/41648/diff/
> 
> 
> Testing
> -------
> 
> `make check` on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 41648: Used initializer list c-tor for brevity.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41648/#review115805
-----------------------------------------------------------

Ship it!


- Ben Mahler


On Jan. 22, 2016, 1:24 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41648/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 1:24 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, Joerg Schad, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 53d8784a3c4f0467756d7bd924e624ba4585e776 
> 
> Diff: https://reviews.apache.org/r/41648/diff/
> 
> 
> Testing
> -------
> 
> `make check` on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 41648: Used initializer list c-tor for brevity.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41648/#review115758
-----------------------------------------------------------

Ship it!


Ship It!

- Guangya Liu


On 一月 22, 2016, 1:24 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41648/
> -----------------------------------------------------------
> 
> (Updated 一月 22, 2016, 1:24 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, Joerg Schad, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 53d8784a3c4f0467756d7bd924e624ba4585e776 
> 
> Diff: https://reviews.apache.org/r/41648/diff/
> 
> 
> Testing
> -------
> 
> `make check` on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 41648: Used initializer list c-tor for brevity.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41648/
-----------------------------------------------------------

(Updated Jan. 22, 2016, 1:24 a.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, Joerg Schad, and Joris Van Remoortere.


Changes
-------

Rebased.


Repository: mesos


Description (updated)
-------

See summary.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.cpp 53d8784a3c4f0467756d7bd924e624ba4585e776 

Diff: https://reviews.apache.org/r/41648/diff/


Testing
-------

`make check` on Mac OS 10.10.4


Thanks,

Alexander Rukletsov


Re: Review Request 41648: Used initializer list c-tor for brevity.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41648/
-----------------------------------------------------------

(Updated Jan. 12, 2016, 9:33 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Changes
-------

Rebased.


Repository: mesos


Description
-------

Used initializer list c-tor for brevity.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 

Diff: https://reviews.apache.org/r/41648/diff/


Testing
-------

`make check` on Mac OS 10.10.4


Thanks,

Alexander Rukletsov


Re: Review Request 41648: Used initializer list c-tor for brevity.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41648/#review113032
-----------------------------------------------------------

Ship it!


Ship It!

- Joerg Schad


On Jan. 5, 2016, 11:45 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41648/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 11:45 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used initializer list c-tor for brevity.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
> 
> Diff: https://reviews.apache.org/r/41648/diff/
> 
> 
> Testing
> -------
> 
> `make check` on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 41648: Used initializer list c-tor for brevity.

Posted by Cong Wang <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41648/#review112962
-----------------------------------------------------------

Ship it!


Ship It!

- Cong Wang


On Jan. 5, 2016, 11:45 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41648/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 11:45 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used initializer list c-tor for brevity.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
> 
> Diff: https://reviews.apache.org/r/41648/diff/
> 
> 
> Testing
> -------
> 
> `make check` on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>