[jira] Resolved: (BUILDR-321) ActsAsArtifact#upload and ActsAsArtifact#download assume artifact name is already valid maven file name when uploading

["Antoine Toulme (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BUILDR-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antoine Toulme resolved BUILDR-321.
-----------------------------------

    Resolution: Invalid

I don't get the use case. Please explain why we should use such mechanism, with specs eventually ?

> ActsAsArtifact#upload and ActsAsArtifact#download assume artifact name is already valid maven file name when uploading
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: BUILDR-321
>                 URL: https://issues.apache.org/jira/browse/BUILDR-321
>             Project: Buildr
>          Issue Type: Bug
>            Reporter: Ittay Dror
>
> In ActsAsArtifact#install, the path in the local repository is computed as: Buildr.repositories.locate(self). this uses only the artifact spec to create the file name.
> ActsAsArtifact#upload does:       path = group.gsub('.', '/') + "/#{id}/#{version}/#{File.basename(name)}", which assumes that 'name' is already of the form "#{id}-#{version}" 
> same for ActsAsArtifact#download
> I suggest to use something like the locate method in both

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.