[jira] Commented: (LUCENE-1754) Get rid of NonMatchingScorer from BooleanScorer2

["Shai Erera (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733145#action_12733145 ] 

Shai Erera commented on LUCENE-1754:
------------------------------------

I thought it's going to be easy too soon :).

After I've made the changes, some tests in TestBooleanMinShouldMatch fail w/ NPE. That's because previously we always returned BS2, which used NonMatchingScorer internally, and now we return null. Therefore this looks like a back-compat issue, but not sure how serious it is. The reason is that BooleanWeight.scorer() already returns null today in some situations, therefore any code that calls BooleanWeight.scorer() directly should already check that it didn't get null. So I'm not sure if it's indeed back-compat problem or not.

What do you think?

> Get rid of NonMatchingScorer from BooleanScorer2
> ------------------------------------------------
>
>                 Key: LUCENE-1754
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1754
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>            Reporter: Shai Erera
>            Priority: Minor
>             Fix For: 2.9
>
>
> Over in Lucene-1614 Mike has made a comment about removing NonMatchinScorer from BS2, and return null in BooleanWeight.scorer(). I've checked and this can be easily done, so I'm going to post a patch shortly. For reference: https://issues.apache.org/jira/browse/LUCENE-1614?focusedCommentId=12715064&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12715064.
> I've marked the issue as 2.9 just because it's small, and kind of related to all the search enhancements done for 2.9.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org