You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/02/26 01:51:36 UTC
[GitHub] [guacamole-client] necouchman opened a new pull request #475:
GUACAMOLE-966: Bump client version numbers to 1.2.0
necouchman opened a new pull request #475: GUACAMOLE-966: Bump client version numbers to 1.2.0
URL: https://github.com/apache/guacamole-client/pull/475
Pull Request to bump versions within the client up to 1.2.0. I did *NOT* bump the API version (`guacamole-common-js/src/main/webapp/modules/Version.js`) as I do not think the API has changed?? Let me know if that one should still be added, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] necouchman commented on a change in pull request
#475: GUACAMOLE-966: Bump client version numbers to 1.2.0
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #475: GUACAMOLE-966: Bump client version numbers to 1.2.0
URL: https://github.com/apache/guacamole-client/pull/475#discussion_r385310455
##########
File path: doc/guacamole-example/pom.xml
##########
@@ -106,15 +106,15 @@
<dependency>
<groupId>org.apache.guacamole</groupId>
<artifactId>guacamole-common</artifactId>
- <version>1.1.0</version>
+ <version>1.2.0</version>
Review comment:
Oops, fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] necouchman commented on issue #475:
GUACAMOLE-966: Bump client version numbers to 1.2.0
Posted by GitBox <gi...@apache.org>.
necouchman commented on issue #475: GUACAMOLE-966: Bump client version numbers to 1.2.0
URL: https://github.com/apache/guacamole-client/pull/475#issuecomment-591911218
Okay - addressed the issues:
* Bumped the JS API version up to 1.2.0.
* Reverted the common version to 1.1.0
* Removed the explicit dependency on `guacamole-common` from `pom.xml` files where `guacamole-ext` is already being pulled in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] mike-jumper commented on a change in pull
request #475: GUACAMOLE-966: Bump client version numbers to 1.2.0
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #475: GUACAMOLE-966: Bump client version numbers to 1.2.0
URL: https://github.com/apache/guacamole-client/pull/475#discussion_r384884894
##########
File path: guacamole-common/pom.xml
##########
@@ -26,7 +26,7 @@
<groupId>org.apache.guacamole</groupId>
<artifactId>guacamole-common</artifactId>
<packaging>jar</packaging>
- <version>1.1.0</version>
+ <version>1.2.0</version>
Review comment:
Has guacamole-common changed? I'm not seeing any changes from 1.1.0 according to git.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] necouchman commented on a change in pull request
#475: GUACAMOLE-966: Bump client version numbers to 1.2.0
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #475: GUACAMOLE-966: Bump client version numbers to 1.2.0
URL: https://github.com/apache/guacamole-client/pull/475#discussion_r385055320
##########
File path: guacamole-common/pom.xml
##########
@@ -26,7 +26,7 @@
<groupId>org.apache.guacamole</groupId>
<artifactId>guacamole-common</artifactId>
<packaging>jar</packaging>
- <version>1.1.0</version>
+ <version>1.2.0</version>
Review comment:
Good point - reverted that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] mike-jumper commented on issue #475:
GUACAMOLE-966: Bump client version numbers to 1.2.0
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on issue #475: GUACAMOLE-966: Bump client version numbers to 1.2.0
URL: https://github.com/apache/guacamole-client/pull/475#issuecomment-591749619
I think the guacamole-common-js API has actually changed for this release. It's not changed in an incompatible way, but I can find at least the `drawStream()` of `Guacamole.Display` as a new addition (added via commit 4e130d2afd as part of [GUACAMOLE-884](https://issues.apache.org/jira/browse/GUACAMOLE-884)).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] necouchman commented on a change in pull request
#475: GUACAMOLE-966: Bump client version numbers to 1.2.0
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #475: GUACAMOLE-966: Bump client version numbers to 1.2.0
URL: https://github.com/apache/guacamole-client/pull/475#discussion_r385055486
##########
File path: extensions/guacamole-auth-radius/pom.xml
##########
@@ -178,15 +178,15 @@
<dependency>
<groupId>org.apache.guacamole</groupId>
<artifactId>guacamole-common</artifactId>
- <version>1.1.0</version>
+ <version>1.2.0</version>
Review comment:
Removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] mike-jumper commented on a change in pull
request #475: GUACAMOLE-966: Bump client version numbers to 1.2.0
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #475: GUACAMOLE-966: Bump client version numbers to 1.2.0
URL: https://github.com/apache/guacamole-client/pull/475#discussion_r384886298
##########
File path: extensions/guacamole-auth-cas/pom.xml
##########
@@ -210,15 +210,15 @@
<dependency>
<groupId>org.apache.guacamole</groupId>
<artifactId>guacamole-common</artifactId>
- <version>1.1.0</version>
+ <version>1.2.0</version>
Review comment:
It might be easier to just remove this dependency, relying on inheriting it from guacamole-ext. Unlike projects like guacamole-example, use of guacamole-common within an extension will be to service guacamole-ext.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] mike-jumper commented on a change in pull
request #475: GUACAMOLE-966: Bump client version numbers to 1.2.0
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #475: GUACAMOLE-966: Bump client version numbers to 1.2.0
URL: https://github.com/apache/guacamole-client/pull/475#discussion_r385304507
##########
File path: doc/guacamole-example/pom.xml
##########
@@ -106,15 +106,15 @@
<dependency>
<groupId>org.apache.guacamole</groupId>
<artifactId>guacamole-common</artifactId>
- <version>1.1.0</version>
+ <version>1.2.0</version>
Review comment:
1.1.0*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] mike-jumper merged pull request #475:
GUACAMOLE-966: Bump client version numbers to 1.2.0
Posted by GitBox <gi...@apache.org>.
mike-jumper merged pull request #475: GUACAMOLE-966: Bump client version numbers to 1.2.0
URL: https://github.com/apache/guacamole-client/pull/475
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] necouchman commented on a change in pull request
#475: GUACAMOLE-966: Bump client version numbers to 1.2.0
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #475: GUACAMOLE-966: Bump client version numbers to 1.2.0
URL: https://github.com/apache/guacamole-client/pull/475#discussion_r385055417
##########
File path: extensions/guacamole-auth-cas/pom.xml
##########
@@ -210,15 +210,15 @@
<dependency>
<groupId>org.apache.guacamole</groupId>
<artifactId>guacamole-common</artifactId>
- <version>1.1.0</version>
+ <version>1.2.0</version>
Review comment:
Removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] mike-jumper commented on a change in pull
request #475: GUACAMOLE-966: Bump client version numbers to 1.2.0
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #475: GUACAMOLE-966: Bump client version numbers to 1.2.0
URL: https://github.com/apache/guacamole-client/pull/475#discussion_r384886394
##########
File path: extensions/guacamole-auth-radius/pom.xml
##########
@@ -178,15 +178,15 @@
<dependency>
<groupId>org.apache.guacamole</groupId>
<artifactId>guacamole-common</artifactId>
- <version>1.1.0</version>
+ <version>1.2.0</version>
Review comment:
Same here:
It might be easier to just remove this dependency, relying on inheriting it from guacamole-ext. Unlike projects like guacamole-example, use of guacamole-common within an extension will be to service guacamole-ext.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services