You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2024/03/02 23:53:12 UTC

[PR] [MINOR] Add PR description validation on documentation updates [hudi]

yihua opened a new pull request, #10799:
URL: https://github.com/apache/hudi/pull/10799

   ### Change Logs
   
   As above, to make PR description validation strict.
   
   ### Impact
   
   As above.
   
   ### Risk level
   
   none
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #10799:
URL: https://github.com/apache/hudi/pull/10799#discussion_r1510461098


##########
scripts/pr_compliance.py:
##########
@@ -402,7 +402,7 @@ def make_default_validator(body, debug=False):
         "### Documentation Update",
         {"_Describe any necessary documentation update if there is any new feature, config, or user-facing change_",
         "",
-        "- _The config description must be updated if new configs are added or the default value of the configs are changed_",
+        "- _The config description must be updated if new configs are added or the default value of the configs are changed. If not, put \"N/A\"._",

Review Comment:
   As long as the user provide a description, the validation of this section passes.



##########
scripts/pr_compliance.py:
##########
@@ -402,7 +402,7 @@ def make_default_validator(body, debug=False):
         "### Documentation Update",
         {"_Describe any necessary documentation update if there is any new feature, config, or user-facing change_",
         "",
-        "- _The config description must be updated if new configs are added or the default value of the configs are changed_",
+        "- _The config description must be updated if new configs are added or the default value of the configs are changed. If not, put \"N/A\"._",

Review Comment:
   As long as the user provides a description, the validation of this section passes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10799:
URL: https://github.com/apache/hudi/pull/10799#issuecomment-1974964732

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22735",
       "triggerID" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1982318df811e9dbbb0458b2219d251ceeae683a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1982318df811e9dbbb0458b2219d251ceeae683a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 25fe17b146b5a519faf87b398aeac917ecdbbad0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22735) 
   * 1982318df811e9dbbb0458b2219d251ceeae683a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10799:
URL: https://github.com/apache/hudi/pull/10799#issuecomment-1975001765

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22735",
       "triggerID" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1982318df811e9dbbb0458b2219d251ceeae683a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22737",
       "triggerID" : "1982318df811e9dbbb0458b2219d251ceeae683a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 25fe17b146b5a519faf87b398aeac917ecdbbad0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22735) 
   * 1982318df811e9dbbb0458b2219d251ceeae683a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22737) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #10799:
URL: https://github.com/apache/hudi/pull/10799#discussion_r1510455650


##########
scripts/pr_compliance.py:
##########
@@ -402,7 +402,7 @@ def make_default_validator(body, debug=False):
         "### Documentation Update",
         {"_Describe any necessary documentation update if there is any new feature, config, or user-facing change_",
         "",
-        "- _The config description must be updated if new configs are added or the default value of the configs are changed_",
+        "- _The config description must be updated if new configs are added or the default value of the configs are changed. If not, put \"N/A\"._",

Review Comment:
   Maybe put anything there, like `none` or `nothing`, or just like the other checks to give some options. What is expected for the answer, yes or no ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #10799:
URL: https://github.com/apache/hudi/pull/10799#issuecomment-1974976881

   > Hmm, most of the PRs does not need update for doc, is it reasonable to by default do all the validations? And the `[MINOR] xxx` style title seems been fixed to pass the validation right?
   
   User needs to just add `N/A` to the "Documentation Update" section in the PR description.  This is a reminder for author to check if there is any documentation update needed, not necessary to do update if the code changes are not user-facing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #10799:
URL: https://github.com/apache/hudi/pull/10799#discussion_r1510621129


##########
scripts/pr_compliance.py:
##########
@@ -402,7 +402,7 @@ def make_default_validator(body, debug=False):
         "### Documentation Update",
         {"_Describe any necessary documentation update if there is any new feature, config, or user-facing change_",
         "",
-        "- _The config description must be updated if new configs are added or the default value of the configs are changed_",
+        "- _The config description must be updated if new configs are added or the default value of the configs are changed. If not, put \"N/A\"._",

Review Comment:
   Maybe we should use `none` to keep in line with the other checks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10799:
URL: https://github.com/apache/hudi/pull/10799#issuecomment-1974965902

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22735",
       "triggerID" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1982318df811e9dbbb0458b2219d251ceeae683a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22737",
       "triggerID" : "1982318df811e9dbbb0458b2219d251ceeae683a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 25fe17b146b5a519faf87b398aeac917ecdbbad0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22735) 
   * 1982318df811e9dbbb0458b2219d251ceeae683a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22737) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10799:
URL: https://github.com/apache/hudi/pull/10799#issuecomment-1975480361

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22735",
       "triggerID" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1982318df811e9dbbb0458b2219d251ceeae683a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22737",
       "triggerID" : "1982318df811e9dbbb0458b2219d251ceeae683a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ca10086db11aafc594f9b05cf07b5e25a43da8bd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ca10086db11aafc594f9b05cf07b5e25a43da8bd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1982318df811e9dbbb0458b2219d251ceeae683a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22737) 
   * ca10086db11aafc594f9b05cf07b5e25a43da8bd UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10799:
URL: https://github.com/apache/hudi/pull/10799#issuecomment-1974950031

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22735",
       "triggerID" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 25fe17b146b5a519faf87b398aeac917ecdbbad0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22735) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #10799:
URL: https://github.com/apache/hudi/pull/10799#discussion_r1510669674


##########
scripts/pr_compliance.py:
##########
@@ -402,7 +402,7 @@ def make_default_validator(body, debug=False):
         "### Documentation Update",
         {"_Describe any necessary documentation update if there is any new feature, config, or user-facing change_",
         "",
-        "- _The config description must be updated if new configs are added or the default value of the configs are changed_",
+        "- _The config description must be updated if new configs are added or the default value of the configs are changed. If not, put \"N/A\"._",

Review Comment:
   Makes sense.  Addressed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10799:
URL: https://github.com/apache/hudi/pull/10799#issuecomment-1975486966

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22735",
       "triggerID" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1982318df811e9dbbb0458b2219d251ceeae683a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22737",
       "triggerID" : "1982318df811e9dbbb0458b2219d251ceeae683a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ca10086db11aafc594f9b05cf07b5e25a43da8bd",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22754",
       "triggerID" : "ca10086db11aafc594f9b05cf07b5e25a43da8bd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1982318df811e9dbbb0458b2219d251ceeae683a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22737) 
   * ca10086db11aafc594f9b05cf07b5e25a43da8bd Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22754) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #10799:
URL: https://github.com/apache/hudi/pull/10799#issuecomment-1975874114

   > +1, but I still think it is too strict for force update for the doc part.
   
   We can experiment with this.  This will be a good reminder for people to think about docs.  We still have features of which the docs is missing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #10799:
URL: https://github.com/apache/hudi/pull/10799


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #10799:
URL: https://github.com/apache/hudi/pull/10799#issuecomment-1975458169

   @danny0405 I updated the template to be more instructive so user knows to put "N/A" if no docs update is needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10799:
URL: https://github.com/apache/hudi/pull/10799#issuecomment-1975869423

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22735",
       "triggerID" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1982318df811e9dbbb0458b2219d251ceeae683a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22737",
       "triggerID" : "1982318df811e9dbbb0458b2219d251ceeae683a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ca10086db11aafc594f9b05cf07b5e25a43da8bd",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22754",
       "triggerID" : "ca10086db11aafc594f9b05cf07b5e25a43da8bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb664ad5c922cbd6703706e53c607f42befda76b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fb664ad5c922cbd6703706e53c607f42befda76b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ca10086db11aafc594f9b05cf07b5e25a43da8bd Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22754) 
   * fb664ad5c922cbd6703706e53c607f42befda76b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #10799:
URL: https://github.com/apache/hudi/pull/10799#issuecomment-1975875849

   "Java CI / validate-source", "Update Pr Compliance / run-tests", and "validate pr / validate-pr" pass which are suffucient for the tooling changes.  There is no change to the production code.  Merging this now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #10799:
URL: https://github.com/apache/hudi/pull/10799#issuecomment-1974966068

   Hmm, most of the PRs does not need update for doc, is it reasonable to by default do all the validations? And the `[MINOR] xxx` style title seems been fixed to pass the validation right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10799:
URL: https://github.com/apache/hudi/pull/10799#issuecomment-1975525940

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22735",
       "triggerID" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1982318df811e9dbbb0458b2219d251ceeae683a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22737",
       "triggerID" : "1982318df811e9dbbb0458b2219d251ceeae683a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ca10086db11aafc594f9b05cf07b5e25a43da8bd",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22754",
       "triggerID" : "ca10086db11aafc594f9b05cf07b5e25a43da8bd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ca10086db11aafc594f9b05cf07b5e25a43da8bd Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22754) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10799:
URL: https://github.com/apache/hudi/pull/10799#issuecomment-1974947706

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 25fe17b146b5a519faf87b398aeac917ecdbbad0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Add PR description validation on documentation updates [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10799:
URL: https://github.com/apache/hudi/pull/10799#issuecomment-1975002634

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22735",
       "triggerID" : "25fe17b146b5a519faf87b398aeac917ecdbbad0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1982318df811e9dbbb0458b2219d251ceeae683a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22737",
       "triggerID" : "1982318df811e9dbbb0458b2219d251ceeae683a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1982318df811e9dbbb0458b2219d251ceeae683a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22737) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org