You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by toxichl <gi...@git.apache.org> on 2017/04/12 13:34:14 UTC
[GitHub] incubator-weex pull request #260: Wrong a word in the documentation
GitHub user toxichl opened a pull request:
https://github.com/apache/incubator-weex/pull/260
Wrong a word in the documentation
This sentence\uff1a
> \u8fd9\u90e8\u5206\u6210\u672c\u4f1a**\u627f**\u4e0b\u964d\u548c\u6536\u655b\u7684\u8d8b\u52bf\u3002
should be changed to\uff1a
> \u8fd9\u90e8\u5206\u6210\u672c\u4f1a**\u5448**\u4e0b\u964d\u548c\u6536\u655b\u7684\u8d8b\u52bf\u3002
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toxichl/incubator-weex patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/260.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #260
----
commit 8d6954cc4f67b83f325f7d6904734e91115c809f
Author: Toxichl <47...@qq.com>
Date: 2017-04-12T13:31:58Z
Wrong a word
This sentence\uff1a
> \u8fd9\u90e8\u5206\u6210\u672c\u4f1a**\u627f**\u4e0b\u964d\u548c\u6536\u655b\u7684\u8d8b\u52bf\u3002
should be changed to\uff1a
> \u8fd9\u90e8\u5206\u6210\u672c\u4f1a**\u5448**\u4e0b\u964d\u548c\u6536\u655b\u7684\u8d8b\u52bf\u3002
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #260: Wrong a word in the documentation
Posted by toxichl <gi...@git.apache.org>.
Github user toxichl commented on the issue:
https://github.com/apache/incubator-weex/pull/260
Why still can not pass, I just modified a word\uff1f
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #260: Wrong a word in the documentation
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/260
@toxichl sorry the CI is broken, I'll fix that soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #260: Wrong a word in the documentation
Posted by Hanks10100 <gi...@git.apache.org>.
Github user Hanks10100 commented on the issue:
https://github.com/apache/incubator-weex/pull/260
The CI is broken and the PR have no response for a long time. I'll close it shortly. If there still need further discussions about it, you could open a new pull request.
Thanks for your cooperation.
---
[GitHub] incubator-weex issue #260: Wrong a word in the documentation
Posted by gurisxie <gi...@git.apache.org>.
Github user gurisxie commented on the issue:
https://github.com/apache/incubator-weex/pull/260
@ulivz I'm sorry for that I can't found what a repository need been pulled.Can you close this pr [here](https://github.com/apache/incubator-weex/pull/260). If you have new change for weex,hope your new pull request.Thanks a lot!
---
[GitHub] incubator-weex pull request #260: Wrong a word in the documentation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/260
---
[GitHub] incubator-weex issue #260: Wrong a word in the documentation
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/260
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Error">
2 Errors
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:no_entry_sign:</td>
<td data-sticky="false"><strong>WXRootViewTests</strong>: testInstanceAndWeexRootFrame, ((WXRectApproximateToRect(view.subviews[0].frame, CGRectMake(0,0,WXPixelScale(100, pixelScaleFactor),WXPixelScale(200, pixelScaleFactor)))) is true) failed <br /> <a href="https://github.com/toxichl/incubator-weex/blob/8d6954cc4f67b83f325f7d6904734e91115c809f/ios/sdk/WeexSDKTests/WXRootViewTests.m#L124">ios/sdk/WeexSDKTests/WXRootViewTests.m#L124</a></td>
</tr>
<tr>
<td>:no_entry_sign:</td>
<td data-sticky="false"><strong>WXStorageTests</strong>: testSetItem, ((ABS(tsNow - ts) <= 0.1) is true) failed <br /> <a href="https://github.com/toxichl/incubator-weex/blob/8d6954cc4f67b83f325f7d6904734e91115c809f/ios/sdk/WeexSDKTests/WXStorageTests.m#L132">ios/sdk/WeexSDKTests/WXStorageTests.m#L132</a></td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Message">
1 Message
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:book:</td>
<td data-sticky="false">Executed 53 tests, with 2 failures (0 unexpected) in 103.817 (103.930) seconds</td>
</tr>
</tbody>
</table>
<p align="right" data-meta="generated_by_danger">
Generated by :no_entry_sign: <a href="http://danger.systems/">danger</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---