[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #590: MINIFICPP-621 Nanofi Tailfile example

[GitBox <gi...@apache.org>]

phrocker commented on a change in pull request #590: MINIFICPP-621 Nanofi Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r293757377
 
 

 ##########
 File path: nanofi/src/core/string_utils.c
 ##########
 @@ -0,0 +1,87 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "core/cstructs.h"
+#include "core/string_utils.h"
+#include <string.h>
+#include <stdlib.h>
+
+tokens * tokenize_string(char * str, const char * delimiter) {
+    if (!str || !delimiter) return NULL;
+
+    char delim = delimiter[0];
+    if (delim == '\\') {
+          if (strlen(delimiter) > 1) {
+            switch (delimiter[1]) {
+              case 'r':
+                delim = '\r';
+                break;
+              case 't':
+                delim = '\t';
+                break;
+              case 'n':
+                delim = '\n';
+                break;
+              case '\\':
+                delim = '\\';
+                break;
+              default:
+                break;
+            }
+        }
+    }
+
+    char * begin = str;
+    char * end = NULL;
+    int num_strings = 0;
+    while ((end = strchr(begin, delim))) {
+        if (begin == end) {
+            begin++;
+            continue;
+        }
+        begin = (end+1);
+        num_strings++;
+    }
+
+    struct tokens * tks = (struct tokens *)malloc(sizeof(tokens));
+    tks->str_list = malloc(sizeof(char *) * (num_strings));
+    tks->num_strings = 0;
+    tks->total_bytes = 0;
+
+    for (int i = 0; i < num_strings; ++i) {
+        tks->str_list[i] = NULL;
+    }
+
+    begin = str;
+    end = NULL;
+    while ((end = strchr(begin, delim))) {
+        if (begin == end) {
+            begin++;
+            tks->total_bytes++;
+            continue;
+        }
+        int len = end - begin;
 
 Review comment:
   sorry @msharee9 I haven't been able to take a look as others have -- but it seems like they're offering good comments. I skimmed the review quickly and this caught my eye due to strndup.
   
   I don't believe strndup is commonly implemented. A project that I've worked on previously ( https://github.com/rougier/freetype-gl/blob/master/platform.c ) has this file for this specific reason. I've seen similar implementations across other projects so may be a nice string util if and only if you feel this a worthwhile change. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services