You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/11/22 03:52:10 UTC
[GitHub] [cordova-ios] erisu opened a new pull request #1203: refactor!: do not copy JS lib to platform project
erisu opened a new pull request #1203:
URL: https://github.com/apache/cordova-ios/pull/1203
### Motivation and Context
The goal of this PR is to remove the pratice of copying the entire JS lib of `cordova-ios` into each generated platform project.
### Description
- create: do not copy our JS lib (or `node_modules`) to platform project
- Move files around
- `bin/lib/create.js` to `lib/`
- `bin/templates/scripts/cordova/lib` to `lib/`
- `bin/templates/scripts/cordova/Api.js` to `lib/`
After these changes, the `cordova/` folder of a generated project only contains the bare minimum to maintain compatibility with existing cordova CLI versions (plus `defaults.xml` which IMHO should be moved in another PR). All of the remaining JS files in that folder require their dependencies via the `cordova-ios` module, so that needs to be resolvable somehow (which is the case for a platform project generated by the regular CLI workflow).
### Testing
- existing tests pass
- I successfully created and built a cordova-ios project using cordova@10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-commenter edited a comment on pull request #1203: refactor!: do not copy JS lib to platform project
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1203:
URL: https://github.com/apache/cordova-ios/pull/1203#issuecomment-975101193
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1203](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9099962) into [master](https://codecov.io/gh/apache/cordova-ios/commit/457bfa014fe51ff8da99676c313d9f0b7a69801d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (457bfa0) will **increase** coverage by `3.44%`.
> The diff coverage is `71.98%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1203 +/- ##
==========================================
+ Coverage 75.09% 78.53% +3.44%
==========================================
Files 13 15 +2
Lines 1658 1761 +103
==========================================
+ Hits 1245 1383 +138
+ Misses 413 378 -35
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [lib/BridgingHeader.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL0JyaWRnaW5nSGVhZGVyLmpz) | `95.45% <ø> (ø)` | |
| [lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL1BvZGZpbGUuanM=) | `75.12% <ø> (ø)` | |
| [lib/PodsJson.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL1BvZHNKc29uLmpz) | `95.04% <ø> (ø)` | |
| [lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2J1aWxkLmpz) | `66.04% <ø> (ø)` | |
| [lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2NoZWNrX3JlcXMuanM=) | `47.05% <ø> (ø)` | |
| [lib/listDevices.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2xpc3REZXZpY2VzLmpz) | `100.00% <ø> (ø)` | |
| [lib/listEmulatorBuildTargets.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2xpc3RFbXVsYXRvckJ1aWxkVGFyZ2V0cy5qcw==) | `96.77% <ø> (ø)` | |
| [lib/listEmulatorImages.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2xpc3RFbXVsYXRvckltYWdlcy5qcw==) | `100.00% <ø> (ø)` | |
| [lib/plugman/pluginHandlers.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL3BsdWdtYW4vcGx1Z2luSGFuZGxlcnMuanM=) | `90.05% <ø> (ø)` | |
| [lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL3ByZXBhcmUuanM=) | `85.00% <ø> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [457bfa0...9099962](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] raphinesse commented on a change in pull request #1203: refactor!: do not copy JS lib to platform project
Posted by GitBox <gi...@apache.org>.
raphinesse commented on a change in pull request #1203:
URL: https://github.com/apache/cordova-ios/pull/1203#discussion_r757784445
##########
File path: tests/spec/create.spec.js
##########
@@ -64,6 +64,13 @@ function verifyProjectBundleIdentifier (tmpDir, projectName, expectedBundleIdent
* @returns {Promise}
*/
function verifyBuild (tmpDir) {
+ // Allow test project to find the `cordova-android` module
Review comment:
```suggestion
// Allow test project to find the `cordova-ios` module
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-commenter commented on pull request #1203: refactor!: do not copy JS lib to platform project
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1203:
URL: https://github.com/apache/cordova-ios/pull/1203#issuecomment-975101193
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1203](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9099962) into [master](https://codecov.io/gh/apache/cordova-ios/commit/457bfa014fe51ff8da99676c313d9f0b7a69801d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (457bfa0) will **increase** coverage by `3.44%`.
> The diff coverage is `71.98%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1203 +/- ##
==========================================
+ Coverage 75.09% 78.53% +3.44%
==========================================
Files 13 15 +2
Lines 1658 1761 +103
==========================================
+ Hits 1245 1383 +138
+ Misses 413 378 -35
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [lib/BridgingHeader.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL0JyaWRnaW5nSGVhZGVyLmpz) | `95.45% <ø> (ø)` | |
| [lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL1BvZGZpbGUuanM=) | `75.12% <ø> (ø)` | |
| [lib/PodsJson.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL1BvZHNKc29uLmpz) | `95.04% <ø> (ø)` | |
| [lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2J1aWxkLmpz) | `66.04% <ø> (ø)` | |
| [lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2NoZWNrX3JlcXMuanM=) | `47.05% <ø> (ø)` | |
| [lib/listDevices.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2xpc3REZXZpY2VzLmpz) | `100.00% <ø> (ø)` | |
| [lib/listEmulatorBuildTargets.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2xpc3RFbXVsYXRvckJ1aWxkVGFyZ2V0cy5qcw==) | `96.77% <ø> (ø)` | |
| [lib/listEmulatorImages.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2xpc3RFbXVsYXRvckltYWdlcy5qcw==) | `100.00% <ø> (ø)` | |
| [lib/plugman/pluginHandlers.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL3BsdWdtYW4vcGx1Z2luSGFuZGxlcnMuanM=) | `90.05% <ø> (ø)` | |
| [lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL3ByZXBhcmUuanM=) | `85.00% <ø> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [457bfa0...9099962](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] erisu merged pull request #1203: refactor!: do not copy JS lib to platform project
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1203:
URL: https://github.com/apache/cordova-ios/pull/1203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-commenter edited a comment on pull request #1203: refactor!: do not copy JS lib to platform project
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1203:
URL: https://github.com/apache/cordova-ios/pull/1203#issuecomment-975101193
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1203](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2b1b031) into [master](https://codecov.io/gh/apache/cordova-ios/commit/457bfa014fe51ff8da99676c313d9f0b7a69801d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (457bfa0) will **increase** coverage by `3.44%`.
> The diff coverage is `71.98%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1203 +/- ##
==========================================
+ Coverage 75.09% 78.53% +3.44%
==========================================
Files 13 15 +2
Lines 1658 1761 +103
==========================================
+ Hits 1245 1383 +138
+ Misses 413 378 -35
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [lib/BridgingHeader.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL0JyaWRnaW5nSGVhZGVyLmpz) | `95.45% <ø> (ø)` | |
| [lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL1BvZGZpbGUuanM=) | `75.12% <ø> (ø)` | |
| [lib/PodsJson.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL1BvZHNKc29uLmpz) | `95.04% <ø> (ø)` | |
| [lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2J1aWxkLmpz) | `66.04% <ø> (ø)` | |
| [lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2NoZWNrX3JlcXMuanM=) | `47.05% <ø> (ø)` | |
| [lib/listDevices.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2xpc3REZXZpY2VzLmpz) | `100.00% <ø> (ø)` | |
| [lib/listEmulatorBuildTargets.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2xpc3RFbXVsYXRvckJ1aWxkVGFyZ2V0cy5qcw==) | `96.77% <ø> (ø)` | |
| [lib/listEmulatorImages.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2xpc3RFbXVsYXRvckltYWdlcy5qcw==) | `100.00% <ø> (ø)` | |
| [lib/plugman/pluginHandlers.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL3BsdWdtYW4vcGx1Z2luSGFuZGxlcnMuanM=) | `90.05% <ø> (ø)` | |
| [lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL3ByZXBhcmUuanM=) | `85.00% <ø> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/cordova-ios/pull/1203/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [457bfa0...2b1b031](https://codecov.io/gh/apache/cordova-ios/pull/1203?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org