You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "mrproliu (via GitHub)" <gi...@apache.org> on 2023/04/21 03:51:46 UTC
[GitHub] [skywalking-go] mrproliu opened a new pull request, #9: Add the plugin API
mrproliu opened a new pull request, #9:
URL: https://github.com/apache/skywalking-go/pull/9
1. Add the plugin develop API
2. Add the gin framework support as a plugin demo
3. Support `-debug /path/to/skywalking-go` option for agent enhance the program, helping the user debug the plugin and agent code(using `line` directive from the Golang compiler)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-go] jcchavezs commented on a diff in pull request #9: Add the plugin API
Posted by "jcchavezs (via GitHub)" <gi...@apache.org>.
jcchavezs commented on code in PR #9:
URL: https://github.com/apache/skywalking-go/pull/9#discussion_r1175779307
##########
plugins/ginv2/go.mod:
##########
@@ -0,0 +1,39 @@
+module github.com/apache/skywalking-go/plugins/ginv2
+
+go 1.18
+
+require (
+ github.com/apache/skywalking-go/plugins/core v0.0.0-20230414024435-7b292984eb80
+ github.com/gin-gonic/gin v1.9.0
+)
+
+require (
+ github.com/bytedance/sonic v1.8.0 // indirect
+ github.com/chenzhuoyu/base64x v0.0.0-20221115062448-fe3a3abad311 // indirect
+ github.com/dave/dst v0.27.2 // indirect
+ github.com/gin-contrib/sse v0.1.0 // indirect
+ github.com/go-playground/locales v0.14.1 // indirect
+ github.com/go-playground/universal-translator v0.18.1 // indirect
+ github.com/go-playground/validator/v10 v10.11.2 // indirect
+ github.com/goccy/go-json v0.10.0 // indirect
+ github.com/json-iterator/go v1.1.12 // indirect
+ github.com/klauspost/cpuid/v2 v2.0.9 // indirect
+ github.com/leodido/go-urn v1.2.1 // indirect
+ github.com/mattn/go-isatty v0.0.17 // indirect
+ github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421 // indirect
+ github.com/modern-go/reflect2 v1.0.2 // indirect
+ github.com/pelletier/go-toml/v2 v2.0.6 // indirect
+ github.com/twitchyliquid64/golang-asm v0.15.1 // indirect
+ github.com/ugorji/go/codec v1.2.9 // indirect
+ golang.org/x/arch v0.0.0-20210923205945-b76863e36670 // indirect
+ golang.org/x/crypto v0.5.0 // indirect
+ golang.org/x/net v0.8.0 // indirect
+ golang.org/x/sys v0.6.0 // indirect
+ golang.org/x/text v0.8.0 // indirect
+ google.golang.org/protobuf v1.29.0 // indirect
+ gopkg.in/yaml.v3 v3.0.1 // indirect
+)
+
+replace github.com/apache/skywalking-go/plugins/core => ../core
Review Comment:
In a next PR you can use go workspaces as it us supported since 1.18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-go] wu-sheng merged pull request #9: Add the plugin API
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #9:
URL: https://github.com/apache/skywalking-go/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org