You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/16 11:00:23 UTC

[GitHub] [incubator-doris] starocean999 commented on a diff in pull request #10183: [fix](executor) intersect operator takes too long time to execute

starocean999 commented on code in PR #10183:
URL: https://github.com/apache/incubator-doris/pull/10183#discussion_r898962194


##########
be/src/vec/exec/vset_operation_node.h:
##########
@@ -114,23 +114,36 @@ void VSetOperationNode::refresh_hash_table() {
 
                     arg.init_once();
                     auto& iter = arg.iter;
-                    for (; iter != arg.hash_table.end(); ++iter) {
+                    auto iter_end = arg.hash_table.end();
+                    decltype(arg.iter) iter_prev;
+                    for (; iter != iter_end;) {

Review Comment:
   Done



##########
be/src/vec/exec/vset_operation_node.h:
##########
@@ -114,23 +114,36 @@ void VSetOperationNode::refresh_hash_table() {
 
                     arg.init_once();
                     auto& iter = arg.iter;
-                    for (; iter != arg.hash_table.end(); ++iter) {
+                    auto iter_end = arg.hash_table.end();
+                    decltype(arg.iter) iter_prev;

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org