You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ne...@apache.org on 2010/03/10 23:00:38 UTC
svn commit: r921588 - in /subversion/trunk/subversion: include/svn_wc.h
libsvn_wc/adm_files.h libsvn_wc/adm_ops.c
Author: neels
Date: Wed Mar 10 22:00:38 2010
New Revision: 921588
URL: http://svn.apache.org/viewvc?rev=921588&view=rev
Log:
Strike the first blow at making svn_wc_[_]get_pristine_contents[2]() use wc-ng.
The previous implementation of svn_wc_get_pristine_contents2() assumed a
text-base file to always be present and never reflected a NULL return value to
the callers, other than advertised. This patch fixes that return value.
See also r921556, which prepared for this patch.
(Still TODO for 1.7: svn_wc_get_pristine_contents2() and
svn_wc__get_pristine_contents() should use the pristine store.)
* subversion/include/svn_wc.h
(svn_wc_get_pristine_contents2): Comment.
Properly define this function so that we know what to implement when the
pristine store rolls out.
* subversion/libsvn_wc/adm_files.h
(svn_wc__get_pristine_contents): Comment, point to svn_wc_get_pristine_contents2().
* subversion/libsvn_wc/adm_ops.c
(svn_wc_get_pristine_contents2, svn_wc__get_pristine_contents):
Properly detect a node that has no pristine base using wc-db API. Return
NULL as advertised (previously failed with an error complaining about a
non-existing text-base file). Add assertion to make sure we covered all
cases.
Modified:
subversion/trunk/subversion/include/svn_wc.h
subversion/trunk/subversion/libsvn_wc/adm_files.h
subversion/trunk/subversion/libsvn_wc/adm_ops.c
Modified: subversion/trunk/subversion/include/svn_wc.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_wc.h?rev=921588&r1=921587&r2=921588&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_wc.h (original)
+++ subversion/trunk/subversion/include/svn_wc.h Wed Mar 10 22:00:38 2010
@@ -6424,10 +6424,24 @@ svn_wc_merge_prop_diffs(svn_wc_notify_st
apr_pool_t *pool);
-/** Given a @a path to a wc file, return a stream to the @a contents of
- * the pristine copy of the file. Use @a wc_ctx to access the working
- * copy.This is needed so clients can do diffs. If the WC has no
- * text-base, return a @c NULL instead of a stream.
+/** Given a @a path to a wc file, return in @a *contents a readonly stream to
+ * the pristine contents of the file that would serve as base content for the
+ * next commit. That means:
+ *
+ * When there is no change in node history scheduled, i.e. when there are only
+ * local text-mods, prop-mods or a delete, return the last checked-out or
+ * updated-/switched-to contents of the file.
+ *
+ * If the file is simply added or replaced (no copy-/move-here involved),
+ * set @a *contents to @c NULL.
+ *
+ * When the file has been locally copied-/moved-here, return the contents of
+ * the copy/move source (even if the copy-/move-here replaces a locally
+ * deleted file).
+ *
+ * If @local_abspath refers to an unversioned or non-existing path, return
+ * @c SVN_ERR_WC_PATH_NOT_FOUND. Use @a wc_ctx to access the working copy.
+ * @a contents may not be @c NULL (unlike @a *contents).
*
* @since New in 1.7. */
svn_error_t *
Modified: subversion/trunk/subversion/libsvn_wc/adm_files.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/adm_files.h?rev=921588&r1=921587&r2=921588&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_wc/adm_files.h (original)
+++ subversion/trunk/subversion/libsvn_wc/adm_files.h Wed Mar 10 22:00:38 2010
@@ -68,7 +68,9 @@ svn_wc__text_base_path(const char **resu
svn_boolean_t tmp,
apr_pool_t *pool);
-/* Set *CONTENTS to a readonly stream on the LOCAL_ABSPATH's base file. */
+/* Set *CONTENTS to a readonly stream on the LOCAL_ABSPATH's base file.
+ * For more detail, please see the description of
+ * svn_wc_get_pristine_contents2().*/
svn_error_t *
svn_wc__get_pristine_contents(svn_stream_t **contents,
svn_wc__db_t *db,
Modified: subversion/trunk/subversion/libsvn_wc/adm_ops.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/adm_ops.c?rev=921588&r1=921587&r2=921588&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_wc/adm_ops.c (original)
+++ subversion/trunk/subversion/libsvn_wc/adm_ops.c Wed Mar 10 22:00:38 2010
@@ -2208,17 +2208,39 @@ svn_wc__get_pristine_contents(svn_stream
apr_pool_t *result_pool,
apr_pool_t *scratch_pool)
{
+ svn_wc__db_status_t status;
const char *text_base;
- SVN_ERR(svn_wc__text_base_path(&text_base, db, local_abspath, FALSE,
- scratch_pool));
-
- if (text_base == NULL)
+ SVN_ERR(svn_wc__db_read_info(&status,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ db, local_abspath, scratch_pool, scratch_pool));
+ if (status == svn_wc__db_status_added)
{
- *contents = NULL;
- return SVN_NO_ERROR;
+ /* For an added node, we return an empty stream. Make sure this is not
+ * copied-here or moved-here, in which case we return the copy/move
+ * source's contents. */
+ SVN_ERR(svn_wc__db_scan_addition(&status,
+ NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL,
+ db, local_abspath,
+ scratch_pool, scratch_pool));
+ if (status == svn_wc__db_status_added)
+ {
+ /* Simply added. The pristine base does not exist. */
+ *contents = NULL;
+ return SVN_NO_ERROR;
+ }
}
+ /* ### TODO: use pristine store. */
+ /* ### TODO: check for non-file node. */
+
+ SVN_ERR(svn_wc__text_base_path(&text_base, db, local_abspath, FALSE,
+ scratch_pool));
+ SVN_ERR_ASSERT(text_base != NULL);
+
return svn_stream_open_readonly(contents, text_base, result_pool,
scratch_pool);
}
Re: svn commit: r921588 - in /subversion/trunk/subversion: include/svn_wc.h
libsvn_wc/adm_files.h libsvn_wc/adm_ops.c
Posted by Neels J Hofmeyr <ne...@elego.de>.
Greg Stein wrote:
> On Wed, Mar 10, 2010 at 17:00, <ne...@apache.org> wrote:
>> ...
>> +++ subversion/trunk/subversion/libsvn_wc/adm_ops.c Wed Mar 10 22:00:38 2010
>> @@ -2208,17 +2208,39 @@ svn_wc__get_pristine_contents(svn_stream
>> apr_pool_t *result_pool,
>> apr_pool_t *scratch_pool)
>> {
>> + svn_wc__db_status_t status;
>> const char *text_base;
>>
>> - SVN_ERR(svn_wc__text_base_path(&text_base, db, local_abspath, FALSE,
>> - scratch_pool));
>> -
>> - if (text_base == NULL)
>> + SVN_ERR(svn_wc__db_read_info(&status,
>> + NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
>> + NULL, NULL, NULL, NULL, NULL, NULL, NULL,
>> + db, local_abspath, scratch_pool, scratch_pool));
>
> You can read the KIND at the same time here, and early-out for non-files.
>
>> + if (status == svn_wc__db_status_added)
>
> You should also check for obstructed_add. This could be a local copy
> of a file, and the user rm'd the file and put a directory there. You
> still want access to the underlying pristine.
r921848, but since now bailing on non-files, obstructed_add should not
happen -- thus just added an ASSERT for that.
~Neels
Re: svn commit: r921588 - in /subversion/trunk/subversion:
include/svn_wc.h libsvn_wc/adm_files.h libsvn_wc/adm_ops.c
Posted by Greg Stein <gs...@gmail.com>.
On Wed, Mar 10, 2010 at 17:00, <ne...@apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_wc/adm_ops.c Wed Mar 10 22:00:38 2010
> @@ -2208,17 +2208,39 @@ svn_wc__get_pristine_contents(svn_stream
> apr_pool_t *result_pool,
> apr_pool_t *scratch_pool)
> {
> + svn_wc__db_status_t status;
> const char *text_base;
>
> - SVN_ERR(svn_wc__text_base_path(&text_base, db, local_abspath, FALSE,
> - scratch_pool));
> -
> - if (text_base == NULL)
> + SVN_ERR(svn_wc__db_read_info(&status,
> + NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> + db, local_abspath, scratch_pool, scratch_pool));
You can read the KIND at the same time here, and early-out for non-files.
> + if (status == svn_wc__db_status_added)
You should also check for obstructed_add. This could be a local copy
of a file, and the user rm'd the file and put a directory there. You
still want access to the underlying pristine.
>...
Cheers,
-g
Re: mails mails
Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/3/12 Johan Corveleyn <jc...@gmail.com>:
> One annoyance with gmail: how do you view emails in fixed-width font?
> I haven't been able to find a good solution for this (making it hard
> to read mails with ascii tables like gstein's recent count-progress.py
> mail.
>
"Show original" and "Message text garbled?" in the message menu in GMail
both show it in fixed-width font.
When replying, it is possible to switch to "Rich formatting" and change
the font there.
That is what comes to mind. I didn't know about those labs features.
Best regards,
Konstantin Kolinko
Re: mails mails
Posted by Greg Stein <gs...@gmail.com>.
On Fri, Mar 12, 2010 at 04:04, Johan Corveleyn <jc...@gmail.com> wrote:
> On Fri, Mar 12, 2010 at 4:14 AM, neels <ne...@gmail.com> wrote:
>> On 12 March 2010 03:57, Greg Stein <gs...@gmail.com> wrote:
>>> On Thu, Mar 11, 2010 at 21:26, Neels J Hofmeyr <ne...@elego.de> wrote:
>>>> Mark Phippard wrote:
>>>>> Same here. Using GMail I didn't even know this was a problem.
>>>>
>>>> Hm, I guess it would be ok to use gmail for svn dev mails :)
>>>> (I don't like to be part of a Big-Corp-Takes-Over-Everything scheme.)
>>>
>>> I'd be very surprised if you could successfully argue your mail is
>>> safer at your local ISP or at elego, than residing at Gmail.
>>>
>>> Cheers,
>>> -g
>>>
>>
>> Not really, but to me it feels eerie to have one massive place
>> "everyone" trusts instead of variety. Maybe its just my german history
>> education, but my point makes an awful lot of sense to me.
>>
>> ~Neeels
>>
>
> One annoyance with gmail: how do you view emails in fixed-width font?
> I haven't been able to find a good solution for this (making it hard
> to read mails with ascii tables like gstein's recent count-progress.py
> mail.
That's why I switched to an HTML email for that message, and put that
block into Courier :-)
> Of course you can view in fixed-width font when reading them with a
> regular mail client, but through the gmail web interface? How do you
> guys cope with that?
It is rare that messages come through which *require* fixed-width. I
don't see tabular stuff that often. The commit emails are in
variable-width, but that tends to be okay. Most stuff doesn't need to
line up.
> There used to be a labs feature that put a "view in fixed-width font"
> in the drop-down menu on mails, but it has recently disappeared ...
Yah... prolly not enough people used it to justify keeping it around.
Worst case, I'll cut/paste into my Aquamacs editor and look at the
email contents there. But I can't even remember the last time that
happened.
Cheers,
-g
Re: mails mails
Posted by Johan Corveleyn <jc...@gmail.com>.
On Fri, Mar 12, 2010 at 4:14 AM, neels <ne...@gmail.com> wrote:
> On 12 March 2010 03:57, Greg Stein <gs...@gmail.com> wrote:
>> On Thu, Mar 11, 2010 at 21:26, Neels J Hofmeyr <ne...@elego.de> wrote:
>>> Mark Phippard wrote:
>>>> Same here. Using GMail I didn't even know this was a problem.
>>>
>>> Hm, I guess it would be ok to use gmail for svn dev mails :)
>>> (I don't like to be part of a Big-Corp-Takes-Over-Everything scheme.)
>>
>> I'd be very surprised if you could successfully argue your mail is
>> safer at your local ISP or at elego, than residing at Gmail.
>>
>> Cheers,
>> -g
>>
>
> Not really, but to me it feels eerie to have one massive place
> "everyone" trusts instead of variety. Maybe its just my german history
> education, but my point makes an awful lot of sense to me.
>
> ~Neeels
>
One annoyance with gmail: how do you view emails in fixed-width font?
I haven't been able to find a good solution for this (making it hard
to read mails with ascii tables like gstein's recent count-progress.py
mail.
Of course you can view in fixed-width font when reading them with a
regular mail client, but through the gmail web interface? How do you
guys cope with that?
There used to be a labs feature that put a "view in fixed-width font"
in the drop-down menu on mails, but it has recently disappeared ...
Johan
Re: mails mails
Posted by neels <ne...@gmail.com>.
On 12 March 2010 03:57, Greg Stein <gs...@gmail.com> wrote:
> On Thu, Mar 11, 2010 at 21:26, Neels J Hofmeyr <ne...@elego.de> wrote:
>> Mark Phippard wrote:
>>> Same here. Using GMail I didn't even know this was a problem.
>>
>> Hm, I guess it would be ok to use gmail for svn dev mails :)
>> (I don't like to be part of a Big-Corp-Takes-Over-Everything scheme.)
>
> I'd be very surprised if you could successfully argue your mail is
> safer at your local ISP or at elego, than residing at Gmail.
>
> Cheers,
> -g
>
Not really, but to me it feels eerie to have one massive place
"everyone" trusts instead of variety. Maybe its just my german history
education, but my point makes an awful lot of sense to me.
~Neeels
Re: mails mails
Posted by Greg Stein <gs...@gmail.com>.
On Thu, Mar 11, 2010 at 21:26, Neels J Hofmeyr <ne...@elego.de> wrote:
> Mark Phippard wrote:
>> Same here. Using GMail I didn't even know this was a problem.
>
> Hm, I guess it would be ok to use gmail for svn dev mails :)
> (I don't like to be part of a Big-Corp-Takes-Over-Everything scheme.)
I'd be very surprised if you could successfully argue your mail is
safer at your local ISP or at elego, than residing at Gmail.
Cheers,
-g
Re: mails mails
Posted by Blair Zajac <bl...@orcaware.com>.
On 03/11/2010 06:26 PM, Neels J Hofmeyr wrote:
> Mark Phippard wrote:
>> Same here. Using GMail I didn't even know this was a problem.
>
> Hm, I guess it would be ok to use gmail for svn dev mails :)
> (I don't like to be part of a Big-Corp-Takes-Over-Everything scheme.)
>
> ~Neels
>
While we're bagging on email, I've noticed another trend lately is that
people reply-all to a commit message and the entire commit is duplicated
and there's a one-line comment at the bottom. In Thunderbird I need to
scroll down a long ways. It's wasteful of space and time, so it would
be nice if people took more effort in trimming their replies.
Blair
Re: mails mails
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
neels wrote on Sat, 13 Mar 2010 at 23:28 +0100:
> The drastically uneven male:female ratio in the Subversion project has
> actually worried me recently. My understanding of the nature of FLOSS
> would suggest a more or less even distribution, so I ask myself, why
> the heck are *all* of us svn devs male?
s/svn devs/community members/
(even on users@ I don't see many female first names)
Re: mails mails
Posted by neels <ne...@gmail.com>.
I'd like to note, more verbosely, that I got carried away with that
post -- I was trying to demonstrate how all beauty disappears with a
var width font. I do not want to be associated with sexism nor trying
to irritate anyone. When I posted I simply wasn't aware enough that a
picture like this could offend, in either direction (to me,
personally, it is quite low on the irritation scale). I value the
attitude neutrality on this list and apologize for disturbance
thereof.
On 13 March 2010 09:29, Stefan Sperling <st...@elego.de> wrote:
> When I sent the above I should have been more explicit
> about my intent by linking to http://webchick.net/files/women-in-floss.pdf
> I'd like to encourage everyone to please read these slides.
+1 for this presentation (BTW, it is a talk opposing gender
discrimination, for anyone who might be reluctant to click).
The drastically uneven male:female ratio in the Subversion project has
actually worried me recently. My understanding of the nature of FLOSS
would suggest a more or less even distribution, so I ask myself, why
the heck are *all* of us svn devs male? I hereby officially welcome
any individual out there to join in and receive
attitude/gender/situation-neutral support like anyone else.
~Neels
Re: mails mails
Posted by Stefan Sperling <st...@elego.de>.
On Fri, Mar 12, 2010 at 06:14:35PM +0100, Stefan Sperling wrote:
> On Fri, Mar 12, 2010 at 05:56:42PM +0100, neels wrote:
> > [[[
<snip>
> > ]]]
>
> I just see a log message.
> You forgot to attach the patch?
When I sent the above I should have been more explicit
about my intent by linking to http://webchick.net/files/women-in-floss.pdf
I'd like to encourage everyone to please read these slides.
Stefan
Re: mails mails
Posted by Stefan Sperling <st...@elego.de>.
On Fri, Mar 12, 2010 at 05:56:42PM +0100, neels wrote:
> [[[
> ?.$$$$$" `L ;;;;;;;, .`.`.`.`$;??h,_ `h
> ?$$$$$ ""' `;;;;;;;;, `.`.`.`.hJ" `"??cc, $
> ?"???"??" j' :;;;;;;;;;;, .`.`.`.`$ $
> ;;, $ :;;;;;;;;;;;, `.`.`.`.$c,,__ $
> i;;, h `':;;;;;;;;;, `.`.`.`h `" ?c
> `$;;;;, $r `:;;;;;;;;, .`.`.`.$
> J$i;;h $; `:;;;;;;;, `.`.`.`$""=,
> .$$$$h;, ,C; .j???c, `;t;;;;, `.`.`.?c
> $$$$$$h;, $;, J;;;;i;L. :?);;, .`.`.?h,_
> $$$$$$$; j'; $;;;$h9;L `:?);;, ,C?h.
> ?$$$$$$; $;, `$;?ii$;;h `;L;;, (C;;?h
> 3$$$$?; J?;, `h;;;;;;P :;L;, `$;;$?L
> .$$$$;;' ,C;;, `?CjjF `;3;, $;;?h$
> $$$$;;: $;;;, `;3; `h;;;F
> $$$?;; `.JF;;;, ;3; `hiF J"
> $$?;' .`.`.c$h;;;;, ;;f;, ,;iF z" z
> C;; .`.`JCCC$;;;;; ;;$;;;; `;i;, ;;J" J' J'
> ;; .`.` JF;;??$hi;;;;. .;;$;;;;;, ;?$;;;, ,;;i$ J'.P
> ' `.`. ,C;;;;, `"h;;;;;;;;;;;;;;;i$?;;;;;;;, :;?h;;;;;;;;9"?. j','
> .`.` .$;;;;' "??iijjjjii?""`.`;;;;;;;, `;;?h;;;;iP $,'.P
> `.`. ,C;;;, `;;;;, `;;;J""' `h $
> .`. ,C;;;;' ;;, ;;;9 $$
> `.` ,C;;;;f `;;, `;;J r `L
> .` z$;;;;, `;, ;;9 $ h
> j"`h;;;' `;, ;;$ `r 3
> j' ,c;;, ;, ;;$ $ `h
> .P <$;;, `;, .;;$. ?. $
> ]]]
I just see a log message.
You forgot to attach the patch?
Re: mails mails
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On Sun, Mar 14, 2010 at 12:57 AM, Hyrum K. Wright
<hy...@mail.utexas.edu> wrote:
> You can actually configure it to be Reply-All by default. I forget if it's a labs feature or something else, but that's one of the first things I did when I started using Gmail a couple of months ago.
I do the same. I also used the Labs feature to show emails in
fixed-width fonts too, but they yanked that last month from Labs.
Bummer.
(Yah, yah, OT, but...*grin*) -- justin
Re: mails mails
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
On Mar 13, 2010, at 5:12 PM, Greg Stein wrote:
> On Fri, Mar 12, 2010 at 11:56, neels <ne...@gmail.com> wrote
>
>> 3) with a "Reply all" button at the top right instead of just "Reply"
>
> It would be nice to have a Reply-All immediately there, but it is just
> one click away. I hit the drop-down, then hit Reply-All very
> frequently. Two clicks is not bad.
You can actually configure it to be Reply-All by default. I forget if it's a labs feature or something else, but that's one of the first things I did when I started using Gmail a couple of months ago.
-Hyrum
Re: mails mails
Posted by Greg Stein <gs...@gmail.com>.
On Fri, Mar 12, 2010 at 11:56, neels <ne...@gmail.com> wrote:
> ...I must say gmail has a *very* decent interface for mailing. Now if
> someone could write this
>
> 1) as a client program instead of a blooming website
Use IMAP and your favorite client. It is just that I have not seen
such a nice client. I'm also "always" online, so I don't worry about
the fact that the app is a website. I can always connect.
There *is* an offline mode for Gmail, if you really want offline.
> 2) with the ability to *SHOW FIXED WIDTH FONT* for crying out loud
I've been using Gmail as my primary for 4-5 years now, and I *rarely*
need to see something in fixed-width. RARELY. I just don't see this as
a problem. For the time here and there where it is needed, I just
cut/paste into Emacs.
> 3) with a "Reply all" button at the top right instead of just "Reply"
It would be nice to have a Reply-All immediately there, but it is just
one click away. I hit the drop-down, then hit Reply-All very
frequently. Two clicks is not bad.
Cheers,
-g
Re: mails mails
Posted by neels <ne...@gmail.com>.
...I must say gmail has a *very* decent interface for mailing. Now if
someone could write this
1) as a client program instead of a blooming website
2) with the ability to *SHOW FIXED WIDTH FONT* for crying out loud
3) with a "Reply all" button at the top right instead of just "Reply"
then that would indeed be my favourite mail client.
[[[
?.$$$$$" `L ;;;;;;;, .`.`.`.`$;??h,_ `h
?$$$$$ ""' `;;;;;;;;, `.`.`.`.hJ" `"??cc, $
?"???"??" j' :;;;;;;;;;;, .`.`.`.`$ $
;;, $ :;;;;;;;;;;;, `.`.`.`.$c,,__ $
i;;, h `':;;;;;;;;;, `.`.`.`h `" ?c
`$;;;;, $r `:;;;;;;;;, .`.`.`.$
J$i;;h $; `:;;;;;;;, `.`.`.`$""=,
.$$$$h;, ,C; .j???c, `;t;;;;, `.`.`.?c
$$$$$$h;, $;, J;;;;i;L. :?);;, .`.`.?h,_
$$$$$$$; j'; $;;;$h9;L `:?);;, ,C?h.
?$$$$$$; $;, `$;?ii$;;h `;L;;, (C;;?h
3$$$$?; J?;, `h;;;;;;P :;L;, `$;;$?L
.$$$$;;' ,C;;, `?CjjF `;3;, $;;?h$
$$$$;;: $;;;, `;3; `h;;;F
$$$?;; `.JF;;;, ;3; `hiF J"
$$?;' .`.`.c$h;;;;, ;;f;, ,;iF z" z
C;; .`.`JCCC$;;;;; ;;$;;;; `;i;, ;;J" J' J'
;; .`.` JF;;??$hi;;;;. .;;$;;;;;, ;?$;;;, ,;;i$ J'.P
' `.`. ,C;;;;, `"h;;;;;;;;;;;;;;;i$?;;;;;;;, :;?h;;;;;;;;9"?. j','
.`.` .$;;;;' "??iijjjjii?""`.`;;;;;;;, `;;?h;;;;iP $,'.P
`.`. ,C;;;, `;;;;, `;;;J""' `h $
.`. ,C;;;;' ;;, ;;;9 $$
`.` ,C;;;;f `;;, `;;J r `L
.` z$;;;;, `;, ;;9 $ h
j"`h;;;' `;, ;;$ `r 3
j' ,c;;, ;, ;;$ $ `h
.P <$;;, `;, .;;$. ?. $
]]]
I rest my case.
~Neels
On 12 March 2010 13:32, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> Neels J Hofmeyr wrote on Fri, 12 Mar 2010 at 03:26 +0100:
>> Mark Phippard wrote:
>> > Same here. Using GMail I didn't even know this was a problem.
>>
>> Hm, I guess it would be ok to use gmail for svn dev mails :)
>
> There are other mail providers (and some email clients) that filter
> duplicates automatically.
>
>> (I don't like to be part of a Big-Corp-Takes-Over-Everything scheme.)
>>
>
> +1
>
Re: mails mails
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Neels J Hofmeyr wrote on Fri, 12 Mar 2010 at 03:26 +0100:
> Mark Phippard wrote:
> > Same here. Using GMail I didn't even know this was a problem.
>
> Hm, I guess it would be ok to use gmail for svn dev mails :)
There are other mail providers (and some email clients) that filter
duplicates automatically.
> (I don't like to be part of a Big-Corp-Takes-Over-Everything scheme.)
>
+1
Re: mails mails
Posted by Neels J Hofmeyr <ne...@elego.de>.
Mark Phippard wrote:
> Same here. Using GMail I didn't even know this was a problem.
Hm, I guess it would be ok to use gmail for svn dev mails :)
(I don't like to be part of a Big-Corp-Takes-Over-Everything scheme.)
~Neels
Re: mails mails
Posted by Mark Phippard <ma...@gmail.com>.
Same here. Using GMail I didn't even know this was a problem.
On Mar 11, 2010, at 8:37 PM, Greg Stein <gs...@gmail.com> wrote:
> I don't see duplicates in Gmail, even when it nominally arrives from
> multiple directions.
>
> On Thu, Mar 11, 2010 at 20:29, Neels J Hofmeyr <ne...@elego.de> wrote:
>> Julian Foad wrote:
>>> Hoorrah!
>>
>> heh, I got a triple "Hoorrah" in my inbox (one each via dev@,
>> neels@ and
>> commits@, I guess)
>>
>> Sometimes I wish the mail duplication would end ... but most of the
>> time I
>> accept them as given. I have a 'remove duplicates' thing, but it
>> requires
>> clicking twice to kick it off per folder. :/
>>
>> I haven't seen the perfect mail client yet. Suggestions welcome.
>>
>> ~Neels
>>
>>
Re: mails mails
Posted by Greg Stein <gs...@gmail.com>.
I don't see duplicates in Gmail, even when it nominally arrives from
multiple directions.
On Thu, Mar 11, 2010 at 20:29, Neels J Hofmeyr <ne...@elego.de> wrote:
> Julian Foad wrote:
>> Hoorrah!
>
> heh, I got a triple "Hoorrah" in my inbox (one each via dev@, neels@ and
> commits@, I guess)
>
> Sometimes I wish the mail duplication would end ... but most of the time I
> accept them as given. I have a 'remove duplicates' thing, but it requires
> clicking twice to kick it off per folder. :/
>
> I haven't seen the perfect mail client yet. Suggestions welcome.
>
> ~Neels
>
>
mails mails
Posted by Neels J Hofmeyr <ne...@elego.de>.
Julian Foad wrote:
> Hoorrah!
heh, I got a triple "Hoorrah" in my inbox (one each via dev@, neels@ and
commits@, I guess)
Sometimes I wish the mail duplication would end ... but most of the time I
accept them as given. I have a 'remove duplicates' thing, but it requires
clicking twice to kick it off per folder. :/
I haven't seen the perfect mail client yet. Suggestions welcome.
~Neels
Re: svn commit: r921588 - in /subversion/trunk/subversion:
include/svn_wc.h libsvn_wc/adm_files.h libsvn_wc/adm_ops.c
Posted by Julian Foad <ju...@wandisco.com>.
On Wed, 2010-03-10, neels@apache.org wrote:
> Author: neels
> Date: Wed Mar 10 22:00:38 2010
> New Revision: 921588
>
> URL: http://svn.apache.org/viewvc?rev=921588&view=rev
> Log:
> Strike the first blow at making svn_wc_[_]get_pristine_contents[2]() use wc-ng.
>
> The previous implementation of svn_wc_get_pristine_contents2() assumed a
> text-base file to always be present and never reflected a NULL return value to
> the callers, other than advertised. This patch fixes that return value.
>
> See also r921556, which prepared for this patch.
>
> (Still TODO for 1.7: svn_wc_get_pristine_contents2() and
> svn_wc__get_pristine_contents() should use the pristine store.)
>
> * subversion/include/svn_wc.h
> (svn_wc_get_pristine_contents2): Comment.
> Properly define this function so that we know what to implement when the
> pristine store rolls out.
Hoorrah! Thanks, Neels. /me gives big smiley.
[...]
(Not reviewed in detail.)
- Julian
Re: svn commit: r921588 - in /subversion/trunk/subversion:
include/svn_wc.h libsvn_wc/adm_files.h libsvn_wc/adm_ops.c
Posted by Julian Foad <ju...@wandisco.com>.
On Wed, 2010-03-10, neels@apache.org wrote:
> Author: neels
> Date: Wed Mar 10 22:00:38 2010
> New Revision: 921588
>
> URL: http://svn.apache.org/viewvc?rev=921588&view=rev
> Log:
> Strike the first blow at making svn_wc_[_]get_pristine_contents[2]() use wc-ng.
>
> The previous implementation of svn_wc_get_pristine_contents2() assumed a
> text-base file to always be present and never reflected a NULL return value to
> the callers, other than advertised. This patch fixes that return value.
>
> See also r921556, which prepared for this patch.
>
> (Still TODO for 1.7: svn_wc_get_pristine_contents2() and
> svn_wc__get_pristine_contents() should use the pristine store.)
>
> * subversion/include/svn_wc.h
> (svn_wc_get_pristine_contents2): Comment.
> Properly define this function so that we know what to implement when the
> pristine store rolls out.
Hoorrah! Thanks, Neels. /me gives big smiley.
[...]
(Not reviewed in detail.)
- Julian