[jira] [Commented] (KAFKA-4429) records-lag should be zero if FetchResponse is empty

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685240#comment-15685240 ] 

ASF GitHub Bot commented on KAFKA-4429:
---------------------------------------

GitHub user lindong28 opened a pull request:

    https://github.com/apache/kafka/pull/2155

    KAFKA-4429; records-lag should be zero if FetchResponse is empty

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lindong28/kafka KAFKA-4429

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2155
    
----
commit 0dbcf2c1357861606e5e7bcf5ee59d29bb1641f3
Author: Dong Lin <li...@gmail.com>
Date:   2016-11-22T00:38:20Z

    KAFKA-4429; records-lag should be zero if FetchResponse is empty

----


> records-lag should be zero if FetchResponse is empty
> ----------------------------------------------------
>
>                 Key: KAFKA-4429
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4429
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Dong Lin
>            Assignee: Dong Lin
>
> In Fetcher we record records-lag in terms of number of records for any partition. Currently this metric value is updated only if number of parsed records is not empty. This means that if consumer has already fully caught up and there is no new data into the topic, this metric's value will be negative infinity and users can not rely on this metric to know if their consumer has caught up.
> We can fix this problem by assuming the lag is zero is FetchResponse is empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)