[GitHub] [eventmesh] Alonexc commented on a diff in pull request #3840: [ISSUE #3826]'assertTrue()' can be simplified to 'assertEquals()'

["Alonexc (via GitHub)" <gi...@apache.org>]

Alonexc commented on code in PR #3840:
URL: https://github.com/apache/eventmesh/pull/3840#discussion_r1180006680


##########
eventmesh-storage-plugin/eventmesh-storage-standalone/src/test/java/org/apache/eventmesh/storage/standalone/broker/MessageQueueTest.java:
##########
@@ -103,12 +103,12 @@ public void testGetSize() {
     public void testGetTakeIndex() throws InterruptedException {
         MessageEntity takeIndexMessageEntity = messageQueue.take();
         Assert.assertNotNull(takeIndexMessageEntity);
-        Assert.assertTrue(messageQueue.getTakeIndex() == 1);
+        Assert.assertEquals(messageQueue.getTakeIndex() == 1);

Review Comment:
   Assert.assertEquals(1, messageQueue.getTakeIndex());



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org