[whimsy] branch master updated: TODOs and doc fix

[se...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 20fc1ea  TODOs and doc fix
20fc1ea is described below

commit 20fc1ea007ef2c3d6df48ef369c78ca023d24542
Author: Sebb <se...@apache.org>
AuthorDate: Sat Feb 9 16:05:17 2019 +0000

    TODOs and doc fix
---
 lib/whimsy/asf/ldap.rb | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
index 8b73ccf..c4dc6c8 100644
--- a/lib/whimsy/asf/ldap.rb
+++ b/lib/whimsy/asf/ldap.rb
@@ -775,13 +775,17 @@ module ASF
     end
 
     # list of LDAP committees that this individual is a member of
+    # TODO should this be deleted? 
+    # It seems to be used partly as LDAP membership and partly as PMC membership (which were originally generally the same)
+    # If the former, then it disappears.
+    # If the latter, then it needs to be derived from project_owners filtered to keep only PMCs
     def committees
       # legacy LDAP entries
       committees = weakref(:committees) do
         Committee.list("member=uid=#{name},#{base}")
       end
 
-      # add in projects (currently only includes GUINEAPIGS)
+      # add in projects
       # Get list of project names where the person is an owner
       projects = self.projects.select{|prj| prj.owners.include? self}.map(&:name)
       committees += ASF::Committee.pmcs.select do |pmc| 
@@ -800,7 +804,6 @@ module ASF
     end
 
     # list of LDAP projects that this individual is an owner of - i.e. on (P)PMC
-    # not all PMC currently have project groups
     def project_owners
       weakref(:project_owners) do
         Project.list("owner=uid=#{name},#{base}")