You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/01/18 23:44:26 UTC
[GitHub] [solr] janhoy opened a new pull request #540: Add the new minor version (e.g. 9.1) also to main branch
janhoy opened a new pull request #540:
URL: https://github.com/apache/solr/pull/540
Just discovered that the releaseWizard, after branching `branch_9_0`, adds version 9.1 to `branch_9x` (including CHANGES.txt), but it does not add v 9.1 to main branch. This is wrong, as there should be a 9.1 changes section also on main branch now.
I added it manually and committed. But this is the change I believe is ncessary to the wizard to automate this in the future. I find it strage that this has not been discovered before, so I'm starting to question whether I am overlooking something obvious here? Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #540: Add the new minor version (e.g. 9.1) also to main branch
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #540:
URL: https://github.com/apache/solr/pull/540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on a change in pull request #540: Add the new minor version (e.g. 9.1) also to main branch
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #540:
URL: https://github.com/apache/solr/pull/540#discussion_r788009222
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -456,6 +456,16 @@ groups:
comment: Make sure the edits done by `addVersion.py` are ok, then push
cmd: git add -u . && git commit -m "Add next minor version {{ next_version }}" && git push
logfile: commit-stable.log
+ - !Command
+ cmd: git checkout main
+ tee: true
+ - !Command
Review comment:
```suggestion
- !Command
cmd: git pull --ff-only
tee: true
- !Command
```
Maybe add a pull before committing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #540: Add the new minor version (e.g. 9.1) also to main branch
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #540:
URL: https://github.com/apache/solr/pull/540#issuecomment-1016782154
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #540: Add the new minor version (e.g. 9.1) also to main branch
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #540:
URL: https://github.com/apache/solr/pull/540#issuecomment-1015952557
So glad you saw this! I had a CHANGES.txt entry that was messed up because of this reason that I suspect you found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org