[GitHub] [airflow] mik-laj commented on a change in pull request #5398: [AIRFLOW-4659] Fix pylint problems for api module

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #5398: [AIRFLOW-4659] Fix pylint problems for api module
URL: https://github.com/apache/airflow/pull/5398#discussion_r291894597
 
 

 ##########
 File path: airflow/api/common/experimental/trigger_dag.py
 ##########
 @@ -16,31 +16,45 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
+"""Triggering DAG runs APIs."""
 import json
+from datetime import datetime
+from typing import Union, Optional, List
 
 from airflow.exceptions import DagRunAlreadyExists, DagNotFound
 from airflow.models import DagRun, DagBag, DagModel
 from airflow.utils import timezone
 from airflow.utils.state import State
 
 
+# pylint: disable=too-many-arguments
 def _trigger_dag(
-        dag_id,
-        dag_bag,
-        dag_run,
-        run_id,
-        conf,
-        execution_date,
-        replace_microseconds,
-):
+        dag_id: str,
+        dag_bag: DagBag,
+        dag_run: DagModel,
+        run_id: Optional[str],
+        conf: Optional[Union[dict, str]],
+        execution_date: Optional[datetime],
+        replace_microseconds: bool,
+) -> List[DagRun]:
+    """
+        Triggers DAG run.
 
 Review comment:
   Unexpected indent

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services