You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/06/26 03:30:34 UTC

[GitHub] [incubator-yunikorn-k8shim] wilfred-s opened a new pull request #144: [YUNIKORN-258] fix make lint to really run

wilfred-s opened a new pull request #144:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/144


   The make target for lint in the shim only works if there are uncommitted
   changes. In all other cases the check will pass. That means the PR
   pre-commit check in travis will never fail.
   Fix the lint target to perform the same check as the core


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #144: [YUNIKORN-258] fix make lint to really run

Posted by GitBox <gi...@apache.org>.

wilfred-s closed pull request #144:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/144


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org