[GitHub] [dolphinscheduler] yimaixinchen commented on a change in pull request #8304: [Cherry-pick-dev]Compatible historical version connection information

[GitBox <gi...@apache.org>]

yimaixinchen commented on a change in pull request #8304:
URL: https://github.com/apache/dolphinscheduler/pull/8304#discussion_r810449955



##########
File path: dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/provider/JDBCDataSourceProvider.java
##########
@@ -99,12 +99,11 @@ protected static void loaderJdbcDriver(ClassLoader classLoader, BaseConnectionPa
                 logger.warn("Jdbc driver loading error. Driver {} cannot accept url.", drv);
                 throw new RuntimeException("Jdbc driver loading error.");
             }
-            if (dbType.equals(DbType.MYSQL)) {
-                if (driver.getMajorVersion() >= 8) {
-                    properties.setDriverClassName(drv);
-                } else {
-                    properties.setDriverClassName(Constants.COM_MYSQL_JDBC_DRIVER);
-                }
+            //Compatible historical version data source connection information
+            if (dbType.equals(DbType.MYSQL) && driver.getMajorVersion() <= 8) {
+                properties.setDriverClassName(Constants.COM_MYSQL_JDBC_DRIVER);

Review comment:
       is this <8 not <=8?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org