You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/01 17:17:11 UTC

[GitHub] [arrow-rs] comphead opened a new issue, #2995: arrow::compute::kernels::temporal should support milliseconds

comphead opened a new issue, #2995:
URL: https://github.com/apache/arrow-rs/issues/2995

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for this feature, in addition to  the *what*)
   -->
   `arrow::compute::kernels::temporal` should support milliseconds in similar way it supports seconds
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   Add functions to extracts the milliseconds of a given temporal array as an array of integers
   
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features you've considered.
   -->
   None
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   None


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] comphead commented on issue #2995: arrow::compute::kernels::temporal should support milliseconds

Posted by GitBox <gi...@apache.org>.
comphead commented on issue #2995:
URL: https://github.com/apache/arrow-rs/issues/2995#issuecomment-1298857387

   Please assign this ticket to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] waitingkuo commented on issue #2995: arrow::compute::kernels::temporal should support milliseconds

Posted by GitBox <gi...@apache.org>.
waitingkuo commented on issue #2995:
URL: https://github.com/apache/arrow-rs/issues/2995#issuecomment-1299132283

   @comphead expose nanosecond sounds great


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold closed issue #2995: arrow::compute::kernels::temporal should support nanoseconds

Posted by GitBox <gi...@apache.org>.
tustvold closed issue #2995: arrow::compute::kernels::temporal should support nanoseconds
URL: https://github.com/apache/arrow-rs/issues/2995


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] waitingkuo commented on issue #2995: arrow::compute::kernels::temporal should support milliseconds

Posted by GitBox <gi...@apache.org>.
waitingkuo commented on issue #2995:
URL: https://github.com/apache/arrow-rs/issues/2995#issuecomment-1298883178

   @comphead thank you
   do you plan to do millisecond only or microsecond/nanosecond as well in this pr?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] alamb commented on issue #2995: arrow::compute::kernels::temporal should support nanoseconds

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #2995:
URL: https://github.com/apache/arrow-rs/issues/2995#issuecomment-1312141185

   `label_issue.py` automatically added labels {'arrow'} from #2996


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] waitingkuo commented on issue #2995: arrow::compute::kernels::temporal should support milliseconds

Posted by GitBox <gi...@apache.org>.
waitingkuo commented on issue #2995:
URL: https://github.com/apache/arrow-rs/issues/2995#issuecomment-1299013479

   @comphead 
   extracting second in postgresql contains microseconds
   ```bash
   willy=# select date_part('second', now());
    date_part 
   -----------
    21.070954
   (1 row)
   ```
   since the resolution for it's timestamp is microsecond
   https://www.postgresql.org/docs/7.3/datatype-datetime.html
   
   In datafusion, our default Timestamp's resolution is  nanoseconds, so I think we might need that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] comphead commented on issue #2995: arrow::compute::kernels::temporal should support milliseconds

Posted by GitBox <gi...@apache.org>.
comphead commented on issue #2995:
URL: https://github.com/apache/arrow-rs/issues/2995#issuecomment-1298914361

   @waitingkuo for now we need milliseconds. but if the PR is relatively small, we can include micro/nano as well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] comphead commented on issue #2995: arrow::compute::kernels::temporal should support milliseconds

Posted by GitBox <gi...@apache.org>.
comphead commented on issue #2995:
URL: https://github.com/apache/arrow-rs/issues/2995#issuecomment-1299112832

   @waitingkuo I'm wondering would be that better to expose nanoseconds instead? Having that we can always convert nano to less precision data like millis, micros?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org