You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/02/08 07:16:13 UTC
[kudu-CR] [security] clean-up on cert management-test.cc
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5937
Change subject: [security] clean-up on cert_management-test.cc
......................................................................
[security] clean-up on cert_management-test.cc
A minor clean-up on cert-related tests: moved other than
X509 CSR-related tests from cert_management-test.cc into cert-test.cc.
Also, removed duplicated key-specific tests from cert_management.cc:
they are in crypto-test.cc now (probably, the duplication was the result
of merge conflicts resolution).
There are no functional changes in this patch.
Change-Id: I3e42d8545e783fbc657de9bf2d4d231265cf3f3f
---
M src/kudu/security/ca/cert_management-test.cc
M src/kudu/security/cert-test.cc
2 files changed, 22 insertions(+), 62 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/5937/1
--
To view, visit http://gerrit.cloudera.org:8080/5937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e42d8545e783fbc657de9bf2d4d231265cf3f3f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [security] clean-up on cert management-test.cc
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [security] clean-up on cert_management-test.cc
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e42d8545e783fbc657de9bf2d4d231265cf3f3f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [security] clean-up on cert management-test.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [security] clean-up on cert_management-test.cc
......................................................................
[security] clean-up on cert_management-test.cc
A minor clean-up on cert-related tests: moved other than
X509 CSR-related tests from cert_management-test.cc into cert-test.cc.
Also, removed duplicated key-specific tests from cert_management.cc:
they are in crypto-test.cc now (probably, the duplication was the result
of merge conflicts resolution).
There are no functional changes in this patch.
Change-Id: I3e42d8545e783fbc657de9bf2d4d231265cf3f3f
Reviewed-on: http://gerrit.cloudera.org:8080/5937
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/security/ca/cert_management-test.cc
M src/kudu/security/cert-test.cc
2 files changed, 22 insertions(+), 62 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e42d8545e783fbc657de9bf2d4d231265cf3f3f
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [security] clean-up on cert management-test.cc
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [security] clean-up on cert_management-test.cc
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e42d8545e783fbc657de9bf2d4d231265cf3f3f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [security] clean-up on cert management-test.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [security] clean-up on cert_management-test.cc
......................................................................
Patch Set 3: Code-Review+2
Progated Dan's +2 to this re-based revision.
--
To view, visit http://gerrit.cloudera.org:8080/5937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e42d8545e783fbc657de9bf2d4d231265cf3f3f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No