You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/07/09 22:05:10 UTC
[GitHub] [arrow] kou opened a new pull request, #36581: GH-36479: [C++][FlightRPC] Use gRPC version detected by find_package()
kou opened a new pull request, #36581:
URL: https://github.com/apache/arrow/pull/36581
### Rationale for this change
We don't need to use `try_compile()` by using gRPC version detected by `find_package()`.
### What changes are included in this PR?
Use gRPC version detected by `find_package()`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #36581: GH-36479: [C++][FlightRPC] Use gRPC version detected by find_package()
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #36581:
URL: https://github.com/apache/arrow/pull/36581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36581: GH-36479: [C++][FlightRPC] Use gRPC version detected by find_package()
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36581:
URL: https://github.com/apache/arrow/pull/36581#issuecomment-1627839299
Revision: 7a33aae217456369652a7551fb36ec076948d1cf
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f185f0e942](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f185f0e942)
|Task|Status|
|----|------|
|almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/tree/actions-f185f0e942-github-almalinux-8-amd64)|
|almalinux-8-arm64|[](https://github.com/ursacomputing/crossbow/tree/actions-f185f0e942-github-almalinux-8-arm64)|
|almalinux-9-amd64|[](https://github.com/ursacomputing/crossbow/tree/actions-f185f0e942-github-almalinux-9-amd64)|
|almalinux-9-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502162838/jobs/10026242186)|
|amazon-linux-2023-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502166362/jobs/10026248104)|
|amazon-linux-2023-arm64|[](https://github.com/ursacomputing/crossbow/tree/actions-f185f0e942-github-amazon-linux-2023-arm64)|
|centos-7-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502165048/jobs/10026245502)|
|centos-8-stream-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502176607/jobs/10026264371)|
|centos-8-stream-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502168302/jobs/10026250903)|
|centos-9-stream-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502163772/jobs/10026243696)|
|centos-9-stream-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502171160/jobs/10026255565)|
|conan-maximum|[](https://github.com/ursacomputing/crossbow/actions/runs/5502175097/jobs/10026261713)|
|conan-minimum|[](https://github.com/ursacomputing/crossbow/actions/runs/5502181895/jobs/10026272611)|
|conda-clean|[](https://github.com/ursacomputing/crossbow/runs/14894576430)|
|conda-linux-aarch64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/14894585908)|
|conda-linux-aarch64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/14894581596)|
|conda-linux-ppc64le-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/14894589113)|
|conda-linux-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/14894579075)|
|conda-linux-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/14894580142)|
|conda-linux-x64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/14894587957)|
|conda-osx-arm64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/14894577513)|
|conda-osx-arm64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/14894588928)|
|conda-osx-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/14894556635)|
|conda-osx-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/14894582839)|
|conda-win-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/14894589544)|
|conda-win-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/14894568198)|
|conda-win-x64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/14894564264)|
|debian-bookworm-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502167408/jobs/10026249586)|
|debian-bookworm-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502162633/jobs/10026241788)|
|debian-bullseye-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502173548/jobs/10026259528)|
|debian-bullseye-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502169696/jobs/10026253347)|
|debian-trixie-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502176398/jobs/10026263918)|
|debian-trixie-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502167823/jobs/10026250136)|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/5502173102/jobs/10026258665)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/5502173651/jobs/10026259668)|
|example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/5502168733/jobs/10026251465)|
|example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/5502180828/jobs/10026271062)|
|homebrew-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5502182761/jobs/10026274192)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/5502173345/jobs/10026259302)|
|homebrew-r-brew|[](https://github.com/ursacomputing/crossbow/actions/runs/5502182855/jobs/10026274397)|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/5502179663/jobs/10026269347)|
|nuget|[](https://github.com/ursacomputing/crossbow/actions/runs/5502180990/jobs/10026271286)|
|python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/5502179250/jobs/10026268385)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/5502177328/jobs/10026270352)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5502169428/jobs/10026252839)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/5502184524/jobs/10026277000)|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions/runs/5502171770/jobs/10026256389)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5502163032/jobs/10026242599)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/14894593221)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/5502169593/jobs/10026253133)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/5502169029/jobs/10026252001)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/5502166475/jobs/10026248344)|
|test-conda-python-3.10-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/5502166439/jobs/10026248253)|
|test-conda-python-3.10-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/5502180335/jobs/10026270407)|
|test-conda-python-3.10-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/5502178574/jobs/10026267382)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/5502162186/jobs/10026240880)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/5502182359/jobs/10026273318)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/5502175439/jobs/10026262247)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/5502167193/jobs/10026249332)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/5502185594/jobs/10026278523)|
|test-conda-python-3.11-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/5502175252/jobs/10026261951)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/5502162387/jobs/10026241255)|
|test-conda-python-3.8-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/5502162706/jobs/10026241941)|
|test-conda-python-3.8-spark-v3.1.2|[](https://github.com/ursacomputing/crossbow/actions/runs/5502172544/jobs/10026257535)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/5502165505/jobs/10026246279)|
|test-conda-python-3.9-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/5502174509/jobs/10026260839)|
|test-conda-python-3.9-spark-v3.2.0|[](https://github.com/ursacomputing/crossbow/actions/runs/5502183497/jobs/10026275522)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5502174142/jobs/10026260323)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/5502173449/jobs/10026259339)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502172721/jobs/10026257858)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/5502170442/jobs/10026254608)|
|test-debian-11-go-1.17|[](https://github.com/ursacomputing/crossbow/runs/14894579822)|
|test-debian-11-go-1.20|[](https://github.com/ursacomputing/crossbow/runs/14894582896)|
|test-debian-11-python-3|[](https://github.com/ursacomputing/crossbow/runs/14894585320)|
|test-debian-c-glib|[](https://github.com/ursacomputing/crossbow/actions/runs/5502162778/jobs/10026242055)|
|test-debian-ruby|[](https://github.com/ursacomputing/crossbow/actions/runs/5502170119/jobs/10026254096)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5502176232/jobs/10026263516)|
|test-fedora-35-python-3|[](https://github.com/ursacomputing/crossbow/runs/14894568076)|
|test-fedora-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/14894569035)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/5502167967/jobs/10026250380)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/14894590847)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/5502175596/jobs/10026262510)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/5502164611/jobs/10026244776)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/5502165191/jobs/10026245863)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/5502182490/jobs/10026273536)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/5502176321/jobs/10026263764)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/5502178087/jobs/10026266710)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/5502179496/jobs/10026268984)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/14894575211)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/5502165376/jobs/10026246321)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/5502169147/jobs/10026252220)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/runs/14894575811)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/14894583703)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/5502179530/jobs/10026269032)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/14894554124)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/14894574993)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/14894567009)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://github.com/ursacomputing/crossbow/runs/14894585645)|
|test-r-rstudio-r-base-4.1-opensuse153|[](https://github.com/ursacomputing/crossbow/runs/14894562508)|
|test-r-rstudio-r-base-4.2-centos7-devtoolset-8|[](https://github.com/ursacomputing/crossbow/runs/14894577799)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/14894556756)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/5502175905/jobs/10026262892)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/5502170979/jobs/10026255518)|
|test-skyhook-integration|[](https://github.com/ursacomputing/crossbow/actions/runs/5502169195/jobs/10026252334)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5502177565/jobs/10026265838)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/5502184168/jobs/10026276438)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/5502184870/jobs/10026277530)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/5502182819/jobs/10026274302)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/14894549655)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5502167016/jobs/10026249084)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/5502183355/jobs/10026275277)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/5502162578/jobs/10026241698)|
|test-ubuntu-c-glib|[](https://github.com/ursacomputing/crossbow/actions/runs/5502185699/jobs/10026278743)|
|test-ubuntu-default-docs|[](https://github.com/ursacomputing/crossbow/runs/14894576825)|
|test-ubuntu-r-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/14894581847)|
|test-ubuntu-ruby|[](https://github.com/ursacomputing/crossbow/actions/runs/5502175743/jobs/10026262662)|
|ubuntu-focal-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502162473/jobs/10026241441)|
|ubuntu-focal-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502179402/jobs/10026268718)|
|ubuntu-jammy-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502182600/jobs/10026273829)|
|ubuntu-jammy-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502185250/jobs/10026278026)|
|ubuntu-lunar-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502162421/jobs/10026241348)|
|ubuntu-lunar-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502163584/jobs/10026243415)|
|verify-rc-source-cpp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502170621/jobs/10026254804)|
|verify-rc-source-cpp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502182142/jobs/10026272937)|
|verify-rc-source-cpp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502170776/jobs/10026255038)|
|verify-rc-source-cpp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502163956/jobs/10026243895)|
|verify-rc-source-cpp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502176147/jobs/10026263363)|
|verify-rc-source-cpp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502183596/jobs/10026275620)|
|verify-rc-source-cpp-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502178893/jobs/10026267811)|
|verify-rc-source-csharp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502162958/jobs/10026242448)|
|verify-rc-source-csharp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502173031/jobs/10026258569)|
|verify-rc-source-csharp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502176822/jobs/10026264736)|
|verify-rc-source-csharp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502169654/jobs/10026253252)|
|verify-rc-source-csharp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502163114/jobs/10026242740)|
|verify-rc-source-csharp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502183183/jobs/10026274960)|
|verify-rc-source-go-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502165831/jobs/10026247017)|
|verify-rc-source-go-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502182240/jobs/10026273122)|
|verify-rc-source-go-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502168547/jobs/10026251183)|
|verify-rc-source-go-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502182979/jobs/10026274618)|
|verify-rc-source-go-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502173999/jobs/10026260165)|
|verify-rc-source-go-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502172840/jobs/10026258150)|
|verify-rc-source-integration-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502166564/jobs/10026248452)|
|verify-rc-source-integration-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502166834/jobs/10026248827)|
|verify-rc-source-integration-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502165637/jobs/10026246496)|
|verify-rc-source-integration-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502168882/jobs/10026251780)|
|verify-rc-source-integration-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502176564/jobs/10026264263)|
|verify-rc-source-integration-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502184673/jobs/10026277236)|
|verify-rc-source-integration-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502169905/jobs/10026253757)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502169389/jobs/10026252730)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502166311/jobs/10026248020)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502181678/jobs/10026272234)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502177191/jobs/10026265398)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502164388/jobs/10026244440)|
|verify-rc-source-js-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502167589/jobs/10026249862)|
|verify-rc-source-js-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502176458/jobs/10026264042)|
|verify-rc-source-js-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502168147/jobs/10026250635)|
|verify-rc-source-js-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502165786/jobs/10026246896)|
|verify-rc-source-js-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502178729/jobs/10026267584)|
|verify-rc-source-js-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502184318/jobs/10026276694)|
|verify-rc-source-python-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502176512/jobs/10026264170)|
|verify-rc-source-python-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502177884/jobs/10026266326)|
|verify-rc-source-python-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502165939/jobs/10026247280)|
|verify-rc-source-python-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502185084/jobs/10026277793)|
|verify-rc-source-python-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502172668/jobs/10026257718)|
|verify-rc-source-python-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502179083/jobs/10026268079)|
|verify-rc-source-python-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502173787/jobs/10026259853)|
|verify-rc-source-ruby-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502165705/jobs/10026246662)|
|verify-rc-source-ruby-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502162114/jobs/10026240780)|
|verify-rc-source-ruby-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502169261/jobs/10026252466)|
|verify-rc-source-ruby-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502169825/jobs/10026253612)|
|verify-rc-source-ruby-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502162885/jobs/10026242307)|
|verify-rc-source-ruby-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502162285/jobs/10026241061)|
|verify-rc-source-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/5502165881/jobs/10026247140)|
|wheel-clean|[](https://github.com/ursacomputing/crossbow/actions/runs/5502172882/jobs/10026258281)|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502181978/jobs/10026272720)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502172442/jobs/10026257351)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502179608/jobs/10026269183)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502173286/jobs/10026259044)|
|wheel-macos-mojave-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502182914/jobs/10026274519)|
|wheel-macos-mojave-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502182555/jobs/10026273713)|
|wheel-macos-mojave-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502174691/jobs/10026261125)|
|wheel-macos-mojave-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502166661/jobs/10026248612)|
|wheel-manylinux-2-28-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502173140/jobs/10026258770)|
|wheel-manylinux-2-28-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502172945/jobs/10026258409)|
|wheel-manylinux-2-28-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502171980/jobs/10026256661)|
|wheel-manylinux-2-28-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502163207/jobs/10026242888)|
|wheel-manylinux-2-28-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502169453/jobs/10026252889)|
|wheel-manylinux-2-28-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502179950/jobs/10026269807)|
|wheel-manylinux-2-28-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502166001/jobs/10026247368)|
|wheel-manylinux-2-28-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502180474/jobs/10026270602)|
|wheel-manylinux-2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502179750/jobs/10026269442)|
|wheel-manylinux-2014-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502166246/jobs/10026247887)|
|wheel-manylinux-2014-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502180092/jobs/10026270062)|
|wheel-manylinux-2014-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502176758/jobs/10026264621)|
|wheel-manylinux-2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502166198/jobs/10026247821)|
|wheel-manylinux-2014-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502163339/jobs/10026243068)|
|wheel-manylinux-2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502179157/jobs/10026268231)|
|wheel-manylinux-2014-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502183733/jobs/10026275841)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502182710/jobs/10026274083)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502169750/jobs/10026253464)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502171370/jobs/10026255866)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5502174894/jobs/10026261417)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36581: GH-36479: [C++][FlightRPC] Use gRPC version detected by find_package()
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36581:
URL: https://github.com/apache/arrow/pull/36581#issuecomment-1646184710
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2a2c253c57b4299a98ee3c7ad84b1d9479e39b8b.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/15246452485) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36581: GH-36479: [C++][FlightRPC] Use gRPC version detected by find_package()
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36581:
URL: https://github.com/apache/arrow/pull/36581#issuecomment-1627837399
@github-actions crossbow submit -g nightly-tests -g nightly-packaging -g nightly-release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #36581: GH-36479: [C++][FlightRPC] Use gRPC version detected by find_package()
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #36581:
URL: https://github.com/apache/arrow/pull/36581#discussion_r1257657341
##########
cpp/cmake_modules/FindgRPCAlt.cmake:
##########
@@ -45,6 +47,7 @@ if(GRPCPP_PC_FOUND)
HINTS ${GRPCPP_PC_STATIC_LIBRARY_DIRS})
list(APPEND GRPCPP_LINK_LIBRARIES "${GRPCPP_LIBRARY_${GRPCPP_LIBRARY_NAME}}")
endforeach()
+ list(APPEND GRPCPP_LINK_LIBRARIES Threads::Threads)
Review Comment:
Oh, sorry. Could you work on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #36581: GH-36479: [C++][FlightRPC] Use gRPC version detected by find_package()
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #36581:
URL: https://github.com/apache/arrow/pull/36581#discussion_r1257652834
##########
cpp/cmake_modules/FindgRPCAlt.cmake:
##########
@@ -45,6 +47,7 @@ if(GRPCPP_PC_FOUND)
HINTS ${GRPCPP_PC_STATIC_LIBRARY_DIRS})
list(APPEND GRPCPP_LINK_LIBRARIES "${GRPCPP_LIBRARY_${GRPCPP_LIBRARY_NAME}}")
endforeach()
+ list(APPEND GRPCPP_LINK_LIBRARIES Threads::Threads)
Review Comment:
This is duplicated from L39, should we move it under the if as it is appended to the list in all cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #36581: GH-36479: [C++][FlightRPC] Use gRPC version detected by find_package()
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #36581:
URL: https://github.com/apache/arrow/pull/36581#discussion_r1257654614
##########
cpp/cmake_modules/FindgRPCAlt.cmake:
##########
@@ -45,6 +47,7 @@ if(GRPCPP_PC_FOUND)
HINTS ${GRPCPP_PC_STATIC_LIBRARY_DIRS})
list(APPEND GRPCPP_LINK_LIBRARIES "${GRPCPP_LIBRARY_${GRPCPP_LIBRARY_NAME}}")
endforeach()
+ list(APPEND GRPCPP_LINK_LIBRARIES Threads::Threads)
Review Comment:
(I apparently had this open while it was merged ^^ so we can do it in another related PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org