[GitHub] [geode] kirklund commented on a change in pull request #7315: GEODE-9991: Configure SSLParameters directly.

[GitBox <gi...@apache.org>]

kirklund commented on a change in pull request #7315:
URL: https://github.com/apache/geode/pull/7315#discussion_r804917579



##########
File path: geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/InternalDistributedSystemJUnitTest.java
##########
@@ -39,8 +39,11 @@
 import static org.apache.geode.distributed.ConfigurationProperties.STATISTIC_SAMPLING_ENABLED;
 import static org.apache.geode.internal.AvailablePortHelper.getRandomAvailableTCPPort;
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;

Review comment:
       I think `org.assertj.core.api.Assertions.assertThat` should be used for these instead of mixing two assertion libraries.
   
   You can also easily replace `org.junit.Assert.fail` with `org.assertj.core.api.Assertions.fail` just by swapping the import. Then that just leaves `org.junit.Assert.assertEquals` if you want to replace it with AssertJ.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org