You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Neil C Smith <ne...@apache.org> on 2020/10/21 15:13:16 UTC
Sig tests for 12.2?
Hi,
Been busy the last week, but finally getting a chance to download and
test 12.2 beta.
One thing that came up in discussion at end of 12.1 was preparing the
sig test files early for review. As per discussion in
https://github.com/apache/netbeans/pull/2338
Is there a plan for that yet? Couldn't see anything. Happy to have a
look at it.
Best wishes,
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Sig tests for 12.2?
Posted by Neil C Smith <ne...@apache.org>.
On Fri, 30 Oct 2020 at 13:00, Neil C Smith <ne...@apache.org> wrote:
> On Fri, 30 Oct 2020 at 07:39, Laszlo Kishalmi <la...@gmail.com> wrote:
> > Please share your ideas here! What I've tried is to re-generate the sig
> > files, so they would be up to date (User ant gen-sig-tests, I hope I'm
> > right about that).
> > Right now it does not show any difference between the existing and newly
> > generated files. Though I might do something wrong here.
>
> Yes, should show quite a lot. Am working on it now, and will open PR shortly.
OK, over to https://github.com/apache/netbeans/pull/2504 along with
steps taken. Hope that looks sane.
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Sig tests for 12.2?
Posted by Neil C Smith <ne...@apache.org>.
On Fri, 30 Oct 2020 at 07:39, Laszlo Kishalmi <la...@gmail.com> wrote:
>
> Dear Neil,
>
> Please share your ideas here! What I've tried is to re-generate the sig
> files, so they would be up to date (User ant gen-sig-tests, I hope I'm
> right about that).
> Right now it does not show any difference between the existing and newly
> generated files. Though I might do something wrong here.
Yes, should show quite a lot. Am working on it now, and will open PR shortly.
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Sig tests for 12.2?
Posted by Laszlo Kishalmi <la...@gmail.com>.
Dear Neil,
Please share your ideas here! What I've tried is to re-generate the sig
files, so they would be up to date (User ant gen-sig-tests, I hope I'm
right about that).
Right now it does not show any difference between the existing and newly
generated files. Though I might do something wrong here.
On 10/22/20 10:44 AM, Neil C Smith wrote:
> On Thu, 22 Oct 2020 at 01:35, Laszlo Kishalmi <la...@gmail.com> wrote:
>> I'm sorry, I was holding it off for ...
> Yes, no problem, I was just wondering if you'd had a thought how to
> do, because I realized I'd had a couple of thoughts after that PR
> conversation that I hadn't followed up on.
>
> Basically, had thought we'd generate a PR to master for this after
> first beta (or second now), but not merge. Then after each beta, the
> PR gets an update (if needed) - that way the review process for sigs
> is actually useful and can be tracked. Signature review then forms
> part of release review, any concerns can be addressed before release,
> and the PR can be updated, squashed and merged to master after
> release.
>
> Thoughts? Happy to have a look at producing the PR if you want?
>
> Best wishes,
>
> Neil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Sig tests for 12.2?
Posted by Neil C Smith <ne...@apache.org>.
On Thu, 22 Oct 2020 at 01:35, Laszlo Kishalmi <la...@gmail.com> wrote:
> I'm sorry, I was holding it off for ...
Yes, no problem, I was just wondering if you'd had a thought how to
do, because I realized I'd had a couple of thoughts after that PR
conversation that I hadn't followed up on.
Basically, had thought we'd generate a PR to master for this after
first beta (or second now), but not merge. Then after each beta, the
PR gets an update (if needed) - that way the review process for sigs
is actually useful and can be tracked. Signature review then forms
part of release review, any concerns can be addressed before release,
and the PR can be updated, squashed and merged to master after
release.
Thoughts? Happy to have a look at producing the PR if you want?
Best wishes,
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Sig tests for 12.2?
Posted by Laszlo Kishalmi <la...@gmail.com>.
Hi,
I'm sorry, I was holding it off for:
https://github.com/apache/netbeans/pull/2479
I'm still inspecting it, as Travis is not happy about that, however I'd
like to include it in 12.2 if possible.
On 10/21/20 8:13 AM, Neil C Smith wrote:
> Hi,
>
> Been busy the last week, but finally getting a chance to download and
> test 12.2 beta.
>
> One thing that came up in discussion at end of 12.1 was preparing the
> sig test files early for review. As per discussion in
> https://github.com/apache/netbeans/pull/2338
>
> Is there a plan for that yet? Couldn't see anything. Happy to have a
> look at it.
>
> Best wishes,
>
> Neil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists