You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2006/04/06 06:40:57 UTC

Re: [PATCH] apr_thread_yield with pthread

This has been sitting out a while.  Any comments from the vocal majority
on their favorite platform?  Seems sane to me, but needs eyes from folks
intimately familiar with the pthreads implementation.

I noticed more are trying to purge the bug queue so thought it's a good
time to mention again.

Bill

-------- Original Message --------
Subject: [PATCH] apr_thread_yield with pthread
Date: Mon, 27 Feb 2006 17:19:45 +0900
From: Keisuke Nishida <ke...@gmail.com>
To: dev@apr.apache.org

Hi,

I'm new to APR.  I've started using apr-1.2.2 as well as the trunk.

I found the definition of apr_thread_yield is empty in
apr/threadproc/unix/thread.c.
Is there any reason why not to call pthread_yield or sched_yield?

The attached patch does what I want.

Best regards,
Keisuke Nishida

Re: [PATCH] apr_thread_yield with pthread

Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 4/6/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> On 4/5/06, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
> > This has been sitting out a while.  Any comments from the vocal majority
> > on their favorite platform?  Seems sane to me, but needs eyes from folks
> > intimately familiar with the pthreads implementation.
> >
> > I noticed more are trying to purge the bug queue so thought it's a good
> > time to mention again.
>
> I haven't actually tried it, but based on what I know of pthreads it
> seems fine to me.

Ok, finally got around to trying this out.  Looks good to me,
committed to trunk in r418351.

Thanks for the patch Keisuke!

-garrett

Re: [PATCH] apr_thread_yield with pthread

Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 4/5/06, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
> This has been sitting out a while.  Any comments from the vocal majority
> on their favorite platform?  Seems sane to me, but needs eyes from folks
> intimately familiar with the pthreads implementation.
>
> I noticed more are trying to purge the bug queue so thought it's a good
> time to mention again.

I haven't actually tried it, but based on what I know of pthreads it
seems fine to me.

-garrett

Re: [PATCH] apr_thread_yield with pthread

Posted by Henry Jen <he...@ztune.net>.
William A. Rowe, Jr. wrote:
> This has been sitting out a while.  Any comments from the vocal majority
> on their favorite platform?  Seems sane to me, but needs eyes from folks
> intimately familiar with the pthreads implementation.
> 
> I noticed more are trying to purge the bug queue so thought it's a good
> time to mention again.
> 

+1 on Solaris 11.

Cheers,
Henry

> Bill
> 
> -------- Original Message --------
> Subject: [PATCH] apr_thread_yield with pthread
> Date: Mon, 27 Feb 2006 17:19:45 +0900
> From: Keisuke Nishida <ke...@gmail.com>
> To: dev@apr.apache.org
> 
> Hi,
> 
> I'm new to APR.  I've started using apr-1.2.2 as well as the trunk.
> 
> I found the definition of apr_thread_yield is empty in
> apr/threadproc/unix/thread.c.
> Is there any reason why not to call pthread_yield or sched_yield?
> 
> The attached patch does what I want.
> 
> Best regards,
> Keisuke Nishida
>