You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/05/11 23:45:52 UTC

[GitHub] [geode] DonalEvans commented on a diff in pull request #7677: GEODE-10286, GEODE-10287: handle CancelException in PersistenceAdvisor.close

DonalEvans commented on code in PR #7677:
URL: https://github.com/apache/geode/pull/7677#discussion_r870834942


##########
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java:
##########
@@ -2605,6 +2604,7 @@ protected void distributedRegionCleanup(RegionEventImpl event) {
       }
     }
     waitForCurrentOperations();
+    distAdvisor.close();

Review Comment:
   It seems that this change is leading to the `ConnectionCloseSSLTLSDUnitTest.connectionWithHungReaderIsCloseableAndUnhangsReader()` test hanging



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org