You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/09/12 05:35:14 UTC
Review Request 14098: Fixed slave's finalize() method to not throw segfault.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14098/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-690
https://issues.apache.org/jira/browse/MESOS-690
Repository: mesos-git
Description
-------
Need to copy 'frameworks' when looping through them and shutting them down because shutdownFramework() can mutate 'frameworks'.
Diffs
-----
src/slave/slave.cpp cefb42004da15d390c276ad5337b558ba5bf8e59
Diff: https://reviews.apache.org/r/14098/diff/
Testing
-------
make check
./bin/mesos-tests.sh --gtest_filter="*FaultToleranceTest*" --gtest_repeat=1000 --gtest_break_on_failure --gtest_shuffle
Thanks,
Vinod Kone
Re: Review Request 14098: Fixed slave's finalize() method to not throw
segfault.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14098/#review26392
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Sept. 24, 2013, 7:24 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14098/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2013, 7:24 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-690
> https://issues.apache.org/jira/browse/MESOS-690
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Need to copy 'frameworks' when looping through them and shutting them down because shutdownFramework() can mutate 'frameworks'.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 21b57f98dd11ceecac81e353c1b0058f11dd12b2
>
> Diff: https://reviews.apache.org/r/14098/diff/
>
>
> Testing
> -------
>
> make check
>
> ./bin/mesos-tests.sh --gtest_filter="*FaultToleranceTest*" --gtest_repeat=1000 --gtest_break_on_failure --gtest_shuffle
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 14098: Fixed slave's finalize() method to not throw
segfault.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14098/
-----------------------------------------------------------
(Updated Sept. 24, 2013, 7:24 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's. PTAL.
Bugs: MESOS-690
https://issues.apache.org/jira/browse/MESOS-690
Repository: mesos-git
Description
-------
Need to copy 'frameworks' when looping through them and shutting them down because shutdownFramework() can mutate 'frameworks'.
Diffs (updated)
-----
src/slave/slave.cpp 21b57f98dd11ceecac81e353c1b0058f11dd12b2
Diff: https://reviews.apache.org/r/14098/diff/
Testing
-------
make check
./bin/mesos-tests.sh --gtest_filter="*FaultToleranceTest*" --gtest_repeat=1000 --gtest_break_on_failure --gtest_shuffle
Thanks,
Vinod Kone
Re: Review Request 14098: Fixed slave's finalize() method to not throw
segfault.
Posted by Vinod Kone <vi...@gmail.com>.
> On Sept. 19, 2013, 8:50 p.m., Ben Mahler wrote:
> > src/slave/slave.cpp, line 456
> > <https://reviews.apache.org/r/14098/diff/1/?file=351123#file351123line456>
> >
> > Can you just use .keys()?
> >
> >
> > // The keys must be copied because they are removed in shutdownFramework().
> > foreach (const FrameworkID& frameworkId, frameworks.keys()) {
done. thanks.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14098/#review26285
-----------------------------------------------------------
On Sept. 12, 2013, 3:35 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14098/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2013, 3:35 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-690
> https://issues.apache.org/jira/browse/MESOS-690
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Need to copy 'frameworks' when looping through them and shutting them down because shutdownFramework() can mutate 'frameworks'.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp cefb42004da15d390c276ad5337b558ba5bf8e59
>
> Diff: https://reviews.apache.org/r/14098/diff/
>
>
> Testing
> -------
>
> make check
>
> ./bin/mesos-tests.sh --gtest_filter="*FaultToleranceTest*" --gtest_repeat=1000 --gtest_break_on_failure --gtest_shuffle
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 14098: Fixed slave's finalize() method to not throw
segfault.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14098/#review26285
-----------------------------------------------------------
Ship it!
src/slave/slave.cpp
<https://reviews.apache.org/r/14098/#comment51368>
Can you just use .keys()?
// The keys must be copied because they are removed in shutdownFramework().
foreach (const FrameworkID& frameworkId, frameworks.keys()) {
- Ben Mahler
On Sept. 12, 2013, 3:35 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14098/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2013, 3:35 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-690
> https://issues.apache.org/jira/browse/MESOS-690
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Need to copy 'frameworks' when looping through them and shutting them down because shutdownFramework() can mutate 'frameworks'.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp cefb42004da15d390c276ad5337b558ba5bf8e59
>
> Diff: https://reviews.apache.org/r/14098/diff/
>
>
> Testing
> -------
>
> make check
>
> ./bin/mesos-tests.sh --gtest_filter="*FaultToleranceTest*" --gtest_repeat=1000 --gtest_break_on_failure --gtest_shuffle
>
>
> Thanks,
>
> Vinod Kone
>
>