You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/06 04:43:54 UTC

[GitHub] [spark] HeartSaVioR commented on pull request #31056: [SPARK-33635][SS] Adjust the order of check in KafkaTokenUtil.needTokenUpdate to remedy perf regression

HeartSaVioR commented on pull request #31056:
URL: https://github.com/apache/spark/pull/31056#issuecomment-755074448


   I just fixed the smallest thing as a short-term solution (the problem will persist for end users using Kafka delegation token), as Spark 3.1.0 RC vote is happening and I don't want to drag the release too much.
   
   It would be ideal if we deal with long-term solution (making overhead of `HadoopDelegationTokenManager.isServiceEnabled` be minor, or reduce occurrence of the check heavily) in time, but just wanted to be safe.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org