You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/15 16:51:09 UTC
[GitHub] [incubator-mxnet] access2rohit opened a new pull request #18718: add large tensor test for matmul
access2rohit opened a new pull request #18718:
URL: https://github.com/apache/incubator-mxnet/pull/18718
## Description ##
checks for correctness for linalg_gemm2 operator for Large Matrices
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
## Test Results ##
```
(pytest) ubuntu@ip-172-31-90-243 ~/workspace/incubator-mxnet (example) $ python -m pytest -s --exitfirst --verbose tests/nightly/test_large_array.py::test_linalg_ops
=============================================================================================== test session starts ===============================================================================================
platform linux -- Python 3.6.10, pytest-5.3.5, py-1.8.2, pluggy-0.13.1 -- /home/ubuntu/anaconda3/envs/pytest/bin/python
cachedir: .pytest_cache
rootdir: /home/ubuntu/workspace/incubator-mxnet, inifile: pytest.ini
collected 1 item
tests/nightly/test_large_array.py::test_linalg_ops [16:43:23] ../src/operator/numpy/linalg/./../../tensor/../linalg_impl.h:157: inside cblas_gemm
PASSED
================================================================================================ warnings summary =================================================================================================
/home/ubuntu/anaconda3/envs/pytest/lib/python3.6/site-packages/_pytest/mark/structures.py:327
/home/ubuntu/anaconda3/envs/pytest/lib/python3.6/site-packages/_pytest/mark/structures.py:327: PytestUnknownMarkWarning: Unknown pytest.mark.timeout - is this a typo? You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/latest/mark.html
PytestUnknownMarkWarning,
-- Docs: https://docs.pytest.org/en/latest/warnings.html
==================================================================================== 1 passed, 1 warning in 142.42s (0:02:22) =====================================================================================
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18718: add large tensor test for matmul
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18718:
URL: https://github.com/apache/incubator-mxnet/pull/18718#issuecomment-658878061
Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-cpu, unix-cpu, centos-gpu, clang, centos-cpu, unix-gpu, windows-gpu, edge, miscellaneous, sanity, website]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #18718: [WIP][DO NOT MERGE] Add large tensor test for linalg_dgemm2
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #18718:
URL: https://github.com/apache/incubator-mxnet/pull/18718#issuecomment-665359037
> we are deprecating ndarray in 2.0 soon. we should start migrating tests to numpy arrays instead
Changed it to v1.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #18718: [WIP]add large tensor test for matmul
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #18718:
URL: https://github.com/apache/incubator-mxnet/pull/18718#issuecomment-659039797
@ChaiBapchya @mseth10 can you review ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #18718: Add large tensor test for linalg_dgemm2
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #18718:
URL: https://github.com/apache/incubator-mxnet/pull/18718#issuecomment-659179857
we are deprecating ndarray in 2.0 soon. we should start migrating tests to numpy arrays instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18718: [WIP][DO NOT MERGE] Add large tensor test for linalg_dgemm2
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18718:
URL: https://github.com/apache/incubator-mxnet/pull/18718#issuecomment-665378299
@access2rohit as linked in this PR: https://github.com/apache/incubator-mxnet/pull/18784 I already added forward & backward test for linalg.gemm2 in v1.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit closed pull request #18718: [WIP][DO NOT MERGE] Add large tensor test for linalg_dgemm2
Posted by GitBox <gi...@apache.org>.
access2rohit closed pull request #18718:
URL: https://github.com/apache/incubator-mxnet/pull/18718
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #18718: [WIP]add large tensor test for matmul
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #18718:
URL: https://github.com/apache/incubator-mxnet/pull/18718#issuecomment-659039939
@mxnet-label-bot add [pr-awaiting-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org