[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7804: Web-console: prevent unnecessary loading of disabled data sources

[GitBox <gi...@apache.org>]

vogievetsky commented on a change in pull request #7804: Web-console: prevent unnecessary loading of disabled data sources 
URL: https://github.com/apache/incubator-druid/pull/7804#discussion_r289205971
 
 

 ##########
 File path: web-console/src/views/datasource-view/datasource-view.tsx
 ##########
 @@ -151,7 +151,7 @@ export class DatasourcesView extends React.Component<DatasourcesViewProps, Datas
 
         const seen = countBy(datasources, (x: any) => x.datasource);
 
-        const disabledResp = await axios.get('/druid/coordinator/v1/metadata/datasources?includeDisabled');
+        const disabledResp = await axios.get(this.state.showDisabled ? '/druid/coordinator/v1/metadata/datasources?includeDisabled' : '/druid/coordinator/v1/metadata/datasources' );
 
 Review comment:
   if you do not need to get the disabled datasources then why make this query at all?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org