You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/02 15:11:30 UTC
[GitHub] [skywalking-python] kezhenxu94 opened a new pull request #32: [Doc] Add Flask plugin and since version to docs
kezhenxu94 opened a new pull request #32:
URL: https://github.com/apache/skywalking-python/pull/32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on a change in pull request #32: [Doc] Add Flask plugin and since version to docs
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #32:
URL: https://github.com/apache/skywalking-python/pull/32#discussion_r449073857
##########
File path: README.md
##########
@@ -63,11 +63,12 @@ Environment Variable | Description | Default
There're some built-in plugins that support automatic instrumentation of Python libraries, the complete lists are as follow:
-Library | Plugin Name
-| :--- | :--- |
-| [http.server](https://docs.python.org/3/library/http.server.html) | `sw_http_server` |
-| [urllib.request](https://docs.python.org/3/library/urllib.request.html) | `sw_urllib_request` |
-| [requests](https://requests.readthedocs.io/en/master/) | `requests` |
+Library | Plugin Name | Since Version
+| :--- | :--- | :--- |
+| [http.server](https://docs.python.org/3/library/http.server.html) | `sw_http_server` | v0.1.0 |
+| [urllib.request](https://docs.python.org/3/library/urllib.request.html) | `sw_urllib_request` | v0.1.0 |
+| [requests](https://requests.readthedocs.io/en/master/) | `sw_requests` | v0.1.0 |
+| [Flask](https://flask.palletsprojects.com/en/1.1.x/) | `sw_flask` | not yet released |
Review comment:
```suggestion
| [Flask](https://flask.palletsprojects.com/en/1.1.x/) | `sw_flask` | 0.2.0 |
```
How about `0.2.0`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #32: [Doc] Add Flask plugin and since version to docs
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #32:
URL: https://github.com/apache/skywalking-python/pull/32#discussion_r449075933
##########
File path: README.md
##########
@@ -63,11 +63,12 @@ Environment Variable | Description | Default
There're some built-in plugins that support automatic instrumentation of Python libraries, the complete lists are as follow:
-Library | Plugin Name
-| :--- | :--- |
-| [http.server](https://docs.python.org/3/library/http.server.html) | `sw_http_server` |
-| [urllib.request](https://docs.python.org/3/library/urllib.request.html) | `sw_urllib_request` |
-| [requests](https://requests.readthedocs.io/en/master/) | `requests` |
+Library | Plugin Name | Since Version
+| :--- | :--- | :--- |
+| [http.server](https://docs.python.org/3/library/http.server.html) | `sw_http_server` | v0.1.0 |
+| [urllib.request](https://docs.python.org/3/library/urllib.request.html) | `sw_urllib_request` | v0.1.0 |
+| [requests](https://requests.readthedocs.io/en/master/) | `sw_requests` | v0.1.0 |
+| [Flask](https://flask.palletsprojects.com/en/1.1.x/) | `sw_flask` | not yet released |
Review comment:
> How about `0.2.0`?
Because we haven't released it yet, and I don't know whether the milestone will change or not (although it's low possibility), the other problem is that users may misunderstand that there is v0.2.0 already, saying it `not yet release` may avoid unnecessary questions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 merged pull request #32: [Doc] Add Flask plugin and fix requests plugin name
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #32:
URL: https://github.com/apache/skywalking-python/pull/32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on a change in pull request #32: [Doc] Add Flask plugin and since version to docs
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #32:
URL: https://github.com/apache/skywalking-python/pull/32#discussion_r449077391
##########
File path: README.md
##########
@@ -63,11 +63,12 @@ Environment Variable | Description | Default
There're some built-in plugins that support automatic instrumentation of Python libraries, the complete lists are as follow:
-Library | Plugin Name
-| :--- | :--- |
-| [http.server](https://docs.python.org/3/library/http.server.html) | `sw_http_server` |
-| [urllib.request](https://docs.python.org/3/library/urllib.request.html) | `sw_urllib_request` |
-| [requests](https://requests.readthedocs.io/en/master/) | `requests` |
+Library | Plugin Name | Since Version
+| :--- | :--- | :--- |
+| [http.server](https://docs.python.org/3/library/http.server.html) | `sw_http_server` | v0.1.0 |
+| [urllib.request](https://docs.python.org/3/library/urllib.request.html) | `sw_urllib_request` | v0.1.0 |
+| [requests](https://requests.readthedocs.io/en/master/) | `sw_requests` | v0.1.0 |
+| [Flask](https://flask.palletsprojects.com/en/1.1.x/) | `sw_flask` | not yet released |
Review comment:
Actually, you don't need this version. Do you remember SkyWalking Java agent's supported list? Because we have tagged doc for different versions, we could link the documents in the README.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org