You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by sajithswa <gi...@git.apache.org> on 2015/02/17 08:26:36 UTC
[GitHub] stratos pull request: Change the fault members identifying way
GitHub user sajithswa opened a pull request:
https://github.com/apache/stratos/pull/230
Change the fault members identifying way
When same host having more than one instance and if one instance goes
down fault member map contain the host name. It is a bug. It must be
unique for each instance. Change identifier to mamber_id witch unique
one in conf file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sajithswa/stratos master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/stratos/pull/230.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #230
----
commit 19481a5b387d7dbe0fb20316806895f08c083753
Author: sajithswa <sa...@gmail.com>
Date: 2015-02-17T07:24:40Z
Change the fault members identifying way
When same host having more than one instance and if one instance goes
down fault member map contain the host name. It is a bug. It must be
unique for each instance. Change identifier to mamber_id witch unique
one in conf file
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Change the fault members identifying way
Posted by R-Rajkumar <gi...@git.apache.org>.
Github user R-Rajkumar commented on the pull request:
https://github.com/apache/stratos/pull/230#issuecomment-74833181
Since you have sent a different PR with these changes, can you please close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Change the fault members identifying way
Posted by R-Rajkumar <gi...@git.apache.org>.
Github user R-Rajkumar commented on the pull request:
https://github.com/apache/stratos/pull/230#issuecomment-74652180
Seems something went wrong with this PR. Why there are 58 commits?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Change the fault members identifying way
Posted by imesh <gi...@git.apache.org>.
Github user imesh commented on a diff in the pull request:
https://github.com/apache/stratos/pull/230#discussion_r24800071
--- Diff: components/org.apache.stratos.load.balancer/src/main/java/org/apache/stratos/load/balancer/endpoint/TenantAwareLoadBalanceEndpoint.java ---
@@ -801,10 +804,11 @@ public void setSessionAffinity(boolean sessionAffinity) {
private org.apache.axis2.clustering.Member currentMember;
private Endpoint currentEp;
private EndpointReference to;
- private Map<String, Boolean> faultyMembers;
+ private Map<String, Boolean> faultyMembersIds;
--- End diff --
Thanks @sajithswa for fixing this! Shall we rename map variable faultyMembersIds to faultyMemberIds?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Change the fault members identifying way
Posted by sajithswa <gi...@git.apache.org>.
Github user sajithswa closed the pull request at:
https://github.com/apache/stratos/pull/230
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Change the fault members identifying way
Posted by sajithswa <gi...@git.apache.org>.
GitHub user sajithswa reopened a pull request:
https://github.com/apache/stratos/pull/230
Change the fault members identifying way
When same host having more than one instance and if one instance goes
down fault member map contain the host name. It is a bug. It must be
unique for each instance. Change identifier to mamber_id witch unique
one in conf file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sajithswa/stratos master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/stratos/pull/230.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #230
----
commit 600803120e3974b512da463cc2d18037f3b1f360
Author: Lahiru Sandaruwan <la...@wso2.com>
Date: 2013-09-15T02:34:57Z
Changing version to 3.0.0-SNAPSHOT to 3.0.0-incubating and 3.0.0.SNAPSHOT to 3.0.0.incubating in scripts etc.
commit 2806c9786c73c5fb5394cdc4f1888f657714cbd7
Author: Isuru <is...@wso2.com>
Date: 2013-09-15T03:33:16Z
removing unwanted license files from 3.0.0-incubating branch
commit ae473de9f582138ef5abda9bac61e8b573f4fdaa
Author: Dinesh Bandara <di...@wso2.com>
Date: 2013-09-16T04:44:23Z
Create demo.sh for automating EC2 demo purposes
Signed-off-by: Lahiru Sandaruwan <la...@wso2.com>
commit 2df0fcdceabe9498d4a45bfe8e1d7e8656762d08
Author: Dinesh Bandara <di...@wso2.com>
Date: 2013-09-16T12:35:26Z
Modifications fro demo.sh
Signed-off-by: Isuru <is...@wso2.com>
commit d58ce96ae1e5f799c704915a3bbeac2cdf21530e
Author: Isuru <is...@wso2.com>
Date: 2013-09-17T06:01:24Z
fixing license verification failuers
commit ed3a75e7f2e1f1c82e0410ce7a768360fdb10196
Author: Dinesh Bandara <di...@wso2.com>
Date: 2013-09-17T05:38:55Z
Modifications in stratos-installer
Signed-off-by: Lahiru Sandaruwan <la...@wso2.com>
commit 66dc317ab457097b5ade7f1f39be56db39bfbf34
Author: Lahiru Sandaruwan <la...@wso2.com>
Date: 2013-09-23T09:29:40Z
Changes for adding DISCLAIMER to ditributions
commit 98dc4a310a101960211f65b5af4853d74505b0c6
Author: Lahiru Sandaruwan <la...@wso2.com>
Date: 2013-09-25T15:08:42Z
Removing unneccessary dist repos from pom files
commit 308cfb53b34eaefd2d8edc905e62ccbbd2f37232
Author: Lahiru Sandaruwan <la...@apache.org>
Date: 2013-09-25T17:13:08Z
Fixing pom file of cloud-services-icons
commit c230cb05159a70410f66724af52b2a2a89fb89c2
Author: Lahiru Sandaruwan <la...@apache.org>
Date: 2013-09-26T11:30:13Z
removing integration tests from SC
commit 8d62d1257b2357baf33834cd59ab4d1b1e6cf6cb
Author: Lahiru Sandaruwan <la...@apache.org>
Date: 2013-09-26T17:12:07Z
removing unnecessary license file
commit 6446051a89eb48650c10579ef4c7747b892edf7b
Author: Lahiru Sandaruwan <la...@apache.org>
Date: 2013-09-28T02:39:49Z
Removing unneccessory file from SC pack
commit ffadf707ebdb99c310567f2144359fe3a544682f
Author: Lahiru Sandaruwan <la...@apache.org>
Date: 2013-10-01T01:49:57Z
Changing inception year and added explanation to README
commit d01ea99bdc13b3f7e6eb2ccc72719c10fc6fd07c
Author: Lahiru Sandaruwan <la...@apache.org>
Date: 2013-10-01T13:06:55Z
Adding resource bundle for including disclaimer
commit 8385f6197e4efcf66ae571ca7776cbc0b83010ba
Author: Lahiru Sandaruwan <la...@apache.org>
Date: 2013-10-01T15:03:18Z
Adding release plugin to stratos pom
commit 0d2de61d185c6066bfd4563dd7482314e4adb35e
Author: Lahiru Sandaruwan <la...@apache.org>
Date: 2013-10-01T15:38:32Z
aAdding back the assembly plugin
commit 52198d18a623da84cc44ac2f003505189f181a0a
Author: Lahiru Sandaruwan <la...@apache.org>
Date: 2013-10-01T16:37:02Z
Adding wso2 repository for wso2 dependencies
commit bd0f6ea401e81b9d948521210f82809cc4085a00
Author: Lahiru Sandaruwan <la...@apache.org>
Date: 2013-10-01T16:57:24Z
adding mvn-source-plugin
commit 035f6a5d2bd5f6c5dd02480fb7d6ff1e494ad8c0
Author: Lahiru Sandaruwan <la...@apache.org>
Date: 2013-10-02T06:10:23Z
Adding assembly id to products and change source plug in goal to jar-no-fork
commit bd2ba17c8e7a6d526e1a8f55f8c6d0f0023643b8
Author: Lahiru Sandaruwan <la...@apache.org>
Date: 2013-10-02T06:46:31Z
Adding source plugin to plugins outside profile apache-release
commit a54402e4f694a07a02489c109e1c0f8035f4fc17
Author: Lahiru Sandaruwan <la...@apache.org>
Date: 2013-10-02T06:50:59Z
Removing un-used file
commit bd2c191d535865242eb0bdf9925b8260c8083a70
Author: Lahiru Sandaruwan <la...@apache.org>
Date: 2013-10-02T14:31:42Z
Fixing a build failure due to maven plugin update
commit bbb4c082b65623f16f4c2be4b4c95e6f7bdc2f63
Author: Lahiru Sandaruwan <la...@apache.org>
Date: 2013-10-02T16:51:32Z
removing id from assembly config
commit 0ba9ee04ac2d9e38585bb4cd979c0a2612b84668
Author: Lahiru Sandaruwan <la...@apache.org>
Date: 2013-10-02T17:58:53Z
stop adding assembly id
commit a9047bbf1b89515841e8a17294e89978c12f11c8
Author: Isuru <is...@wso2.com>
Date: 2013-10-07T09:44:20Z
removing unwanted files - cartridge_data_publisher_1.0.2.zip and thrift-0.8.0.tar.gz
commit 7e0cfd4b8dee01ac66def0a9c9fe87690ba3294d
Author: Imesh Gunaratne <im...@wso2.com>
Date: 2013-10-07T09:55:19Z
Fixed issue of domain name not being set in /etc/hosts file
commit 0cfc6d46587b87f6c47035348565e8ee6167b95e
Author: Imesh Gunaratne <im...@wso2.com>
Date: 2013-10-07T09:56:15Z
Merge branch '3.0.0-incubating' of https://git-wip-us.apache.org/repos/asf/incubator-stratos into 3.0.0-incubating
commit 1f50ed9a5f10f15479ab756424343041ba816ec9
Author: Lahiru Sandaruwan <la...@apache.org>
Date: 2013-10-08T04:45:11Z
Removing unneccesory source plugin
commit c7ae3bd2f90f81d228193b6c15a07eee3f608793
Author: Imesh Gunaratne <im...@wso2.com>
Date: 2013-10-08T04:47:58Z
Added -DapplyPatches option to apply patches in repository/components/patches folder at server startup
commit 9305b6c13b977084f411ee3a570d09f0400fe6c7
Author: Imesh Gunaratne <im...@wso2.com>
Date: 2013-10-08T04:48:38Z
Merge branch '3.0.0-incubating' of https://git-wip-us.apache.org/repos/asf/incubator-stratos into 3.0.0-incubating
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Change the fault members identifying way
Posted by R-Rajkumar <gi...@git.apache.org>.
Github user R-Rajkumar commented on the pull request:
https://github.com/apache/stratos/pull/230#issuecomment-74654076
I guess you can do the following;
1. take this diff
2. reset your local git repo branch (sajithswa:master) with apache master branch (apache:master)
3. apply the diff
4. send the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Change the fault members identifying way
Posted by sajithswa <gi...@git.apache.org>.
Github user sajithswa commented on the pull request:
https://github.com/apache/stratos/pull/230#issuecomment-74652558
I got some unnecessary commits to my git repo. So I roll back those.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Change the fault members identifying way
Posted by sajithswa <gi...@git.apache.org>.
Github user sajithswa closed the pull request at:
https://github.com/apache/stratos/pull/230
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Change the fault members identifying way
Posted by sajithswa <gi...@git.apache.org>.
Github user sajithswa commented on a diff in the pull request:
https://github.com/apache/stratos/pull/230#discussion_r24808409
--- Diff: components/org.apache.stratos.load.balancer/src/main/java/org/apache/stratos/load/balancer/endpoint/TenantAwareLoadBalanceEndpoint.java ---
@@ -80,6 +80,9 @@
private final static Pattern LAST_INT_PATTERN = Pattern.compile("[^0-9]+([0-9]+)$");
+ /* Define property name to get member_id*/
+ private static final String memberIDKey = "member_id";
--- End diff --
Never mind. I changed the code to use existing constants
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Change the fault members identifying way
Posted by sajithswa <gi...@git.apache.org>.
Github user sajithswa commented on a diff in the pull request:
https://github.com/apache/stratos/pull/230#discussion_r24808418
--- Diff: components/org.apache.stratos.load.balancer/src/main/java/org/apache/stratos/load/balancer/endpoint/TenantAwareLoadBalanceEndpoint.java ---
@@ -801,10 +804,11 @@ public void setSessionAffinity(boolean sessionAffinity) {
private org.apache.axis2.clustering.Member currentMember;
private Endpoint currentEp;
private EndpointReference to;
- private Map<String, Boolean> faultyMembers;
+ private Map<String, Boolean> faultyMembersIds;
--- End diff --
Sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Change the fault members identifying way
Posted by imesh <gi...@git.apache.org>.
Github user imesh commented on a diff in the pull request:
https://github.com/apache/stratos/pull/230#discussion_r24800181
--- Diff: components/org.apache.stratos.load.balancer/src/main/java/org/apache/stratos/load/balancer/endpoint/TenantAwareLoadBalanceEndpoint.java ---
@@ -80,6 +80,9 @@
private final static Pattern LAST_INT_PATTERN = Pattern.compile("[^0-9]+([0-9]+)$");
+ /* Define property name to get member_id*/
+ private static final String memberIDKey = "member_id";
--- End diff --
We already have a constant for "member_id": LoadBalancerConstants.MEMBER_ID. Would you mind removing this and use the existing?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Change the fault members identifying way
Posted by sajithswa <gi...@git.apache.org>.
Github user sajithswa commented on the pull request:
https://github.com/apache/stratos/pull/230#issuecomment-74833370
Sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---