You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/01/13 22:23:39 UTC
Review Request 42264: Fixed a GMock warning in
RoleTest.ImplicitRoleStaticReservation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42264/
-----------------------------------------------------------
Review request for mesos, Joris Van Remoortere and Timothy Chen.
Bugs: MESOS-4357
https://issues.apache.org/jira/browse/MESOS-4357
Repository: mesos
Description
-------
Fixed a GMock warning in RoleTest.ImplicitRoleStaticReservation.
Diffs
-----
src/tests/role_tests.cpp 373ae267b85588fe491ab0a0ce8aa195f971aac3
Diff: https://reviews.apache.org/r/42264/diff/
Testing
-------
Ran the test a few hundred times with and without the change; without the change, a warning is observed. With the change, no warning is observed.
Thanks,
Neil Conway
Re: Review Request 42264: Fixed a GMock warning in
RoleTest.ImplicitRoleStaticReservation.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42264/#review114632
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Jan. 13, 2016, 9:23 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42264/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 9:23 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Timothy Chen.
>
>
> Bugs: MESOS-4357
> https://issues.apache.org/jira/browse/MESOS-4357
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a GMock warning in RoleTest.ImplicitRoleStaticReservation.
>
>
> Diffs
> -----
>
> src/tests/role_tests.cpp 373ae267b85588fe491ab0a0ce8aa195f971aac3
>
> Diff: https://reviews.apache.org/r/42264/diff/
>
>
> Testing
> -------
>
> Ran the test a few hundred times with and without the change; without the change, a warning is observed. With the change, no warning is observed.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42264: Fixed a GMock warning in
RoleTest.ImplicitRoleStaticReservation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42264/#review114646
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42264]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 13, 2016, 9:23 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42264/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 9:23 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Timothy Chen.
>
>
> Bugs: MESOS-4357
> https://issues.apache.org/jira/browse/MESOS-4357
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a GMock warning in RoleTest.ImplicitRoleStaticReservation.
>
>
> Diffs
> -----
>
> src/tests/role_tests.cpp 373ae267b85588fe491ab0a0ce8aa195f971aac3
>
> Diff: https://reviews.apache.org/r/42264/diff/
>
>
> Testing
> -------
>
> Ran the test a few hundred times with and without the change; without the change, a warning is observed. With the change, no warning is observed.
>
>
> Thanks,
>
> Neil Conway
>
>