You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "mladjan-gadzic (via GitHub)" <gi...@apache.org> on 2023/06/12 06:53:16 UTC
[GitHub] [ozone] mladjan-gadzic commented on a diff in pull request #4695: HDDS-8489. Refactor GET request to POST for OM DB snapshot
mladjan-gadzic commented on code in PR #4695:
URL: https://github.com/apache/ozone/pull/4695#discussion_r1226167114
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/DBCheckpointServlet.java:
##########
@@ -216,6 +219,68 @@ public void doGet(HttpServletRequest request, HttpServletResponse response) {
}
}
+ /**
+ * Parses request form data parameters.
+ * @param request the HTTP servlet request
+ * @return array of parsed sst form data parameters for exclusion
+ */
+ private static String[] parseFormDataParameters(HttpServletRequest request) {
+ String fieldName = OZONE_DB_CHECKPOINT_REQUEST_TO_EXCLUDE_SST + "[]";
+ ServletFileUpload upload = new ServletFileUpload();
+ List<String> sstParam = new ArrayList<>();
+
+ try {
+ FileItemIterator iter = upload.getItemIterator(request);
+ while (iter.hasNext()) {
+ FileItemStream item = iter.next();
+ if (!item.isFormField()) {
+ continue;
+ }
+
+ if (!item.getFieldName().equals(fieldName)) {
Review Comment:
Conditions are combined and comparation is reversed.
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/DBCheckpointServlet.java:
##########
@@ -216,6 +219,68 @@ public void doGet(HttpServletRequest request, HttpServletResponse response) {
}
}
+ /**
+ * Parses request form data parameters.
+ * @param request the HTTP servlet request
+ * @return array of parsed sst form data parameters for exclusion
+ */
+ private static String[] parseFormDataParameters(HttpServletRequest request) {
+ String fieldName = OZONE_DB_CHECKPOINT_REQUEST_TO_EXCLUDE_SST + "[]";
Review Comment:
`FIELD_NAME` constant is created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org