[GitHub] [datasketches-cpp] AlexanderSaydakov commented on a diff in pull request #319: operator->

[GitBox <gi...@apache.org>]

AlexanderSaydakov commented on code in PR #319:
URL: https://github.com/apache/datasketches-cpp/pull/319#discussion_r1019710453


##########
kll/include/kll_sketch.hpp:
##########
@@ -588,12 +588,14 @@ class kll_sketch {
 template<typename T, typename C, typename A>
 class kll_sketch<T, C, A>::const_iterator: public std::iterator<std::input_iterator_tag, T> {
 public:
+  using value_type = std::pair<const T&, const uint64_t>;

Review Comment:
   this is a standard name: https://cplusplus.com/reference/iterator/iterator_traits/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org