You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/17 03:19:43 UTC
[GitHub] [flink] sunjincheng121 opened a new pull request #10876: [FLINK-15623][build] Exclude code style check of generation code in P…
sunjincheng121 opened a new pull request #10876: [FLINK-15623][build] Exclude code style check of generation code in P…
URL: https://github.com/apache/flink/pull/10876
## What is the purpose of the change
*In this PR will exclude code style check of generation code in PyFlink.*
## Brief change log
- Exclude code style check of generation code in `suppressions.xml`.
## Verifying this change
This change is already covered by existing tests, such as *(please describe tests)*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10876: [FLINK-15623][build] Exclude code style check of generation code in P…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10876: [FLINK-15623][build] Exclude code style check of generation code in P…
URL: https://github.com/apache/flink/pull/10876#issuecomment-575453799
<!--
Meta data
Hash:92c609248116ac31a5e3c7cb00a81d2a70845f06 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:92c609248116ac31a5e3c7cb00a81d2a70845f06
-->
## CI report:
* 92c609248116ac31a5e3c7cb00a81d2a70845f06 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10876: [FLINK-15623][build] Exclude code style check of generation code in P…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10876: [FLINK-15623][build] Exclude code style check of generation code in P…
URL: https://github.com/apache/flink/pull/10876#issuecomment-575453799
<!--
Meta data
Hash:92c609248116ac31a5e3c7cb00a81d2a70845f06 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144854219 TriggerType:PUSH TriggerID:92c609248116ac31a5e3c7cb00a81d2a70845f06
Hash:92c609248116ac31a5e3c7cb00a81d2a70845f06 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4414 TriggerType:PUSH TriggerID:92c609248116ac31a5e3c7cb00a81d2a70845f06
-->
## CI report:
* 92c609248116ac31a5e3c7cb00a81d2a70845f06 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144854219) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4414)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10876: [FLINK-15623][build] Exclude code style check of generation code in P…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10876: [FLINK-15623][build] Exclude code style check of generation code in P…
URL: https://github.com/apache/flink/pull/10876#issuecomment-575453799
<!--
Meta data
Hash:92c609248116ac31a5e3c7cb00a81d2a70845f06 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144854219 TriggerType:PUSH TriggerID:92c609248116ac31a5e3c7cb00a81d2a70845f06
Hash:92c609248116ac31a5e3c7cb00a81d2a70845f06 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4414 TriggerType:PUSH TriggerID:92c609248116ac31a5e3c7cb00a81d2a70845f06
-->
## CI report:
* 92c609248116ac31a5e3c7cb00a81d2a70845f06 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144854219) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4414)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10876: [FLINK-15623][build] Exclude code style check of generation code in P…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10876: [FLINK-15623][build] Exclude code style check of generation code in P…
URL: https://github.com/apache/flink/pull/10876#issuecomment-575447215
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 92c609248116ac31a5e3c7cb00a81d2a70845f06 (Fri Jan 17 03:22:42 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10876: [FLINK-15623][build] Exclude code style check of generation code in P…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10876: [FLINK-15623][build] Exclude code style check of generation code in P…
URL: https://github.com/apache/flink/pull/10876#issuecomment-575453799
<!--
Meta data
Hash:92c609248116ac31a5e3c7cb00a81d2a70845f06 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144854219 TriggerType:PUSH TriggerID:92c609248116ac31a5e3c7cb00a81d2a70845f06
Hash:92c609248116ac31a5e3c7cb00a81d2a70845f06 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4414 TriggerType:PUSH TriggerID:92c609248116ac31a5e3c7cb00a81d2a70845f06
-->
## CI report:
* 92c609248116ac31a5e3c7cb00a81d2a70845f06 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144854219) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4414)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] hequn8128 closed pull request #10876: [FLINK-15623][build] Exclude code style check of generation code in P…
Posted by GitBox <gi...@apache.org>.
hequn8128 closed pull request #10876: [FLINK-15623][build] Exclude code style check of generation code in P…
URL: https://github.com/apache/flink/pull/10876
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services