[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4461: [INLONG-4381][Manager] Optimize client http request

[GitBox <gi...@apache.org>]

healchow commented on code in PR #4461:
URL: https://github.com/apache/incubator-inlong/pull/4461#discussion_r885656157


##########
pom.xml:
##########
@@ -171,7 +171,7 @@
         <commons.collections.version>3.2.2</commons.collections.version>
         <commons.collections4.version>4.3</commons.collections4.version>
 
-        <guava.version>19.0</guava.version>
+        <guava.version>31.0.1-jre</guava.version>

Review Comment:
   Please add LICENSE and NOTICE for changed dependencies, refer to this guide: https://inlong.apache.org/community/how-to-maintain-3rd-party-dependencies



##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sink/SinkListResponse.java:
##########
@@ -18,16 +18,52 @@
 package org.apache.inlong.manager.common.pojo.sink;
 
 import com.fasterxml.jackson.annotation.JsonFormat;
+import com.fasterxml.jackson.annotation.JsonSubTypes;
+import com.fasterxml.jackson.annotation.JsonTypeInfo;
 import io.swagger.annotations.ApiModelProperty;
+import lombok.AllArgsConstructor;
 import lombok.Data;
+import lombok.NoArgsConstructor;
+import lombok.experimental.SuperBuilder;
+import org.apache.inlong.manager.common.pojo.sink.ck.ClickHouseSinkListResponse;
+import org.apache.inlong.manager.common.pojo.sink.es.ElasticsearchSinkListResponse;
+import org.apache.inlong.manager.common.pojo.sink.hbase.HBaseSinkListResponse;
+import org.apache.inlong.manager.common.pojo.sink.hive.HiveSinkListResponse;
+import org.apache.inlong.manager.common.pojo.sink.iceberg.IcebergSinkListResponse;
+import org.apache.inlong.manager.common.pojo.sink.kafka.KafkaSinkListResponse;
+import org.apache.inlong.manager.common.pojo.sink.postgres.PostgresSinkListResponse;
 
 import java.util.Date;
 import java.util.Map;
 
+import static org.apache.inlong.manager.common.enums.SinkType.SINK_CLICKHOUSE;
+import static org.apache.inlong.manager.common.enums.SinkType.SINK_ELASTICSEARCH;
+import static org.apache.inlong.manager.common.enums.SinkType.SINK_HBASE;
+import static org.apache.inlong.manager.common.enums.SinkType.SINK_HIVE;
+import static org.apache.inlong.manager.common.enums.SinkType.SINK_ICEBERG;
+import static org.apache.inlong.manager.common.enums.SinkType.SINK_KAFKA;
+import static org.apache.inlong.manager.common.enums.SinkType.SINK_POSTGRES;
+
 /**
  * Response of the sink list
  */
 @Data
+@SuperBuilder
+@NoArgsConstructor
+@AllArgsConstructor
+@JsonTypeInfo(
+        use = JsonTypeInfo.Id.NAME,
+        property = "sinkType",
+        visible = true)
+@JsonSubTypes({

Review Comment:
   The `JsonSubTypes` annotation is suggested replaced by `JsonTypeDefine` because `JsonTypeDefine` does not need to change the super class when adding a sub-class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org