You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/11 12:59:04 UTC
[GitHub] [incubator-superset] maloun96 opened a new pull request #12011: refactor: PropertiesModal to typescript
maloun96 opened a new pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011
### SUMMARY
Transform from jsx to tsx PropertiesModal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#discussion_r542152873
##########
File path: superset-frontend/src/dashboard/components/PropertiesModal.tsx
##########
@@ -38,33 +38,14 @@ import ColorSchemeControlWrapper from 'src/dashboard/components/ColorSchemeContr
import { getClientErrorObject } from '../../utils/getClientErrorObject';
import withToasts from '../../messageToasts/enhancers/withToasts';
import '../stylesheets/buttons.less';
+import Owner from '../../types/Owner';
Review comment:
Webpack has a "src" alias, which we can use for these imports rather than relative path. In this case `src/types/Owner`
We're trying to update these wherever we see them, while we're changing other things. It makes refactors (moving files around) easier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (2410e57) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `3.96%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
- Coverage 67.88% 63.91% -3.97%
==========================================
Files 948 471 -477
Lines 46177 28970 -17207
Branches 4405 0 -4405
==========================================
- Hits 31348 18517 -12831
+ Misses 14722 10453 -4269
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.91% <ø> (-0.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [487 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...2410e57](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (3a7e99d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.08%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
- Coverage 67.88% 63.80% -4.09%
==========================================
Files 948 475 -473
Lines 46177 29334 -16843
Branches 4405 0 -4405
==========================================
- Hits 31348 18716 -12632
+ Misses 14722 10618 -4104
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.80% <ø> (-0.78%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `58.62% <0.00%> (-34.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `78.72% <0.00%> (-15.40%)` | :arrow_down: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `78.00% <0.00%> (-13.18%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `34.78% <0.00%> (-5.75%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [515 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...eab3ea2](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (2410e57) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `3.37%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
- Coverage 67.88% 64.51% -3.38%
==========================================
Files 948 471 -477
Lines 46177 28985 -17192
Branches 4405 0 -4405
==========================================
- Hits 31348 18700 -12648
+ Misses 14722 10285 -4437
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.51% <ø> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.75% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.49% <0.00%> (-0.27%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | | |
| [superset-frontend/src/addSlice/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL2luZGV4LnRzeA==) | | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | | |
| [superset-frontend/src/theme.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3RoZW1lLnRz) | | |
| ... and [471 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...2410e57](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (155bcf4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **increase** coverage by `5.31%`.
> The diff coverage is `75.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
+ Coverage 67.88% 73.20% +5.31%
==========================================
Files 948 477 -471
Lines 46177 17205 -28972
Branches 4405 4405
==========================================
- Hits 31348 12595 -18753
+ Misses 14722 4500 -10222
- Partials 107 110 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.91% <68.42%> (-0.51%)` | :arrow_down: |
| javascript | `62.98% <60.00%> (+0.02%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `25.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `91.66% <ø> (ø)` | |
| [...ntend/src/dashboard/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC50c3g=) | `84.80% <77.77%> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `52.22% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.12% <0.00%> (-5.17%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `58.11% <0.00%> (-3.85%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.11% <0.00%> (-2.78%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `38.42% <0.00%> (-2.48%)` | :arrow_down: |
| ... and [474 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...155bcf4](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (2410e57) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `3.37%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
- Coverage 67.88% 64.51% -3.38%
==========================================
Files 948 471 -477
Lines 46177 28985 -17192
Branches 4405 0 -4405
==========================================
- Hits 31348 18700 -12648
+ Misses 14722 10285 -4437
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.51% <ø> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.75% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.49% <0.00%> (-0.27%)` | :arrow_down: |
| [...rset-frontend/src/common/components/DatePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0RhdGVQaWNrZXIudHN4) | | |
| [...erset-frontend/src/SqlLab/components/SaveQuery.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVRdWVyeS50c3g=) | | |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | | |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | | |
| ... and [471 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...2410e57](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#discussion_r544076715
##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -164,7 +164,7 @@ export function createErrorHandler(handleErrorFunc: (errMsg?: string) => void) {
return async (e: SupersetClientResponse | string) => {
const parsedError = await getClientErrorObject(e);
logging.error(e);
- handleErrorFunc(parsedError.message || parsedError.error);
+ handleErrorFunc((parsedError.message || parsedError.error) as string);
Review comment:
This is likely due to the new type `message?: string | Record<string, any>;` above. We should probably handle the case for `Record<string, any>`. `JSON.stringify`? or perhaps we can find an elegant way to format these records into a human readable string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (e78f948) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.18%`.
> The diff coverage is `65.21%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
- Coverage 67.88% 63.70% -4.19%
==========================================
Files 948 959 +11
Lines 46177 47151 +974
Branches 4405 4609 +204
==========================================
- Hits 31348 30037 -1311
- Misses 14722 16931 +2209
- Partials 107 183 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.70% <65.21%> (-0.26%)` | :arrow_down: |
| python | `64.30% <ø> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | `88.15% <ø> (ø)` | |
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `91.66% <ø> (ø)` | |
| [...ntend/src/dashboard/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC50c3g=) | `70.73% <66.66%> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `51.11% <100.00%> (-1.12%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [239 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...e78f948](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] maloun96 commented on a change in pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
maloun96 commented on a change in pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#discussion_r544440360
##########
File path: superset-frontend/src/dashboard/components/PropertiesModal.tsx
##########
@@ -403,7 +419,6 @@ class PropertiesModal extends React.PureComponent {
<StyledJsonEditor
showLoadingForImport
name="json_metadata"
- defaultValue={this.defaultMetadataValue}
Review comment:
this.defaultMetadataValue does not exist is not defined anywhere in this modal @etr2460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (e78f948) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.39%`.
> The diff coverage is `65.21%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
- Coverage 67.88% 63.48% -4.40%
==========================================
Files 948 959 +11
Lines 46177 47151 +974
Branches 4405 4609 +204
==========================================
- Hits 31348 29935 -1413
- Misses 14722 17033 +2311
- Partials 107 183 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.70% <65.21%> (-0.26%)` | :arrow_down: |
| python | `63.96% <ø> (-0.62%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | `88.15% <ø> (ø)` | |
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `91.66% <ø> (ø)` | |
| [...ntend/src/dashboard/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC50c3g=) | `70.73% <66.66%> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `51.11% <100.00%> (-1.12%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [242 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...e78f948](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (f870f7c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `14.63%`.
> The diff coverage is `68.42%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
===========================================
- Coverage 67.88% 53.25% -14.64%
===========================================
Files 948 436 -512
Lines 46177 15676 -30501
Branches 4405 4056 -349
===========================================
- Hits 31348 8348 -23000
+ Misses 14722 7328 -7394
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.25% <68.42%> (-1.17%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `28.57% <0.00%> (+3.57%)` | :arrow_up: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `33.33% <ø> (-58.34%)` | :arrow_down: |
| [...ntend/src/dashboard/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC50c3g=) | `58.71% <70.58%> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `32.50% <100.00%> (-19.73%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [807 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...f870f7c](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (2410e57) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `3.52%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
- Coverage 67.88% 64.36% -3.53%
==========================================
Files 948 471 -477
Lines 46177 28970 -17207
Branches 4405 0 -4405
==========================================
- Hits 31348 18647 -12701
+ Misses 14722 10323 -4399
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.36% <ø> (-0.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.75% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.34% <0.00%> (-0.42%)` | :arrow_down: |
| ... and [482 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...2410e57](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (e78f948) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.50%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
- Coverage 67.88% 63.37% -4.51%
==========================================
Files 948 476 -472
Lines 46177 29371 -16806
Branches 4405 0 -4405
==========================================
- Hits 31348 18615 -12733
+ Misses 14722 10756 -3966
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.37% <ø> (-1.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `58.62% <0.00%> (-34.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `78.72% <0.00%> (-15.40%)` | :arrow_down: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `78.00% <0.00%> (-13.18%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| ... and [531 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...e78f948](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (155bcf4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.90%`.
> The diff coverage is `60.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
- Coverage 67.88% 62.98% -4.91%
==========================================
Files 948 477 -471
Lines 46177 17195 -28982
Branches 4405 4405
==========================================
- Hits 31348 10830 -20518
+ Misses 14722 6188 -8534
- Partials 107 177 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.98% <60.00%> (+0.02%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `91.66% <ø> (ø)` | |
| [...ntend/src/dashboard/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC50c3g=) | `69.60% <61.11%> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `51.11% <100.00%> (-1.12%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [643 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...155bcf4](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (a1cc503) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.17%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
- Coverage 67.88% 63.71% -4.18%
==========================================
Files 948 475 -473
Lines 46177 29334 -16843
Branches 4405 0 -4405
==========================================
- Hits 31348 18690 -12658
+ Misses 14722 10644 -4078
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.71% <ø> (-0.87%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `58.62% <0.00%> (-34.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `78.72% <0.00%> (-15.40%)` | :arrow_down: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `78.00% <0.00%> (-13.18%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `34.78% <0.00%> (-5.75%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| ... and [520 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...eab3ea2](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (2410e57) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `3.52%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
- Coverage 67.88% 64.35% -3.53%
==========================================
Files 948 471 -477
Lines 46177 28985 -17192
Branches 4405 0 -4405
==========================================
- Hits 31348 18654 -12694
+ Misses 14722 10331 -4391
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.35% <ø> (-0.23%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.75% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.36% <0.00%> (-0.41%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.61% <0.00%> (-0.28%)` | :arrow_down: |
| ... and [475 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...2410e57](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (e78f948) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.20%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
- Coverage 67.88% 63.68% -4.21%
==========================================
Files 948 476 -472
Lines 46177 29386 -16791
Branches 4405 0 -4405
==========================================
- Hits 31348 18714 -12634
+ Misses 14722 10672 -4050
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.68% <ø> (-0.90%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `58.62% <0.00%> (-34.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `78.72% <0.00%> (-15.40%)` | :arrow_down: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `78.00% <0.00%> (-13.18%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `34.78% <0.00%> (-5.75%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| ... and [514 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...e78f948](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (3a7e99d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.12%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
- Coverage 67.88% 63.76% -4.13%
==========================================
Files 948 475 -473
Lines 46177 29334 -16843
Branches 4405 0 -4405
==========================================
- Hits 31348 18705 -12643
+ Misses 14722 10629 -4093
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.76% <ø> (-0.82%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `58.62% <0.00%> (-34.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `78.72% <0.00%> (-15.40%)` | :arrow_down: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `78.00% <0.00%> (-13.18%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `34.78% <0.00%> (-5.75%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
| ... and [517 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...eab3ea2](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (a1cc503) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.09%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
- Coverage 67.88% 63.79% -4.10%
==========================================
Files 948 475 -473
Lines 46177 29349 -16828
Branches 4405 0 -4405
==========================================
- Hits 31348 18723 -12625
+ Misses 14722 10626 -4096
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.79% <ø> (-0.79%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `58.62% <0.00%> (-34.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `78.72% <0.00%> (-15.40%)` | :arrow_down: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `78.00% <0.00%> (-13.18%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `34.78% <0.00%> (-5.75%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [509 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...eab3ea2](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#discussion_r544434870
##########
File path: superset-frontend/src/dashboard/components/PropertiesModal.tsx
##########
@@ -403,7 +419,6 @@ class PropertiesModal extends React.PureComponent {
<StyledJsonEditor
showLoadingForImport
name="json_metadata"
- defaultValue={this.defaultMetadataValue}
Review comment:
what's the implication of removing this line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#discussion_r545239855
##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -164,7 +164,7 @@ export function createErrorHandler(handleErrorFunc: (errMsg?: string) => void) {
return async (e: SupersetClientResponse | string) => {
const parsedError = await getClientErrorObject(e);
logging.error(e);
- handleErrorFunc(parsedError.message || parsedError.error);
+ handleErrorFunc((parsedError.message || parsedError.error) as string);
Review comment:
So maybe we should do:
```typescript
(
typeof parsedError.message === "string"
? parsedError.message
: parsedError.message
? JSON.stringify(parsedError.message)
: parsedError.error
)
```
Does that make sense/fix the issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (e78f948) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.53%`.
> The diff coverage is `65.21%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
- Coverage 67.88% 63.34% -4.54%
==========================================
Files 948 959 +11
Lines 46177 47151 +974
Branches 4405 4609 +204
==========================================
- Hits 31348 29869 -1479
- Misses 14722 17099 +2377
- Partials 107 183 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.70% <65.21%> (-0.26%)` | :arrow_down: |
| python | `63.73% <ø> (-0.85%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | `88.15% <ø> (ø)` | |
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `91.66% <ø> (ø)` | |
| [...ntend/src/dashboard/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC50c3g=) | `70.73% <66.66%> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `51.11% <100.00%> (-1.12%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [246 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...e78f948](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (21b0171) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `15.24%`.
> The diff coverage is `68.42%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
===========================================
- Coverage 67.88% 52.64% -15.25%
===========================================
Files 948 438 -510
Lines 46177 15714 -30463
Branches 4405 4060 -345
===========================================
- Hits 31348 8272 -23076
+ Misses 14722 7442 -7280
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.64% <68.42%> (-1.78%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `28.57% <0.00%> (+3.57%)` | :arrow_up: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `33.33% <ø> (-58.34%)` | :arrow_down: |
| [...ntend/src/dashboard/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC50c3g=) | `58.71% <70.58%> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `32.50% <100.00%> (-19.73%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [810 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...21b0171](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (155bcf4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **increase** coverage by `5.59%`.
> The diff coverage is `75.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
+ Coverage 67.88% 73.48% +5.59%
==========================================
Files 948 477 -471
Lines 46177 17205 -28972
Branches 4405 4405
==========================================
- Hits 31348 12643 -18705
+ Misses 14722 4456 -10266
+ Partials 107 106 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.40% <68.42%> (-0.02%)` | :arrow_down: |
| javascript | `62.98% <60.00%> (+0.02%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `25.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `91.66% <ø> (ø)` | |
| [...ntend/src/dashboard/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC50c3g=) | `84.80% <77.77%> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `52.22% <100.00%> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.06% <0.00%> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | | |
| [superset/migrations/versions/d6db5a5cdb5d\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kNmRiNWE1Y2RiNWRfLnB5) | | |
| [...ions/versions/e553e78e90c5\_add\_druid\_auth\_py\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lNTUzZTc4ZTkwYzVfYWRkX2RydWlkX2F1dGhfcHlfcHkucHk=) | | |
| [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | | |
| ... and [467 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...155bcf4](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (e78f948) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.14%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
- Coverage 67.88% 63.73% -4.15%
==========================================
Files 948 476 -472
Lines 46177 29386 -16791
Branches 4405 0 -4405
==========================================
- Hits 31348 18730 -12618
+ Misses 14722 10656 -4066
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.73% <ø> (-0.85%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `58.62% <0.00%> (-34.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `78.72% <0.00%> (-15.40%)` | :arrow_down: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `78.00% <0.00%> (-13.18%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `34.78% <0.00%> (-5.75%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [513 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...e78f948](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#discussion_r544073847
##########
File path: superset-frontend/src/dashboard/components/PropertiesModal.tsx
##########
@@ -199,15 +210,15 @@ class PropertiesModal extends React.PureComponent {
colorScheme: jsonMetadataObj.color_scheme,
},
}));
- const initialSelectedOwners = dashboard.owners.map(owner => ({
+ const initialSelectedOwners = dashboard.owners.map((owner: Owner) => ({
Review comment:
I just found a type in the wild on another PR! Still a long road ahead, no doubt about it, but it's getting better!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#discussion_r543509391
##########
File path: superset-frontend/src/dashboard/components/PropertiesModal.tsx
##########
@@ -103,8 +84,38 @@ const loadOwnerOptions = (input = '') => {
);
};
-class PropertiesModal extends React.PureComponent {
- constructor(props) {
+type PropertiesModalProps = {
+ dashboardId: number;
+ show: boolean;
+ onHide: () => void;
+ colorScheme?: string;
+ setColorSchemeAndUnsavedChanges: () => void;
Review comment:
This isn't anything you changed, but I don't see `setColorSchemeAndUnsavedChanges` anywhere else in this file. Think it can be removed entirely?
##########
File path: superset-frontend/src/dashboard/components/PropertiesModal.tsx
##########
@@ -160,16 +171,16 @@ class PropertiesModal extends React.PureComponent {
this.updateFormState('colorScheme', value);
}
- onOwnersChange(value) {
+ onOwnersChange(value: Record<string, any>) {
this.updateFormState('owners', value);
}
- onMetadataChange(metadata) {
+ onMetadataChange(metadata: string) {
this.updateFormState('json_metadata', metadata);
}
- onChange(e) {
- const { name, value } = e.target;
+ onChange(e: React.FormEvent<FormControl>) {
+ const { name, value } = e.target as HTMLInputElement;
Review comment:
Same comment as in your previous PR about the typing here to try and avoid casting
##########
File path: superset-frontend/src/setup/setupApp.ts
##########
@@ -33,7 +33,7 @@ function showApiMessage(resp: ClientErrorObject) {
const severity = resp.severity || 'info';
$(template)
.addClass(`alert-${severity}`)
- .append(resp.message || '')
+ .append((resp.message || '') as string)
Review comment:
instead of coercing, could we do a better check here?
I presume `resp.message` could be a variety of different types, perhaps it would be better to do `String(resp.message)`? Or maybe `resp.message ? String(resp.message) : ''`
##########
File path: superset-frontend/src/dashboard/components/PropertiesModal.tsx
##########
@@ -222,7 +233,7 @@ class PropertiesModal extends React.PureComponent {
}));
}
- submit(e) {
+ submit(e: any) {
Review comment:
We know this is some type of Event right? Maybe we can do better than any
##########
File path: superset-frontend/src/dashboard/components/PropertiesModal.tsx
##########
@@ -235,8 +246,8 @@ class PropertiesModal extends React.PureComponent {
},
} = this.state;
const { onlyApply } = this.props;
- const owners = ownersValue.map(o => o.value);
- let metadataColorScheme;
+ const owners = ownersValue.map((o: Record<string, any>) => o.value);
+ const metadataColorScheme: string | undefined = undefined;
Review comment:
i don't think this is doing what we want, or at least it certainly isn't a const if you're changing it on line 254.
##########
File path: superset-frontend/src/dashboard/components/PropertiesModal.tsx
##########
@@ -199,15 +210,15 @@ class PropertiesModal extends React.PureComponent {
colorScheme: jsonMetadataObj.color_scheme,
},
}));
- const initialSelectedOwners = dashboard.owners.map(owner => ({
+ const initialSelectedOwners = dashboard.owners.map((owner: Owner) => ({
Review comment:
woo, i love it when we can pull in types that are already defined! Stuff like this means that typing should hit an inflection point where the typing migrations becomes mostly pulling in types from other places
##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -164,7 +164,7 @@ export function createErrorHandler(handleErrorFunc: (errMsg?: string) => void) {
return async (e: SupersetClientResponse | string) => {
const parsedError = await getClientErrorObject(e);
logging.error(e);
- handleErrorFunc(parsedError.message || parsedError.error);
+ handleErrorFunc((parsedError.message || parsedError.error) as string);
Review comment:
any way we can avoid the coercion here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (f870f7c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `15.11%`.
> The diff coverage is `68.42%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
===========================================
- Coverage 67.88% 52.77% -15.12%
===========================================
Files 948 436 -512
Lines 46177 15676 -30501
Branches 4405 4056 -349
===========================================
- Hits 31348 8273 -23075
+ Misses 14722 7403 -7319
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.77% <68.42%> (-1.65%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `28.57% <0.00%> (+3.57%)` | :arrow_up: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `33.33% <ø> (-58.34%)` | :arrow_down: |
| [...ntend/src/dashboard/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC50c3g=) | `58.71% <70.58%> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `32.50% <100.00%> (-19.73%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [808 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...f870f7c](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12011: refactor: PropertiesModal to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12011:
URL: https://github.com/apache/incubator-superset/pull/12011#issuecomment-743189466
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=h1) Report
> Merging [#12011](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=desc) (21b0171) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `14.76%`.
> The diff coverage is `68.42%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12011/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12011 +/- ##
===========================================
- Coverage 67.88% 53.11% -14.77%
===========================================
Files 948 438 -510
Lines 46177 15714 -30463
Branches 4405 4060 -345
===========================================
- Hits 31348 8347 -23001
+ Misses 14722 7367 -7355
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.11% <68.42%> (-1.31%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `28.57% <0.00%> (+3.57%)` | :arrow_up: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `33.33% <ø> (-58.34%)` | :arrow_down: |
| [...ntend/src/dashboard/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC50c3g=) | `58.71% <70.58%> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `32.50% <100.00%> (-19.73%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [809 more](https://codecov.io/gh/apache/incubator-superset/pull/12011/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=footer). Last update [916f7e9...21b0171](https://codecov.io/gh/apache/incubator-superset/pull/12011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org