You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2016/12/21 03:06:24 UTC
Review Request 54926: Augmented a fault_tolerance_test to cover
update of role.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54926/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Guangya Liu.
Repository: mesos
Description
-------
In currently implementation, update of role during framework
failover is ignored. This behavior should be reflected in test.
Diffs
-----
src/tests/fault_tolerance_tests.cpp 05937a917a2c175aa53b52488febb7cfd8400a13
Diff: https://reviews.apache.org/r/54926/diff/
Testing
-------
make check
Thanks,
Jay Guo
Re: Review Request 54926: Augmented a fault_tolerance_test to cover
update of role.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54926/#review159851
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54926]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 21, 2016, 3:06 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54926/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2016, 3:06 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In currently implementation, update of role during framework
> failover is ignored. This behavior should be reflected in test.
>
>
> Diffs
> -----
>
> src/tests/fault_tolerance_tests.cpp 05937a917a2c175aa53b52488febb7cfd8400a13
>
> Diff: https://reviews.apache.org/r/54926/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 54926: Augmented a fault_tolerance_test to cover
update of role.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54926/#review161361
-----------------------------------------------------------
Can you please abandon this? Seems duplicate with https://reviews.apache.org/r/55445/
- Guangya Liu
On \u5341\u4e8c\u6708 21, 2016, 3:06 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54926/
> -----------------------------------------------------------
>
> (Updated \u5341\u4e8c\u6708 21, 2016, 3:06 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In currently implementation, update of role during framework
> failover is ignored. This behavior should be reflected in test.
>
>
> Diffs
> -----
>
> src/tests/fault_tolerance_tests.cpp 05937a917a2c175aa53b52488febb7cfd8400a13
>
> Diff: https://reviews.apache.org/r/54926/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 54926: Augmented a fault_tolerance_test to cover
update of role.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54926/#review161360
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On \u5341\u4e8c\u6708 21, 2016, 3:06 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54926/
> -----------------------------------------------------------
>
> (Updated \u5341\u4e8c\u6708 21, 2016, 3:06 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In currently implementation, update of role during framework
> failover is ignored. This behavior should be reflected in test.
>
>
> Diffs
> -----
>
> src/tests/fault_tolerance_tests.cpp 05937a917a2c175aa53b52488febb7cfd8400a13
>
> Diff: https://reviews.apache.org/r/54926/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>