You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "aIbrahiim (via GitHub)" <gi...@apache.org> on 2025/11/21 13:25:08 UTC
[PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
aIbrahiim opened a new pull request, #36874:
URL: https://github.com/apache/beam/pull/36874
Fixes: https://github.com/apache/beam/actions/workflows/beam_PostCommit_Yaml_Xlang_Direct.yml
Successful run: https://github.com/aIbrahiim/beam/actions/runs/19570901663
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #36874:
URL: https://github.com/apache/beam/pull/36874#discussion_r2560582775
##########
sdks/python/apache_beam/transforms/enrichment_handlers/bigquery.py:
##########
@@ -141,11 +141,13 @@ def __init__(
self.project = project
self.column_names = column_names
self.select_fields = ",".join(column_names) if column_names else '*'
- self.row_restriction_template = row_restriction_template
+ self.row_restriction_template = (
+ row_restriction_template.replace('{{}}', '{}'))
self.table_name = table_name
self.fields = fields if fields else []
self.condition_value_fn = condition_value_fn
self.query_fn = query_fn
+ self._has_placeholders = '{}' in self.row_restriction_template
Review Comment:
I don't think we need to add a new feature to support {} placeholders
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #36874:
URL: https://github.com/apache/beam/pull/36874#discussion_r2566957905
##########
sdks/python/apache_beam/yaml/extended_tests/data/enrichment.yaml:
##########
@@ -82,6 +82,8 @@ pipelines:
- type: AssertEqual
config:
elements:
+ - {label: '11a', rank: 0, name: 'S1'}
- {label: '37a', rank: 1, name: 'S2'}
+ - {label: '389a', rank: 2, name: 'S3'}
Review Comment:
Also, from the original docstring, the line `row_restriction_template: "label = '37a'"` in the yaml file is supposed to filter the rows. Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #36874:
URL: https://github.com/apache/beam/pull/36874#discussion_r2566953916
##########
sdks/python/apache_beam/yaml/extended_tests/data/enrichment.yaml:
##########
@@ -82,6 +82,8 @@ pipelines:
- type: AssertEqual
config:
elements:
+ - {label: '11a', rank: 0, name: 'S1'}
- {label: '37a', rank: 1, name: 'S2'}
+ - {label: '389a', rank: 2, name: 'S3'}
Review Comment:
When I looked at this the other day, I found it is a flaky test.
https://github.com/apache/beam/actions/runs/19349133623/job/55356733649
In the run above, one was successful, while the others were not.
The perm-red started around 11/13, but I did not see any related change there.
https://github.com/apache/beam/issues/35198#issuecomment-3573557297
Even if we have a fix, we have to run it multiple times to make sure it won't be flaky again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #36874:
URL: https://github.com/apache/beam/pull/36874#issuecomment-3563029603
@damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #36874:
URL: https://github.com/apache/beam/pull/36874#discussion_r2549994048
##########
sdks/python/apache_beam/yaml/extended_tests/data/enrichment.yaml:
##########
@@ -62,7 +62,7 @@ pipelines:
project: apache-beam-testing
table_name: "{BQ_TABLE}"
fields: ['label']
- row_restriction_template: "label = '37a'"
+ row_restriction_template: "label = '{{}}'"
Review Comment:
This should work as written, so if this is failing then it is probably a real bug which is being covered up. We should address that in the transform itself, not in the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36874:
URL: https://github.com/apache/beam/pull/36874#issuecomment-3572687294
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #36874: Fix PostCommit YAML Xlang Direct Workflow
URL: https://github.com/apache/beam/pull/36874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #36874:
URL: https://github.com/apache/beam/pull/36874#issuecomment-3573066170
PTAL at lint and formatter errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #36874:
URL: https://github.com/apache/beam/pull/36874#discussion_r2560580576
##########
sdks/python/apache_beam/yaml/extended_tests/data/enrichment.yaml:
##########
@@ -62,7 +62,7 @@ pipelines:
project: apache-beam-testing
table_name: "{BQ_TABLE}"
fields: ['label']
- row_restriction_template: "label = '37a'"
+ row_restriction_template: "label = '{{}}'"
Review Comment:
To be clear - we should not be changing this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #36874:
URL: https://github.com/apache/beam/pull/36874#discussion_r2566957905
##########
sdks/python/apache_beam/yaml/extended_tests/data/enrichment.yaml:
##########
@@ -82,6 +82,8 @@ pipelines:
- type: AssertEqual
config:
elements:
+ - {label: '11a', rank: 0, name: 'S1'}
- {label: '37a', rank: 1, name: 'S2'}
+ - {label: '389a', rank: 2, name: 'S3'}
Review Comment:
Also, according to the original docstring of `row_restriction_template`, the line `row_restriction_template: "label = '37a'"` in the yaml file is supposed to filter the rows. Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #36874:
URL: https://github.com/apache/beam/pull/36874#issuecomment-3563034254
R: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #36874:
URL: https://github.com/apache/beam/pull/36874#discussion_r2566440168
##########
sdks/python/apache_beam/yaml/extended_tests/data/enrichment.yaml:
##########
@@ -82,6 +82,8 @@ pipelines:
- type: AssertEqual
config:
elements:
+ - {label: '11a', rank: 0, name: 'S1'}
- {label: '37a', rank: 1, name: 'S2'}
+ - {label: '389a', rank: 2, name: 'S3'}
Review Comment:
Why are we changing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36874:
URL: https://github.com/apache/beam/pull/36874#issuecomment-3841119468
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #36874:
URL: https://github.com/apache/beam/pull/36874#issuecomment-3563038332
/assign @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #36874:
URL: https://github.com/apache/beam/pull/36874#issuecomment-3572679632
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/36874?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `31 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 40.41%. Comparing base ([`c8d7ca0`](https://app.codecov.io/gh/apache/beam/commit/c8d7ca02867ced1cb3cd0476dbcaed48cedd8884?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2a21b38`](https://app.codecov.io/gh/apache/beam/commit/2a21b38bcbfbdeea17a42c40c4da3f91a4fbfd0b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 46 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/beam/pull/36874?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he\_beam/transforms/enrichment\_handlers/bigquery.py](https://app.codecov.io/gh/apache/beam/pull/36874?src=pr&el=tree&filepath=sdks%2Fpython%2Fapache_beam%2Ftransforms%2Fenrichment_handlers%2Fbigquery.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnJpY2htZW50X2hhbmRsZXJzL2JpZ3F1ZXJ5LnB5) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/beam/pull/36874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #36874 +/- ##
============================================
+ Coverage 40.33% 40.41% +0.07%
Complexity 3456 3456
============================================
Files 1225 1226 +1
Lines 187817 187952 +135
Branches 3586 3586
============================================
+ Hits 75762 75961 +199
+ Misses 108665 108601 -64
Partials 3390 3390
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/36874/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/beam/pull/36874/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.75% <0.00%> (+0.18%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/beam/pull/36874?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #36874:
URL: https://github.com/apache/beam/pull/36874#issuecomment-3572683618
> assign set of reviewers @damccorm
Drive-by: the syntax for the review command is like so: `R: @damccorm`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36874:
URL: https://github.com/apache/beam/pull/36874#issuecomment-3563044084
Assigning reviewers:
R: @tvalentyn for label python.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36874:
URL: https://github.com/apache/beam/pull/36874#issuecomment-3563038501
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #36874:
URL: https://github.com/apache/beam/pull/36874#discussion_r2566953916
##########
sdks/python/apache_beam/yaml/extended_tests/data/enrichment.yaml:
##########
@@ -82,6 +82,8 @@ pipelines:
- type: AssertEqual
config:
elements:
+ - {label: '11a', rank: 0, name: 'S1'}
- {label: '37a', rank: 1, name: 'S2'}
+ - {label: '389a', rank: 2, name: 'S3'}
Review Comment:
When I looked at this the other day, I found it is a flaky test.
https://github.com/apache/beam/actions/runs/19349133623/job/55356733649
In the run above, one was successful, while the others were not.
The perm-red started around 11/13, but I did not see any related change there.
https://github.com/apache/beam/issues/35198#issuecomment-3573557297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on code in PR #36874:
URL: https://github.com/apache/beam/pull/36874#discussion_r2560910425
##########
sdks/python/apache_beam/transforms/enrichment_handlers/bigquery.py:
##########
@@ -141,11 +141,13 @@ def __init__(
self.project = project
self.column_names = column_names
self.select_fields = ",".join(column_names) if column_names else '*'
- self.row_restriction_template = row_restriction_template
+ self.row_restriction_template = (
+ row_restriction_template.replace('{{}}', '{}'))
self.table_name = table_name
self.fields = fields if fields else []
self.condition_value_fn = condition_value_fn
self.query_fn = query_fn
+ self._has_placeholders = '{}' in self.row_restriction_template
Review Comment:
Okay I will remove the placeholder logic here and will make the handler will try to match by key first, and if there are unmatched requests like hardcoded templates it will pair them with the same result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on code in PR #36874:
URL: https://github.com/apache/beam/pull/36874#discussion_r2560909831
##########
sdks/python/apache_beam/yaml/extended_tests/data/enrichment.yaml:
##########
@@ -62,7 +62,7 @@ pipelines:
project: apache-beam-testing
table_name: "{BQ_TABLE}"
fields: ['label']
- row_restriction_template: "label = '37a'"
+ row_restriction_template: "label = '{{}}'"
Review Comment:
Ah okay got it, I will revert it and will focus on fixing handler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on code in PR #36874:
URL: https://github.com/apache/beam/pull/36874#discussion_r2569267742
##########
sdks/python/apache_beam/yaml/extended_tests/data/enrichment.yaml:
##########
@@ -82,6 +82,8 @@ pipelines:
- type: AssertEqual
config:
elements:
+ - {label: '11a', rank: 0, name: 'S1'}
- {label: '37a', rank: 1, name: 'S2'}
+ - {label: '389a', rank: 2, name: 'S3'}
Review Comment:
Yes, row_restriction_template: "label = '37a'" should filter. The fix will use it as is so only matching rows get enriched and test expectation should align with this. and I'll run multiple times to verify stability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #36874:
URL: https://github.com/apache/beam/pull/36874#issuecomment-3563040318
assign set of reviewers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on code in PR #36874:
URL: https://github.com/apache/beam/pull/36874#discussion_r2566599851
##########
sdks/python/apache_beam/yaml/extended_tests/data/enrichment.yaml:
##########
@@ -82,6 +82,8 @@ pipelines:
- type: AssertEqual
config:
elements:
+ - {label: '11a', rank: 0, name: 'S1'}
- {label: '37a', rank: 1, name: 'S2'}
+ - {label: '389a', rank: 2, name: 'S3'}
Review Comment:
The test expectation was incorrect. Before the fix, all inputs got the same result. After the fix, each input correctly matches its table row, so we now expect all 3 enriched rows with correct ranks (0, 1, 2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on code in PR #36874:
URL: https://github.com/apache/beam/pull/36874#discussion_r2571158487
##########
sdks/python/apache_beam/yaml/extended_tests/data/enrichment.yaml:
##########
@@ -82,6 +82,8 @@ pipelines:
- type: AssertEqual
config:
elements:
+ - {label: '11a', rank: 0, name: 'S1'}
- {label: '37a', rank: 1, name: 'S2'}
+ - {label: '389a', rank: 2, name: 'S3'}
Review Comment:
![Uploading image.png…]()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct Workflow [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36874:
URL: https://github.com/apache/beam/pull/36874#issuecomment-3805044301
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org