You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by tychobrailleur <gi...@git.apache.org> on 2016/09/06 19:43:04 UTC
[GitHub] groovy pull request #415: Remove outdated parser loading logic.
GitHub user tychobrailleur opened a pull request:
https://github.com/apache/groovy/pull/415
Remove outdated parser loading logic.
It looks like a long time ago there were two Groovy parsers, a \u201cClassic\u201d
and Antlr. The Antlr one was loaded using reflection, while the classic
one was simply instantiated. The reflection logic was kept after
definitely switching to Antlr (cf. ebeff74), although it is still
normally instantiated if reflection fails.
This commit simply removes all the reflection stuff.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tychobrailleur/groovy patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/groovy/pull/415.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #415
----
commit 85e6d25a4ae3e3124633688bc6273ea86514e31b
Author: S�bastien Le Callonnec <se...@weblogism.com>
Date: 2016-09-06T19:14:56Z
Remove outdated parser loading logic.
It looks like a long time ago there were two Groovy parsers, a \u201cClassic\u201d
and Antlr. The Antlr one was loaded using reflection, while the classic
one was simply instantiated. The reflection logic was kept after
definitely switching to Antlr (cf. ebeff74), although it is still
normally instantiated if reflection fails.
This commit simply removes all the reflection stuff.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request #415: Remove outdated parser loading logic.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/415
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---