You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/07 03:08:58 UTC

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #6639: fix visit subquery in projection

tristaZero commented on a change in pull request #6639:
URL: https://github.com/apache/shardingsphere/pull/6639#discussion_r466795831



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dml/predicate/value/PredicateCompareRightValue.java
##########
@@ -28,6 +28,10 @@
 @Getter
 public final class PredicateCompareRightValue implements PredicateRightValue {
     
+    private final int startIndex;

Review comment:
       Do you think it is better to add `SQLSegment` interface for these `PredicateRightValue `?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org