[GitHub] [superset] srinify commented on a diff in pull request #21319: feat(embedded-dashboard): Share Switchboard State for Sending Events from Plugins

[GitBox <gi...@apache.org>]

srinify commented on code in PR #21319:
URL: https://github.com/apache/superset/pull/21319#discussion_r990138964


##########
superset-frontend/packages/superset-ui-switchboard/src/switchboard.ts:
##########
@@ -90,7 +90,7 @@ function isError(message: Message): message is ErrorMessage {
 export class Switchboard {
   port: MessagePort;
 
-  name: string;
+  name = '';

Review Comment:
   +1 to Ville's comment, I'd prefer `string` as well ... and rest of the file does it that way too!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org