You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bsf-dev@jakarta.apache.org by ant elder <an...@gmail.com> on 2009/03/22 00:32:32 UTC
BSF 3.0-beta3 release artifact review
Following the user list request [1] for a new release of BSF 3 to
support the latest JRuby engine i've done an update and created the
artifacts for a BSF 3.0-beta3 release. I've uploaded the artifacts to:
http://people.apache.org/~antelder/bsf/3.0-beta3-RC1/
and there's an SVN tag at:
https://svn.apache.org/repos/asf/jakarta/bsf/tags/bsf-3.0-beta3
Please review, if there are no issues I'll start a release vote in a few days.
Thanks!
...ant
[1] http://apache.markmail.org/message/yuhgpligafl7uw6q
---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
Re: BSF 3.0-beta3 release artifact review
Posted by ant elder <an...@apache.org>.
On Sun, Mar 22, 2009 at 6:53 PM, sebb <se...@gmail.com> wrote:
> On 22/03/2009, ant elder <an...@apache.org> wrote:
>> Many thanks for the review, comments in line. I've made these changes
>> in trunk, i'll wait a bit longer for further comments and then create
>> fresh artifacts.
>>
>> ...ant
>>
>>
>> On Sun, Mar 22, 2009 at 1:22 AM, sebb <se...@gmail.com> wrote:
>> > On 21/03/2009, ant elder <an...@gmail.com> wrote:
>> >> Following the user list request [1] for a new release of BSF 3 to
>> >> support the latest JRuby engine i've done an update and created the
>> >> artifacts for a BSF 3.0-beta3 release. I've uploaded the artifacts to:
>> >>
>> >> http://people.apache.org/~antelder/bsf/3.0-beta3-RC1/
>> >>
>> >> and there's an SVN tag at:
>> >>
>> >> https://svn.apache.org/repos/asf/jakarta/bsf/tags/bsf-3.0-beta3
>> >
>> > Notice says:
>> > Copyright (c) 2005 - 2007
>> > Should probably be 2009; also the product name is missing - should be
>> > on first line.
>>
>>
>> Fixed
>>
>>
>> > Also, the POM says <inceptionYear>1999</inceptionYear>, so perhaps
>> > that should be 1999-2009
>> >
>>
>>
>> Fixed
>>
>>
>> > Release Notes says:
>> > Apache BSF 3 Beta2 Release Notes
>> > [should be Beta 3]
>> >
>>
>>
>> Fixed
>>
>>
>> > "This 3.0-beta3 release is a maintenance release updating to support
>> > for the latest releases
>> > of various script language engines."
>> >
>> > That does not read well.
>> >
>>
>>
>> Changed to "...maintenance release update to support..."
>>
>>
>>
>> > It would be helpful if the top-level BUILDING file stated the minimum
>> > Java version required (appears to be 1.4.2, according to
>> > /distribution/src/bin/README).
>> >
>>
>>
>> Added a comment saying BSF requires Java 1.4.2 to build
>>
>>
>> > JUnit 3.8.2 would be a better choice for Java 1.4+
>>
>>
>> Updated to use JUnit 3.8.2
>>
>>
>> >
>> > The jar files all seem to have NOTICE and LICENSE files, which is
>> > good, and the MANIFEST is good - except it would be nice to include
>> > the java source and target versions as well.
>>
>>
>> Added X-Compile-Source-JDK and X-Compile-Target-JDK entries saying 1.4.2.
>>
>>
>> >
>> > Class ScriptEngineManager imports "sun.misc.Service" which means that
>> > the code is only likely to work on a Sun JVM.
>> >
>>
>>
>> Changed to use javax.imageio.spi.ServiceRegistry.
>>
>>
>>
>> > Build fails when using Java 1.4.2, because
>> >
>> > bsf-api\src\main\java\javax\script\SimpleScriptContext.java uses
>> > Integer.valueOf(int) which is Java 1.5+.
>> >
>>
>>
>> Updated to use "Integer.valueOf(Integer.toString(int)))".
>
> That is considerably less efficient than new Integer(int).
>
Heh, yes i thought that seemed a bit of a daft way to be doing it,
updated to use new Integer(int) in r757236
>>
>> > Fails to download WS02 Rhino POM, so could not complete build.
>> >
>>
>>
>> This is working ok for me and the repository is accessible at
>> http://dist.wso2.org/maven2 when i try now, maybe it was down when you
>> tried?
>>
>
> But Maven was actually trying:
>
> http://www-lk.wso2.com/~thilina/repository
>
> Perhaps that repo should be disabled or removed?
>
> [It's in testing/e4x/pom.xml]
>
Thanks yes i agree as the comment says it was a temporary repo so i've
removed it in r757235
...ant
---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
Re: BSF 3.0-beta3 release artifact review
Posted by sebb <se...@gmail.com>.
On 22/03/2009, ant elder <an...@apache.org> wrote:
> Many thanks for the review, comments in line. I've made these changes
> in trunk, i'll wait a bit longer for further comments and then create
> fresh artifacts.
>
> ...ant
>
>
> On Sun, Mar 22, 2009 at 1:22 AM, sebb <se...@gmail.com> wrote:
> > On 21/03/2009, ant elder <an...@gmail.com> wrote:
> >> Following the user list request [1] for a new release of BSF 3 to
> >> support the latest JRuby engine i've done an update and created the
> >> artifacts for a BSF 3.0-beta3 release. I've uploaded the artifacts to:
> >>
> >> http://people.apache.org/~antelder/bsf/3.0-beta3-RC1/
> >>
> >> and there's an SVN tag at:
> >>
> >> https://svn.apache.org/repos/asf/jakarta/bsf/tags/bsf-3.0-beta3
> >
> > Notice says:
> > Copyright (c) 2005 - 2007
> > Should probably be 2009; also the product name is missing - should be
> > on first line.
>
>
> Fixed
>
>
> > Also, the POM says <inceptionYear>1999</inceptionYear>, so perhaps
> > that should be 1999-2009
> >
>
>
> Fixed
>
>
> > Release Notes says:
> > Apache BSF 3 Beta2 Release Notes
> > [should be Beta 3]
> >
>
>
> Fixed
>
>
> > "This 3.0-beta3 release is a maintenance release updating to support
> > for the latest releases
> > of various script language engines."
> >
> > That does not read well.
> >
>
>
> Changed to "...maintenance release update to support..."
>
>
>
> > It would be helpful if the top-level BUILDING file stated the minimum
> > Java version required (appears to be 1.4.2, according to
> > /distribution/src/bin/README).
> >
>
>
> Added a comment saying BSF requires Java 1.4.2 to build
>
>
> > JUnit 3.8.2 would be a better choice for Java 1.4+
>
>
> Updated to use JUnit 3.8.2
>
>
> >
> > The jar files all seem to have NOTICE and LICENSE files, which is
> > good, and the MANIFEST is good - except it would be nice to include
> > the java source and target versions as well.
>
>
> Added X-Compile-Source-JDK and X-Compile-Target-JDK entries saying 1.4.2.
>
>
> >
> > Class ScriptEngineManager imports "sun.misc.Service" which means that
> > the code is only likely to work on a Sun JVM.
> >
>
>
> Changed to use javax.imageio.spi.ServiceRegistry.
>
>
>
> > Build fails when using Java 1.4.2, because
> >
> > bsf-api\src\main\java\javax\script\SimpleScriptContext.java uses
> > Integer.valueOf(int) which is Java 1.5+.
> >
>
>
> Updated to use "Integer.valueOf(Integer.toString(int)))".
That is considerably less efficient than new Integer(int).
>
> > Fails to download WS02 Rhino POM, so could not complete build.
> >
>
>
> This is working ok for me and the repository is accessible at
> http://dist.wso2.org/maven2 when i try now, maybe it was down when you
> tried?
>
But Maven was actually trying:
http://www-lk.wso2.com/~thilina/repository
Perhaps that repo should be disabled or removed?
[It's in testing/e4x/pom.xml]
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
Re: BSF 3.0-beta3 release artifact review
Posted by "Rony G. Flatscher" <Ro...@wu-wien.ac.at>.
Hi ant,
>> Now it builds, however, one remark: one must juse Java 1.5 to build
>> because using 1.4.2 yields:
>>
>> ------------- cut here --------------
>>
... cut ...
> I've just tried using JDK 1.4.2 and it builds ok for me. There was a
> problem with bsf-utils using a backlevel version of javascript that
> was fixed in r757154, is it possible you've not picked up that change?
>
Not sure. Did a "svn update", "mvn clean", "mvn -e" using 1.4.2_12-b03,
still get the following error:
... cut ...
Hmm, while writing the above it came to my mind, that I might have
placed a few scripting languages into 'jre/lib/ext' a few years ago,
which then would be picked up before any other scirpting language jar on
the classpath. Just removed those jars from the ext directory and now it
works without a flaw!
Sorry for the false alarm!
(Will also report via the bsf list for lurkers to learn that for me it
builds nicely.)
Regards,
---rony
---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
Re: BSF 3.0-beta3 release artifact review
Posted by ant elder <an...@gmail.com>.
On Sun, Mar 22, 2009 at 10:04 PM, Rony G. Flatscher
<Ro...@wu-wien.ac.at> wrote:
> Hi ant,
>>> * problem creating the package, missing "mvn.bat" in "bsf-engines"
>>> (using maven 2.1.0 on XP SP3 and JDK 4.2, JDK 5, JDK 6):
>>>
>>> install-engines:
>>> [INFO]
>>> ------------------------------------------------------------------------
>>> [ERROR] BUILD ERROR
>>> [INFO]
>>> ------------------------------------------------------------------------
>>> [INFO] An Ant BuildException has occured: The following error
>>> occurred while executing this line:
>>> F:\work\svn\bsf\bsf3\bsf-engines\build.xml:39: Execute failed:
>>> java.io.IOException: Cannot run program "mvn.bat" (in directory
>>> "F:\work\svn\bsf\bsf3\bsf-engines"): CreateProcess error=5,
>>> Zugriff verweigert
>>>
>>> [INFO]
>>> ------------------------------------------------------------------------
>>> [INFO] Trace
>>> org.apache.maven.lifecycle.LifecycleExecutionException: An Ant
>>> BuildException has occured: The following error occurred while
>>> executing this line:
>>> F:\work\svn\bsf\bsf3\bsf-engines\build.xml:39: Execute failed:
>>> java.io.IOException: Cannot run program "mvn.bat" (in directory
>>> "F:\work\svn\bsf\bsf3\bsf-engines"): CreateProcess error=5,
>>> Zugriff verweigert
>>> at
>>> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:703)
>>> ... cut ...
>>>
>>>
>>
>> I'm not sure whats causing that, googling on "CreateProcess error=5"
>> various hits talk about permission problems and make suggestions like
>> "Please check the
>> permissions on these executables and their parent directories", could
>> there be some config thing you can change with your maven or bsf
>> directories?
>>
> Well, I went back and made all directories up to and including the root
> fully accessible to everyone, using the Windows command line utility
> "cacls" (change access control lists) and made sure that also the ant
> and maven files and jars were set to full access to everyone. And lo and
> behold after doing the latter, was the error overcome.
>
> Now it builds, however, one remark: one must juse Java 1.5 to build
> because using 1.4.2 yields:
>
> ------------- cut here --------------
>
> [INFO] Building Apache BSF Utils
> [INFO] task-segment: [install]
> [INFO] ------------------------------------------------------------------------
> [INFO] [resources:resources]
> [WARNING] Using platform encoding (Cp1252 actually) to copy filtered resources, i.e. build is platform dependent!
> [INFO] Copying 2 resources
> [INFO] [compiler:compile]
> Compiling 14 source files to F:\work\svn\bsf\bsf3\bsf-utils\target\classes
> [INFO] ------------------------------------------------------------------------
> [ERROR] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Compilation failure
>
> F:\work\svn\bsf\bsf3\bsf-utils\src\main\java\org\apache\bsf\xml\JavaScriptE4XAxiomHelper.java:[95,20] cannot resolve symbol
> symbol : class Factory
> location: class org.mozilla.javascript.xml.XMLLib
>
> F:\work\svn\bsf\bsf3\bsf-utils\src\main\java\org\apache\bsf\xml\JavaScriptE4XAxiomHelper.java:[96,48] cannot resolve symbol
> symbol : variable Factory
> location: class org.mozilla.javascript.xml.XMLLib
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Trace
> org.apache.maven.BuildFailureException: Compilation failure
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:699)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:540)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:519)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:371
> )
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:332)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:181)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:356)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:137)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:356)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:324)
> at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
> at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
> at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
> Caused by: org.apache.maven.plugin.CompilationFailureException: Compilation failure
> at org.apache.maven.plugin.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:429)
> at org.apache.maven.plugin.CompilerMojo.execute(CompilerMojo.java:110)
> at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:483)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:678)
> ... 16 more
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 10 seconds
> [INFO] Finished at: Sun Mar 22 21:58:33 CET 2009
> [INFO] Final Memory: 13M/24M
> [INFO] ------------------------------------------------------------------------
>
> ------------- cut here --------------
>
> Regards,
>
> ---rony
>
I've just tried using JDK 1.4.2 and it builds ok for me. There was a
problem with bsf-utils using a backlevel version of javascript that
was fixed in r757154, is it possible you've not picked up that change?
...ant
---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
Re: BSF 3.0-beta3 release artifact review
Posted by "Rony G. Flatscher" <Ro...@wu-wien.ac.at>.
Hi ant,
>> * problem creating the package, missing "mvn.bat" in "bsf-engines"
>> (using maven 2.1.0 on XP SP3 and JDK 4.2, JDK 5, JDK 6):
>>
>> install-engines:
>> [INFO]
>> ------------------------------------------------------------------------
>> [ERROR] BUILD ERROR
>> [INFO]
>> ------------------------------------------------------------------------
>> [INFO] An Ant BuildException has occured: The following error
>> occurred while executing this line:
>> F:\work\svn\bsf\bsf3\bsf-engines\build.xml:39: Execute failed:
>> java.io.IOException: Cannot run program "mvn.bat" (in directory
>> "F:\work\svn\bsf\bsf3\bsf-engines"): CreateProcess error=5,
>> Zugriff verweigert
>>
>> [INFO]
>> ------------------------------------------------------------------------
>> [INFO] Trace
>> org.apache.maven.lifecycle.LifecycleExecutionException: An Ant
>> BuildException has occured: The following error occurred while
>> executing this line:
>> F:\work\svn\bsf\bsf3\bsf-engines\build.xml:39: Execute failed:
>> java.io.IOException: Cannot run program "mvn.bat" (in directory
>> "F:\work\svn\bsf\bsf3\bsf-engines"): CreateProcess error=5,
>> Zugriff verweigert
>> at
>> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:703)
>> ... cut ...
>>
>>
>
> I'm not sure whats causing that, googling on "CreateProcess error=5"
> various hits talk about permission problems and make suggestions like
> "Please check the
> permissions on these executables and their parent directories", could
> there be some config thing you can change with your maven or bsf
> directories?
>
Well, I went back and made all directories up to and including the root
fully accessible to everyone, using the Windows command line utility
"cacls" (change access control lists) and made sure that also the ant
and maven files and jars were set to full access to everyone. And lo and
behold after doing the latter, was the error overcome.
Now it builds, however, one remark: one must juse Java 1.5 to build
because using 1.4.2 yields:
------------- cut here --------------
[INFO] Building Apache BSF Utils
[INFO] task-segment: [install]
[INFO] ------------------------------------------------------------------------
[INFO] [resources:resources]
[WARNING] Using platform encoding (Cp1252 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] Copying 2 resources
[INFO] [compiler:compile]
Compiling 14 source files to F:\work\svn\bsf\bsf3\bsf-utils\target\classes
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Compilation failure
F:\work\svn\bsf\bsf3\bsf-utils\src\main\java\org\apache\bsf\xml\JavaScriptE4XAxiomHelper.java:[95,20] cannot resolve symbol
symbol : class Factory
location: class org.mozilla.javascript.xml.XMLLib
F:\work\svn\bsf\bsf3\bsf-utils\src\main\java\org\apache\bsf\xml\JavaScriptE4XAxiomHelper.java:[96,48] cannot resolve symbol
symbol : variable Factory
location: class org.mozilla.javascript.xml.XMLLib
[INFO] ------------------------------------------------------------------------
[INFO] Trace
org.apache.maven.BuildFailureException: Compilation failure
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:699)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:540)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:519)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:371
)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:332)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:181)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:356)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:137)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:356)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
Caused by: org.apache.maven.plugin.CompilationFailureException: Compilation failure
at org.apache.maven.plugin.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:429)
at org.apache.maven.plugin.CompilerMojo.execute(CompilerMojo.java:110)
at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:483)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:678)
... 16 more
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10 seconds
[INFO] Finished at: Sun Mar 22 21:58:33 CET 2009
[INFO] Final Memory: 13M/24M
[INFO] ------------------------------------------------------------------------
------------- cut here --------------
Regards,
---rony
Re: BSF 3.0-beta3 release artifact review
Posted by ant elder <an...@gmail.com>.
Thanks for looking Rony!
On Sun, Mar 22, 2009 at 3:03 PM, Rony G. Flatscher
<Ro...@wu-wien.ac.at> wrote:
> Hi ant,
>
> trying to help at least by building (and trying to getting off the rust):
>
> * little thing: trailing "y" in "Pythony":
>
> testing/python/pom.xml:31: <name>Apache BSF testing for
> Pythony</name>
>
Fixed
> * problem creating the package, missing "mvn.bat" in "bsf-engines"
> (using maven 2.1.0 on XP SP3 and JDK 4.2, JDK 5, JDK 6):
>
> install-engines:
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] BUILD ERROR
> [INFO]
> ------------------------------------------------------------------------
> [INFO] An Ant BuildException has occured: The following error
> occurred while executing this line:
> F:\work\svn\bsf\bsf3\bsf-engines\build.xml:39: Execute failed:
> java.io.IOException: Cannot run program "mvn.bat" (in directory
> "F:\work\svn\bsf\bsf3\bsf-engines"): CreateProcess error=5,
> Zugriff verweigert
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Trace
> org.apache.maven.lifecycle.LifecycleExecutionException: An Ant
> BuildException has occured: The following error occurred while
> executing this line:
> F:\work\svn\bsf\bsf3\bsf-engines\build.xml:39: Execute failed:
> java.io.IOException: Cannot run program "mvn.bat" (in directory
> "F:\work\svn\bsf\bsf3\bsf-engines"): CreateProcess error=5,
> Zugriff verweigert
> at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:703)
> ... cut ...
>
I'm not sure whats causing that, googling on "CreateProcess error=5"
various hits talk about permission problems and make suggestions like
"Please check the
permissions on these executables and their parent directories", could
there be some config thing you can change with your maven or bsf
directories?
...ant
---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
Re: BSF 3.0-beta3 release artifact review
Posted by "Rony G. Flatscher" <Ro...@wu-wien.ac.at>.
Hi ant,
trying to help at least by building (and trying to getting off the rust):
* little thing: trailing "y" in "Pythony":
testing/python/pom.xml:31: <name>Apache BSF testing for
Pythony</name>
* problem creating the package, missing "mvn.bat" in "bsf-engines"
(using maven 2.1.0 on XP SP3 and JDK 4.2, JDK 5, JDK 6):
install-engines:
[INFO]
------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO]
------------------------------------------------------------------------
[INFO] An Ant BuildException has occured: The following error
occurred while executing this line:
F:\work\svn\bsf\bsf3\bsf-engines\build.xml:39: Execute failed:
java.io.IOException: Cannot run program "mvn.bat" (in directory
"F:\work\svn\bsf\bsf3\bsf-engines"): CreateProcess error=5,
Zugriff verweigert
[INFO]
------------------------------------------------------------------------
[INFO] Trace
org.apache.maven.lifecycle.LifecycleExecutionException: An Ant
BuildException has occured: The following error occurred while
executing this line:
F:\work\svn\bsf\bsf3\bsf-engines\build.xml:39: Execute failed:
java.io.IOException: Cannot run program "mvn.bat" (in directory
"F:\work\svn\bsf\bsf3\bsf-engines"): CreateProcess error=5,
Zugriff verweigert
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:703)
... cut ...
---rony
Re: BSF 3.0-beta3 release artifact review
Posted by ant elder <an...@apache.org>.
Many thanks for the review, comments in line. I've made these changes
in trunk, i'll wait a bit longer for further comments and then create
fresh artifacts.
...ant
On Sun, Mar 22, 2009 at 1:22 AM, sebb <se...@gmail.com> wrote:
> On 21/03/2009, ant elder <an...@gmail.com> wrote:
>> Following the user list request [1] for a new release of BSF 3 to
>> support the latest JRuby engine i've done an update and created the
>> artifacts for a BSF 3.0-beta3 release. I've uploaded the artifacts to:
>>
>> http://people.apache.org/~antelder/bsf/3.0-beta3-RC1/
>>
>> and there's an SVN tag at:
>>
>> https://svn.apache.org/repos/asf/jakarta/bsf/tags/bsf-3.0-beta3
>
> Notice says:
> Copyright (c) 2005 - 2007
> Should probably be 2009; also the product name is missing - should be
> on first line.
Fixed
> Also, the POM says <inceptionYear>1999</inceptionYear>, so perhaps
> that should be 1999-2009
>
Fixed
> Release Notes says:
> Apache BSF 3 Beta2 Release Notes
> [should be Beta 3]
>
Fixed
> "This 3.0-beta3 release is a maintenance release updating to support
> for the latest releases
> of various script language engines."
>
> That does not read well.
>
Changed to "...maintenance release update to support..."
> It would be helpful if the top-level BUILDING file stated the minimum
> Java version required (appears to be 1.4.2, according to
> /distribution/src/bin/README).
>
Added a comment saying BSF requires Java 1.4.2 to build
> JUnit 3.8.2 would be a better choice for Java 1.4+
Updated to use JUnit 3.8.2
>
> The jar files all seem to have NOTICE and LICENSE files, which is
> good, and the MANIFEST is good - except it would be nice to include
> the java source and target versions as well.
Added X-Compile-Source-JDK and X-Compile-Target-JDK entries saying 1.4.2.
>
> Class ScriptEngineManager imports "sun.misc.Service" which means that
> the code is only likely to work on a Sun JVM.
>
Changed to use javax.imageio.spi.ServiceRegistry.
> Build fails when using Java 1.4.2, because
>
> bsf-api\src\main\java\javax\script\SimpleScriptContext.java uses
> Integer.valueOf(int) which is Java 1.5+.
>
Updated to use "Integer.valueOf(Integer.toString(int)))".
> Fails to download WS02 Rhino POM, so could not complete build.
>
This is working ok for me and the repository is accessible at
http://dist.wso2.org/maven2 when i try now, maybe it was down when you
tried?
---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
Re: BSF 3.0-beta3 release artifact review
Posted by sebb <se...@gmail.com>.
On 21/03/2009, ant elder <an...@gmail.com> wrote:
> Following the user list request [1] for a new release of BSF 3 to
> support the latest JRuby engine i've done an update and created the
> artifacts for a BSF 3.0-beta3 release. I've uploaded the artifacts to:
>
> http://people.apache.org/~antelder/bsf/3.0-beta3-RC1/
>
> and there's an SVN tag at:
>
> https://svn.apache.org/repos/asf/jakarta/bsf/tags/bsf-3.0-beta3
Notice says:
Copyright (c) 2005 - 2007
Should probably be 2009; also the product name is missing - should be
on first line.
Also, the POM says <inceptionYear>1999</inceptionYear>, so perhaps
that should be 1999-2009
Release Notes says:
Apache BSF 3 Beta2 Release Notes
[should be Beta 3]
"This 3.0-beta3 release is a maintenance release updating to support
for the latest releases
of various script language engines."
That does not read well.
It would be helpful if the top-level BUILDING file stated the minimum
Java version required (appears to be 1.4.2, according to
/distribution/src/bin/README).
JUnit 3.8.2 would be a better choice for Java 1.4+
The jar files all seem to have NOTICE and LICENSE files, which is
good, and the MANIFEST is good - except it would be nice to include
the java source and target versions as well.
Class ScriptEngineManager imports "sun.misc.Service" which means that
the code is only likely to work on a Sun JVM.
Build fails when using Java 1.4.2, because
bsf-api\src\main\java\javax\script\SimpleScriptContext.java uses
Integer.valueOf(int) which is Java 1.5+.
Fails to download WS02 Rhino POM, so could not complete build.
> Please review, if there are no issues I'll start a release vote in a few days.
>
> Thanks!
>
> ...ant
>
> [1] http://apache.markmail.org/message/yuhgpligafl7uw6q
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
Re: BSF 3.0-beta3 release artifact review
Posted by ant elder <an...@apache.org>.
On Mon, Mar 23, 2009 at 10:49 PM, sebb <se...@gmail.com> wrote:
> On 23/03/2009, ant elder <an...@apache.org> wrote:
>> On Mon, Mar 23, 2009 at 9:20 PM, sebb <se...@gmail.com> wrote:
>>
>> > Also, the encoding needs to be specified:
>> >
>> > [WARNING] Using platform encoding (Cp1252 actually) to copy filtered
>> > resources, i.e. build is platform dependent!
>> >
>>
>>
>> I don't see that warning when i build, do you know where its coming
>> from or how to fix it?
>>
>
> I think it comes from the resources plugin.
>
> The following fixed it for me.
> Add the following to the <properties> section in the top-level POM:
>
> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
>
>>
Thanks, i think i've fixed all those points now and have uploaded the
new artifacts.
Re the question about the com.sun package names, thats as BSF can use
the script engines from https://scripting.dev.java.net/ which use that
package name, that doesn't restrict it to the sun libraries though any
other script engines also work and those are ignored if not present.
...ant
---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
Re: BSF 3.0-beta3 release artifact review
Posted by sebb <se...@gmail.com>.
On 23/03/2009, ant elder <an...@apache.org> wrote:
> On Mon, Mar 23, 2009 at 9:20 PM, sebb <se...@gmail.com> wrote:
>
> > Also, the encoding needs to be specified:
> >
> > [WARNING] Using platform encoding (Cp1252 actually) to copy filtered
> > resources, i.e. build is platform dependent!
> >
>
>
> I don't see that warning when i build, do you know where its coming
> from or how to fix it?
>
I think it comes from the resources plugin.
The following fixed it for me.
Add the following to the <properties> section in the top-level POM:
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
>
> ...ant
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
Re: BSF 3.0-beta3 release artifact review
Posted by ant elder <an...@apache.org>.
On Mon, Mar 23, 2009 at 9:20 PM, sebb <se...@gmail.com> wrote:
> Also, the encoding needs to be specified:
>
> [WARNING] Using platform encoding (Cp1252 actually) to copy filtered
> resources, i.e. build is platform dependent!
>
I don't see that warning when i build, do you know where its coming
from or how to fix it?
...ant
---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
Re: BSF 3.0-beta3 release artifact review
Posted by sebb <se...@gmail.com>.
On 23/03/2009, ant elder <an...@gmail.com> wrote:
> Thanks seb and rony for you thorough reviews, i think i've fixed all
> the points raised and I've respun the release, artifacts at:
>
>
> http://people.apache.org/~antelder/bsf/3.0-beta3-RC1/
MD5 hash files have a format which may not work with some automated
checking utilities.
[can be fixed with a simple edit]
>
> and SVN tag at:
>
>
> https://svn.apache.org/repos/asf/jakarta/bsf/tags/bsf-3.0-beta3
The file RELEASE_NOTES is not in the source archive.
Some missing SVN properties:
svn ps svn:eol-style native RELEASE_NOTES
svn ps svn:eol-style native testing/jruby-1.1.2/pom.xml
svn ps svn:eol-style native
testing/jruby-1.1.2/src/test/java/org/apache/bsf/testing/javascript/RubyTestcase.java
svn ps svn:eol-style native testing/jruby-1.2.0/pom.xml
svn ps svn:eol-style native
testing/jruby-1.2.0/src/test/java/org/apache/bsf/testing/javascript/RubyTestcase.java
[Can be fixed later]
>
> Please review, if there are no other issues found I'll start a release
> vote shortly.
>
The file:
bsf-engines/src/main/resources/META-INF/services/javax.script.ScriptEngineFactory
has a lot of references to what appear to be Sun-specific classes, e.g.
com.sun.script.freemarker.FreeMarkerScriptEngineFactory
com.sun.script.groovy.GroovyScriptEngineFactory
com.sun.script.jacl.JaclScriptEngineFactory
com.sun.script.jaskell.JaskellScriptEngineFactory
etc. Does this mean the code will only work with Sun Java libraries?
==
"mvn test" failed:
[...]
create-bsf-all:
[unzip] Expanding: C:\Documents and
Settings\User\.m2\repository\org\apache\bsf\bsf-api\3.0-beta3\bsf-api-3.0-beta3.jar
into C:\ReleaseCheck\bsf-3
.0-beta3-src\distribution\target\bsf-all
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] An Ant BuildException has occured: The following error occurred
while executing this line:
C:\ReleaseCheck\bsf-3.0-beta3-src\distribution\build.xml:30: Error
while expanding C:\Documents and
Settings\User\.m2\repository\org\apache\bsf\bsf-ap
i\3.0-beta3\bsf-api-3.0-beta3.jar
java.io.FileNotFoundException: C:\Documents and
Settings\User\.m2\repository\org\apache\bsf\bsf-api\3.0-beta3\bsf-api-3.0-beta3.jar
(The system cannot
find the path specified)
However, I then ran "mvn" and that worked, as did a subsequent "mvn test".
Also, the encoding needs to be specified:
[WARNING] Using platform encoding (Cp1252 actually) to copy filtered
resources, i.e. build is platform dependent!
> ...ant
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
Re: BSF 3.0-beta3 release artifact review
Posted by ant elder <an...@gmail.com>.
Thanks seb and rony for you thorough reviews, i think i've fixed all
the points raised and I've respun the release, artifacts at:
http://people.apache.org/~antelder/bsf/3.0-beta3-RC1/
and SVN tag at:
https://svn.apache.org/repos/asf/jakarta/bsf/tags/bsf-3.0-beta3
Please review, if there are no other issues found I'll start a release
vote shortly.
...ant
---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org